From: Doug Anderson <dianders@chromium.org>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Will Newton <will.newton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
linux-kernel@vger.kernel.org,
Grant Grundler <grundler@chromium.org>,
Olof Johansson <olofj@chromium.org>,
shashidharh@vayavyalabs.com, ki0351.kim@samsung.com
Subject: Re: [PATCH v2] mmc: dw_mmc: Disable low power mode if SDIO interrupts are used
Date: Tue, 24 Jul 2012 09:58:23 -0700 [thread overview]
Message-ID: <CAD=FV=WeX+TACSR+z7ynmurnSnayGc30_gFRtnek=Mv-c3o3JA@mail.gmail.com> (raw)
In-Reply-To: <004d01cd693a$0a55d7b0$1f018710$%jun@samsung.com>
On Mon, Jul 23, 2012 at 6:17 PM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> I have followed this patch from v1.
> I think it's a good point.
> Looks good to me.
Thanks for the review! Looking forward to your ack with the next version. :)
> Above comment is correct, but this is not specific for Exynos5250.
> Exynos5250 is just one of host controllers base on Synopsys's.
> It'd be better to remove the part related to Exynos you mentioned .
Done. Grant had requested me to quote exactly which manual I found
the requirement in, but I think describing just that it was found in
the description of the CLKENA register is enough. I've changed it.
> Definitely, low power mode not power mode, right?
Done. Good catch!
-Doug
next prev parent reply other threads:[~2012-07-24 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 18:13 [PATCH] mmc: dw_mmc: Disable low power mode if SDIO interrupts are used Doug Anderson
2012-07-21 10:40 ` Will Newton
2012-07-23 2:48 ` Doug Anderson
2012-07-23 9:19 ` Will Newton
2012-07-23 17:00 ` Doug Anderson
2012-07-23 17:02 ` [PATCH v2] " Doug Anderson
2012-07-24 1:17 ` Seungwon Jeon
2012-07-24 16:58 ` Doug Anderson [this message]
2012-07-24 1:36 ` Jaehoon Chung
2012-07-24 16:58 ` Doug Anderson
2012-07-24 16:59 ` [PATCH v3] " Doug Anderson
2012-07-25 9:11 ` Will Newton
2012-07-25 10:02 ` Jaehoon Chung
2012-07-25 15:32 ` Doug Anderson
2012-07-25 15:33 ` [PATCH v4] " Doug Anderson
2012-07-26 4:00 ` Seungwon Jeon
2012-08-08 3:40 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WeX+TACSR+z7ynmurnSnayGc30_gFRtnek=Mv-c3o3JA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=cjb@laptop.org \
--cc=grundler@chromium.org \
--cc=james.hogan@imgtec.com \
--cc=jh80.chung@samsung.com \
--cc=ki0351.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olofj@chromium.org \
--cc=shashidharh@vayavyalabs.com \
--cc=tgih.jun@samsung.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).