* [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table
@ 2012-07-19 7:39 Feng Tang
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Feng Tang @ 2012-07-19 7:39 UTC (permalink / raw)
To: Len Brown, linux-kernel
Cc: x86, Yinghai Lu, Suresh Siddha, Donald Dutile, Alexander Gordeev,
Bob Moore, Lin Ming, Feng Tang
---
arch/x86/kernel/apic/es7000_32.c | 7 +++----
drivers/acpi/tables.c | 21 +++++++++------------
drivers/iommu/dmar.c | 14 +++++++-------
3 files changed, 19 insertions(+), 23 deletions(-)
diff --git a/arch/x86/kernel/apic/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
index db4ab1b..63f92ef 100644
--- a/arch/x86/kernel/apic/es7000_32.c
+++ b/arch/x86/kernel/apic/es7000_32.c
@@ -242,19 +242,18 @@ static int __init find_unisys_acpi_oem_table(unsigned long *oem_addr)
{
struct acpi_table_header *header = NULL;
struct es7000_oem_table *table;
- acpi_size tbl_size;
acpi_status ret;
int i = 0;
for (;;) {
- ret = acpi_get_table_with_size("OEM1", i++, &header, &tbl_size);
+ ret = acpi_get_table("OEM1", i++, &header);
if (!ACPI_SUCCESS(ret))
return -1;
if (!memcmp((char *) &header->oem_id, "UNISYS", 6))
break;
- early_acpi_os_unmap_memory(header, tbl_size);
+ early_acpi_os_unmap_memory(header, header->length);
}
table = (void *)header;
@@ -262,7 +261,7 @@ static int __init find_unisys_acpi_oem_table(unsigned long *oem_addr)
oem_addrX = table->OEMTableAddr;
oem_size = table->OEMTableSize;
- early_acpi_os_unmap_memory(header, tbl_size);
+ early_acpi_os_unmap_memory(header, header->length);
*oem_addr = (unsigned long)__acpi_map_table(oem_addrX, oem_size);
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index f336bca..5b8b7e0 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -211,7 +211,6 @@ acpi_table_parse_entries(char *id,
struct acpi_subtable_header *entry;
unsigned int count = 0;
unsigned long table_end;
- acpi_size tbl_size;
if (acpi_disabled)
return -ENODEV;
@@ -220,9 +219,9 @@ acpi_table_parse_entries(char *id,
return -EINVAL;
if (strncmp(id, ACPI_SIG_MADT, 4) == 0)
- acpi_get_table_with_size(id, acpi_apic_instance, &table_header, &tbl_size);
+ acpi_get_table(id, acpi_apic_instance, &table_header);
else
- acpi_get_table_with_size(id, 0, &table_header, &tbl_size);
+ acpi_get_table(id, 0, &table_header);
if (!table_header) {
printk(KERN_WARNING PREFIX "%4.4s not present\n", id);
@@ -241,7 +240,7 @@ acpi_table_parse_entries(char *id,
if (entry->type == entry_id
&& (!max_entries || count++ < max_entries))
if (handler(entry, table_end)) {
- early_acpi_os_unmap_memory((char *)table_header, tbl_size);
+ early_acpi_os_unmap_memory((char *)table_header, table_header->length);
return -EINVAL;
}
@@ -253,7 +252,7 @@ acpi_table_parse_entries(char *id,
"%i found\n", id, entry_id, count - max_entries, count);
}
- early_acpi_os_unmap_memory((char *)table_header, tbl_size);
+ early_acpi_os_unmap_memory((char *)table_header, table_header->length);
return count;
}
@@ -278,7 +277,6 @@ acpi_table_parse_madt(enum acpi_madt_type id,
int __init acpi_table_parse(char *id, acpi_table_handler handler)
{
struct acpi_table_header *table = NULL;
- acpi_size tbl_size;
if (acpi_disabled)
return -ENODEV;
@@ -287,13 +285,13 @@ int __init acpi_table_parse(char *id, acpi_table_handler handler)
return -EINVAL;
if (strncmp(id, ACPI_SIG_MADT, 4) == 0)
- acpi_get_table_with_size(id, acpi_apic_instance, &table, &tbl_size);
+ acpi_get_table(id, acpi_apic_instance, &table);
else
- acpi_get_table_with_size(id, 0, &table, &tbl_size);
+ acpi_get_table(id, 0, &table);
if (table) {
handler(table);
- early_acpi_os_unmap_memory(table, tbl_size);
+ early_acpi_os_unmap_memory(table, table->length);
return 0;
} else
return 1;
@@ -307,9 +305,8 @@ int __init acpi_table_parse(char *id, acpi_table_handler handler)
static void __init check_multiple_madt(void)
{
struct acpi_table_header *table = NULL;
- acpi_size tbl_size;
- acpi_get_table_with_size(ACPI_SIG_MADT, 2, &table, &tbl_size);
+ acpi_get_table(ACPI_SIG_MADT, 2, &table);
if (table) {
printk(KERN_WARNING PREFIX
"BIOS bug: multiple APIC/MADT found,"
@@ -318,7 +315,7 @@ static void __init check_multiple_madt(void)
"If \"acpi_apic_instance=%d\" works better, "
"notify linux-acpi@vger.kernel.org\n",
acpi_apic_instance ? 0 : 2);
- early_acpi_os_unmap_memory(table, tbl_size);
+ early_acpi_os_unmap_memory(table, table->length);
} else
acpi_apic_instance = 0;
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 3a74e44..e0f4dbf 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -48,7 +48,6 @@
LIST_HEAD(dmar_drhd_units);
struct acpi_table_header * __initdata dmar_tbl;
-static acpi_size dmar_tbl_size;
static void __init dmar_register_drhd_unit(struct dmar_drhd_unit *drhd)
{
@@ -294,10 +293,8 @@ static int __init dmar_table_detect(void)
acpi_status status = AE_OK;
/* if we could find DMAR table, then there are DMAR devices */
- status = acpi_get_table_with_size(ACPI_SIG_DMAR, 0,
- (struct acpi_table_header **)&dmar_tbl,
- &dmar_tbl_size);
-
+ status = acpi_get_table(ACPI_SIG_DMAR, 0,
+ (struct acpi_table_header **)&dmar_tbl);
if (ACPI_SUCCESS(status) && !dmar_tbl) {
printk (KERN_WARNING PREFIX "Unable to map DMAR\n");
status = AE_NOT_FOUND;
@@ -572,8 +569,11 @@ int __init detect_intel_iommu(void)
x86_init.iommu.iommu_init = intel_iommu_init;
#endif
}
- early_acpi_os_unmap_memory(dmar_tbl, dmar_tbl_size);
- dmar_tbl = NULL;
+
+ if (dmar_tbl) {
+ early_acpi_os_unmap_memory(dmar_tbl, dmar_tbl->length);
+ dmar_tbl = NULL;
+ }
return ret ? 1 : -ENODEV;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion
2012-07-19 7:39 [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
@ 2012-07-19 7:39 ` Feng Tang
2012-07-19 7:47 ` Feng Tang
2012-07-31 3:21 ` Len Brown
2012-07-19 7:45 ` [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-31 3:20 ` Len Brown
2 siblings, 2 replies; 8+ messages in thread
From: Feng Tang @ 2012-07-19 7:39 UTC (permalink / raw)
To: Len Brown, linux-kernel
Cc: x86, Yinghai Lu, Suresh Siddha, Donald Dutile, Alexander Gordeev,
Bob Moore, Lin Ming, Feng Tang
---
drivers/acpi/acpica/tbxface.c | 18 +++---------------
include/acpi/acpixf.h | 4 ----
2 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c
index abcc641..3daf93d 100644
--- a/drivers/acpi/acpica/tbxface.c
+++ b/drivers/acpi/acpica/tbxface.c
@@ -380,7 +380,7 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
/*******************************************************************************
*
- * FUNCTION: acpi_get_table_with_size
+ * FUNCTION: acpi_get_table
*
* PARAMETERS: Signature - ACPI signature of needed table
* Instance - Which instance (for SSDTs)
@@ -392,9 +392,8 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
*
******************************************************************************/
acpi_status
-acpi_get_table_with_size(char *signature,
- u32 instance, struct acpi_table_header **out_table,
- acpi_size *tbl_size)
+acpi_get_table(char *signature,
+ u32 instance, struct acpi_table_header **out_table)
{
u32 i;
u32 j;
@@ -424,7 +423,6 @@ acpi_get_table_with_size(char *signature,
acpi_tb_verify_table(&acpi_gbl_root_table_list.tables[i]);
if (ACPI_SUCCESS(status)) {
*out_table = acpi_gbl_root_table_list.tables[i].pointer;
- *tbl_size = acpi_gbl_root_table_list.tables[i].length;
}
if (!acpi_gbl_permanent_mmap) {
@@ -436,16 +434,6 @@ acpi_get_table_with_size(char *signature,
return (AE_NOT_FOUND);
}
-
-acpi_status
-acpi_get_table(char *signature,
- u32 instance, struct acpi_table_header **out_table)
-{
- acpi_size tbl_size;
-
- return acpi_get_table_with_size(signature,
- instance, out_table, &tbl_size);
-}
ACPI_EXPORT_SYMBOL(acpi_get_table)
/*******************************************************************************
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 9821101..56de5a3 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -172,10 +172,6 @@ acpi_get_table_header(acpi_string signature,
struct acpi_table_header *out_table_header);
acpi_status
-acpi_get_table_with_size(acpi_string signature,
- u32 instance, struct acpi_table_header **out_table,
- acpi_size *tbl_size);
-acpi_status
acpi_get_table(acpi_string signature,
u32 instance, struct acpi_table_header **out_table);
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table
2012-07-19 7:39 [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
@ 2012-07-19 7:45 ` Feng Tang
2012-07-31 3:20 ` Len Brown
2 siblings, 0 replies; 8+ messages in thread
From: Feng Tang @ 2012-07-19 7:45 UTC (permalink / raw)
To: Len Brown, linux-kernel
Cc: x86, Yinghai Lu, Suresh Siddha, Donald Dutile, Alexander Gordeev,
Bob Moore, Lin Ming
Update the commit log.
Thanks,
Feng
>From 633ba8625e9ae1999b94edac514a11ddbc4176ef Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Thu, 19 Jul 2012 15:10:02 +0800
Subject: [PATCH 1/2] ACPI: Replace acpi_get_table_with_size() with acpi_get_table()
This is a preparation for removing the acpi_get_table_with_size(), as this
function could be well covered by acpi_get_table(), and there is no need
to have both of them to exist.
Signed-off-by: Feng Tang <feng.tang@intel.com>
Cc: x86@kernel.org
---
arch/x86/kernel/apic/es7000_32.c | 7 +++----
drivers/acpi/tables.c | 21 +++++++++------------
drivers/iommu/dmar.c | 14 +++++++-------
3 files changed, 19 insertions(+), 23 deletions(-)
diff --git a/arch/x86/kernel/apic/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
index 0874799..ae30b39 100644
--- a/arch/x86/kernel/apic/es7000_32.c
+++ b/arch/x86/kernel/apic/es7000_32.c
@@ -242,19 +242,18 @@ static int __init find_unisys_acpi_oem_table(unsigned long *oem_addr)
{
struct acpi_table_header *header = NULL;
struct es7000_oem_table *table;
- acpi_size tbl_size;
acpi_status ret;
int i = 0;
for (;;) {
- ret = acpi_get_table_with_size("OEM1", i++, &header, &tbl_size);
+ ret = acpi_get_table("OEM1", i++, &header);
if (!ACPI_SUCCESS(ret))
return -1;
if (!memcmp((char *) &header->oem_id, "UNISYS", 6))
break;
- early_acpi_os_unmap_memory(header, tbl_size);
+ early_acpi_os_unmap_memory(header, header->length);
}
table = (void *)header;
@@ -262,7 +261,7 @@ static int __init find_unisys_acpi_oem_table(unsigned long *oem_addr)
oem_addrX = table->OEMTableAddr;
oem_size = table->OEMTableSize;
- early_acpi_os_unmap_memory(header, tbl_size);
+ early_acpi_os_unmap_memory(header, header->length);
*oem_addr = (unsigned long)__acpi_map_table(oem_addrX, oem_size);
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index f336bca..5b8b7e0 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -211,7 +211,6 @@ acpi_table_parse_entries(char *id,
struct acpi_subtable_header *entry;
unsigned int count = 0;
unsigned long table_end;
- acpi_size tbl_size;
if (acpi_disabled)
return -ENODEV;
@@ -220,9 +219,9 @@ acpi_table_parse_entries(char *id,
return -EINVAL;
if (strncmp(id, ACPI_SIG_MADT, 4) == 0)
- acpi_get_table_with_size(id, acpi_apic_instance, &table_header, &tbl_size);
+ acpi_get_table(id, acpi_apic_instance, &table_header);
else
- acpi_get_table_with_size(id, 0, &table_header, &tbl_size);
+ acpi_get_table(id, 0, &table_header);
if (!table_header) {
printk(KERN_WARNING PREFIX "%4.4s not present\n", id);
@@ -241,7 +240,7 @@ acpi_table_parse_entries(char *id,
if (entry->type == entry_id
&& (!max_entries || count++ < max_entries))
if (handler(entry, table_end)) {
- early_acpi_os_unmap_memory((char *)table_header, tbl_size);
+ early_acpi_os_unmap_memory((char *)table_header, table_header->length);
return -EINVAL;
}
@@ -253,7 +252,7 @@ acpi_table_parse_entries(char *id,
"%i found\n", id, entry_id, count - max_entries, count);
}
- early_acpi_os_unmap_memory((char *)table_header, tbl_size);
+ early_acpi_os_unmap_memory((char *)table_header, table_header->length);
return count;
}
@@ -278,7 +277,6 @@ acpi_table_parse_madt(enum acpi_madt_type id,
int __init acpi_table_parse(char *id, acpi_table_handler handler)
{
struct acpi_table_header *table = NULL;
- acpi_size tbl_size;
if (acpi_disabled)
return -ENODEV;
@@ -287,13 +285,13 @@ int __init acpi_table_parse(char *id, acpi_table_handler handler)
return -EINVAL;
if (strncmp(id, ACPI_SIG_MADT, 4) == 0)
- acpi_get_table_with_size(id, acpi_apic_instance, &table, &tbl_size);
+ acpi_get_table(id, acpi_apic_instance, &table);
else
- acpi_get_table_with_size(id, 0, &table, &tbl_size);
+ acpi_get_table(id, 0, &table);
if (table) {
handler(table);
- early_acpi_os_unmap_memory(table, tbl_size);
+ early_acpi_os_unmap_memory(table, table->length);
return 0;
} else
return 1;
@@ -307,9 +305,8 @@ int __init acpi_table_parse(char *id, acpi_table_handler handler)
static void __init check_multiple_madt(void)
{
struct acpi_table_header *table = NULL;
- acpi_size tbl_size;
- acpi_get_table_with_size(ACPI_SIG_MADT, 2, &table, &tbl_size);
+ acpi_get_table(ACPI_SIG_MADT, 2, &table);
if (table) {
printk(KERN_WARNING PREFIX
"BIOS bug: multiple APIC/MADT found,"
@@ -318,7 +315,7 @@ static void __init check_multiple_madt(void)
"If \"acpi_apic_instance=%d\" works better, "
"notify linux-acpi@vger.kernel.org\n",
acpi_apic_instance ? 0 : 2);
- early_acpi_os_unmap_memory(table, tbl_size);
+ early_acpi_os_unmap_memory(table, table->length);
} else
acpi_apic_instance = 0;
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 86e2f4a..aa65b6f 100644
--- a/drivers/iommu/dmar.c
+++ b/drivers/iommu/dmar.c
@@ -48,7 +48,6 @@
LIST_HEAD(dmar_drhd_units);
struct acpi_table_header * __initdata dmar_tbl;
-static acpi_size dmar_tbl_size;
static void __init dmar_register_drhd_unit(struct dmar_drhd_unit *drhd)
{
@@ -285,10 +284,8 @@ static int __init dmar_table_detect(void)
acpi_status status = AE_OK;
/* if we could find DMAR table, then there are DMAR devices */
- status = acpi_get_table_with_size(ACPI_SIG_DMAR, 0,
- (struct acpi_table_header **)&dmar_tbl,
- &dmar_tbl_size);
-
+ status = acpi_get_table(ACPI_SIG_DMAR, 0,
+ (struct acpi_table_header **)&dmar_tbl);
if (ACPI_SUCCESS(status) && !dmar_tbl) {
pr_warn("Unable to map DMAR\n");
status = AE_NOT_FOUND;
@@ -558,8 +555,11 @@ int __init detect_intel_iommu(void)
x86_init.iommu.iommu_init = intel_iommu_init;
#endif
}
- early_acpi_os_unmap_memory(dmar_tbl, dmar_tbl_size);
- dmar_tbl = NULL;
+
+ if (dmar_tbl) {
+ early_acpi_os_unmap_memory(dmar_tbl, dmar_tbl->length);
+ dmar_tbl = NULL;
+ }
return ret ? 1 : -ENODEV;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
@ 2012-07-19 7:47 ` Feng Tang
2012-07-31 3:21 ` Len Brown
1 sibling, 0 replies; 8+ messages in thread
From: Feng Tang @ 2012-07-19 7:47 UTC (permalink / raw)
To: Len Brown, linux-kernel
Cc: x86, Yinghai Lu, Suresh Siddha, Donald Dutile, Alexander Gordeev,
Bob Moore, Lin Ming
Update the commit log.
Thanks,
Feng
>From 61e3349625843bd9e4c353598ec50a2333409986 Mon Sep 17 00:00:00 2001
From: Feng Tang <feng.tang@intel.com>
Date: Wed, 18 Jul 2012 15:01:18 +0800
Subject: [PATCH 2/2] ACPI: Remove acpi_get_table_with_size() fucntion
Remove the unnecessary acpi_get_table_with_size(), as it could
be well covered by acpi_get_table().
Signed-off-by: Feng Tang <feng.tang@intel.com>
---
drivers/acpi/acpica/tbxface.c | 18 +++---------------
include/acpi/acpixf.h | 4 ----
2 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/acpi/acpica/tbxface.c b/drivers/acpi/acpica/tbxface.c
index abcc641..3daf93d 100644
--- a/drivers/acpi/acpica/tbxface.c
+++ b/drivers/acpi/acpica/tbxface.c
@@ -380,7 +380,7 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
/*******************************************************************************
*
- * FUNCTION: acpi_get_table_with_size
+ * FUNCTION: acpi_get_table
*
* PARAMETERS: Signature - ACPI signature of needed table
* Instance - Which instance (for SSDTs)
@@ -392,9 +392,8 @@ ACPI_EXPORT_SYMBOL(acpi_unload_table_id)
*
******************************************************************************/
acpi_status
-acpi_get_table_with_size(char *signature,
- u32 instance, struct acpi_table_header **out_table,
- acpi_size *tbl_size)
+acpi_get_table(char *signature,
+ u32 instance, struct acpi_table_header **out_table)
{
u32 i;
u32 j;
@@ -424,7 +423,6 @@ acpi_get_table_with_size(char *signature,
acpi_tb_verify_table(&acpi_gbl_root_table_list.tables[i]);
if (ACPI_SUCCESS(status)) {
*out_table = acpi_gbl_root_table_list.tables[i].pointer;
- *tbl_size = acpi_gbl_root_table_list.tables[i].length;
}
if (!acpi_gbl_permanent_mmap) {
@@ -436,16 +434,6 @@ acpi_get_table_with_size(char *signature,
return (AE_NOT_FOUND);
}
-
-acpi_status
-acpi_get_table(char *signature,
- u32 instance, struct acpi_table_header **out_table)
-{
- acpi_size tbl_size;
-
- return acpi_get_table_with_size(signature,
- instance, out_table, &tbl_size);
-}
ACPI_EXPORT_SYMBOL(acpi_get_table)
/*******************************************************************************
diff --git a/include/acpi/acpixf.h b/include/acpi/acpixf.h
index 18f023a..63a4b26 100644
--- a/include/acpi/acpixf.h
+++ b/include/acpi/acpixf.h
@@ -172,10 +172,6 @@ acpi_get_table_header(acpi_string signature,
struct acpi_table_header *out_table_header);
acpi_status
-acpi_get_table_with_size(acpi_string signature,
- u32 instance, struct acpi_table_header **out_table,
- acpi_size *tbl_size);
-acpi_status
acpi_get_table(acpi_string signature,
u32 instance, struct acpi_table_header **out_table);
--
1.7.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table
2012-07-19 7:39 [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
2012-07-19 7:45 ` [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
@ 2012-07-31 3:20 ` Len Brown
2012-07-31 20:56 ` Yinghai Lu
2 siblings, 1 reply; 8+ messages in thread
From: Len Brown @ 2012-07-31 3:20 UTC (permalink / raw)
To: Feng Tang
Cc: Len Brown, linux-kernel, x86, Yinghai Lu, Suresh Siddha,
Donald Dutile, Alexander Gordeev, Bob Moore, Lin Ming
Applied.
thanks,
Len Brown, Intel Open Source Technology Center
ps. next time, please send to linux-acpi@vger.kernel.org list
also, put comments not for the commit log after the "---"
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
2012-07-19 7:47 ` Feng Tang
@ 2012-07-31 3:21 ` Len Brown
1 sibling, 0 replies; 8+ messages in thread
From: Len Brown @ 2012-07-31 3:21 UTC (permalink / raw)
To: Feng Tang
Cc: Len Brown, linux-kernel, x86, Yinghai Lu, Suresh Siddha,
Donald Dutile, Alexander Gordeev, Bob Moore, Lin Ming
Applied
thanks,
Len Brown, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table
2012-07-31 3:20 ` Len Brown
@ 2012-07-31 20:56 ` Yinghai Lu
2012-08-01 2:06 ` Feng Tang
0 siblings, 1 reply; 8+ messages in thread
From: Yinghai Lu @ 2012-07-31 20:56 UTC (permalink / raw)
To: Len Brown
Cc: Feng Tang, Len Brown, linux-kernel, x86, Suresh Siddha,
Donald Dutile, Alexander Gordeev, Bob Moore, Lin Ming
On Mon, Jul 30, 2012 at 8:20 PM, Len Brown <lenb@kernel.org> wrote:
> Applied.
>
> thanks,
> Len Brown, Intel Open Source Technology Center
>
> ps. next time, please send to linux-acpi@vger.kernel.org list
> also, put comments not for the commit log after the "---"
>
other two reference need to be changed:
drivers/iommu/amd_iommu_init.c: status =
acpi_get_table_with_size("IVRS", 0, &ivrs_base, &ivrs_size);
drivers/iommu/amd_iommu_init.c: status =
acpi_get_table_with_size("IVRS", 0, &ivrs_base, &ivrs_size);
Thanks
Yinghai
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table
2012-07-31 20:56 ` Yinghai Lu
@ 2012-08-01 2:06 ` Feng Tang
0 siblings, 0 replies; 8+ messages in thread
From: Feng Tang @ 2012-08-01 2:06 UTC (permalink / raw)
To: Yinghai Lu
Cc: Len Brown, Len Brown, linux-kernel, x86, Suresh Siddha,
Donald Dutile, Alexander Gordeev, Bob Moore, Lin Ming
On Tue, 31 Jul 2012 13:56:58 -0700
Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Jul 30, 2012 at 8:20 PM, Len Brown <lenb@kernel.org> wrote:
> > Applied.
> >
> > thanks,
> > Len Brown, Intel Open Source Technology Center
> >
> > ps. next time, please send to linux-acpi@vger.kernel.org list
> > also, put comments not for the commit log after the "---"
> >
>
> other two reference need to be changed:
>
> drivers/iommu/amd_iommu_init.c: status =
> acpi_get_table_with_size("IVRS", 0, &ivrs_base, &ivrs_size);
> drivers/iommu/amd_iommu_init.c: status =
> acpi_get_table_with_size("IVRS", 0, &ivrs_base, &ivrs_size);
Thanks for the reminder! I will send a follow-on patch
Thanks,
Feng
>
>
> Thanks
>
> Yinghai
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-08-01 2:11 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-07-19 7:39 [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-19 7:39 ` [PATCH 2/2] ACPI: remove acpi_get_table_with_size() fucntion Feng Tang
2012-07-19 7:47 ` Feng Tang
2012-07-31 3:21 ` Len Brown
2012-07-19 7:45 ` [PATCH 1/2] ACPI: replace all acpi_get_table_with_size with acpi_get_table Feng Tang
2012-07-31 3:20 ` Len Brown
2012-07-31 20:56 ` Yinghai Lu
2012-08-01 2:06 ` Feng Tang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).