* [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types
@ 2012-08-14 4:45 gerg
2012-08-14 5:15 ` Fengguang Wu
2012-08-14 7:52 ` Geert Uytterhoeven
0 siblings, 2 replies; 4+ messages in thread
From: gerg @ 2012-08-14 4:45 UTC (permalink / raw)
To: linux-m68k; +Cc: linux-kernel, geert, fengguang.wu, ebiederm, Greg Ungerer
From: Greg Ungerer <gerg@uclinux.org>
There is no specific atomic64 support code for any m68k CPUs, so we should
select CONFIG_GENERIC_ATOMC64 for all. Remove the existing per CPU selection
of this and select it for all m68k.
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
---
arch/m68k/Kconfig | 1 +
arch/m68k/Kconfig.cpu | 4 ----
2 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 0b0f8b8..26bfa46 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -5,6 +5,7 @@ config M68K
select HAVE_AOUT if MMU
select HAVE_GENERIC_HARDIRQS
select GENERIC_IRQ_SHOW
+ select GENERIC_ATOMIC64
select ARCH_HAVE_NMI_SAFE_CMPXCHG if RMW_INSNS
select GENERIC_CPU_DEVICES
select GENERIC_STRNCPY_FROM_USER if MMU
diff --git a/arch/m68k/Kconfig.cpu b/arch/m68k/Kconfig.cpu
index 43a9f8f..765e375 100644
--- a/arch/m68k/Kconfig.cpu
+++ b/arch/m68k/Kconfig.cpu
@@ -56,7 +56,6 @@ config MCPU32
config M68020
bool "68020 support"
depends on MMU
- select GENERIC_ATOMIC64
select CPU_HAS_ADDRESS_SPACES
help
If you anticipate running this kernel on a computer with a MC68020
@@ -67,7 +66,6 @@ config M68020
config M68030
bool "68030 support"
depends on MMU && !MMU_SUN3
- select GENERIC_ATOMIC64
select CPU_HAS_ADDRESS_SPACES
help
If you anticipate running this kernel on a computer with a MC68030
@@ -77,7 +75,6 @@ config M68030
config M68040
bool "68040 support"
depends on MMU && !MMU_SUN3
- select GENERIC_ATOMIC64
select CPU_HAS_ADDRESS_SPACES
help
If you anticipate running this kernel on a computer with a MC68LC040
@@ -88,7 +85,6 @@ config M68040
config M68060
bool "68060 support"
depends on MMU && !MMU_SUN3
- select GENERIC_ATOMIC64
select CPU_HAS_ADDRESS_SPACES
help
If you anticipate running this kernel on a computer with a MC68060
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types
2012-08-14 4:45 [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types gerg
@ 2012-08-14 5:15 ` Fengguang Wu
2012-08-14 13:35 ` Greg Ungerer
2012-08-14 7:52 ` Geert Uytterhoeven
1 sibling, 1 reply; 4+ messages in thread
From: Fengguang Wu @ 2012-08-14 5:15 UTC (permalink / raw)
To: gerg; +Cc: linux-m68k, linux-kernel, geert, ebiederm, Greg Ungerer
On Tue, Aug 14, 2012 at 02:45:33PM +1000, gerg@snapgear.com wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> There is no specific atomic64 support code for any m68k CPUs, so we should
> select CONFIG_GENERIC_ATOMC64 for all. Remove the existing per CPU selection
> of this and select it for all m68k.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Thanks for the complete solution!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types
2012-08-14 5:15 ` Fengguang Wu
@ 2012-08-14 13:35 ` Greg Ungerer
0 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2012-08-14 13:35 UTC (permalink / raw)
To: Fengguang Wu; +Cc: linux-m68k, linux-kernel, geert, ebiederm, Greg Ungerer
On 08/14/2012 03:15 PM, Fengguang Wu wrote:
> On Tue, Aug 14, 2012 at 02:45:33PM +1000, gerg@snapgear.com wrote:
>> From: Greg Ungerer <gerg@uclinux.org>
>>
>> There is no specific atomic64 support code for any m68k CPUs, so we should
>> select CONFIG_GENERIC_ATOMC64 for all. Remove the existing per CPU selection
>> of this and select it for all m68k.
>>
>> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>
> Thanks for the complete solution!
I'll carry it in the m68knommu git tree, and push to Linus with my
next set of fixes.
Regards
Greg
------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close, FAX: +61 7 3891 3630
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types
2012-08-14 4:45 [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types gerg
2012-08-14 5:15 ` Fengguang Wu
@ 2012-08-14 7:52 ` Geert Uytterhoeven
1 sibling, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2012-08-14 7:52 UTC (permalink / raw)
To: gerg; +Cc: linux-m68k, linux-kernel, fengguang.wu, ebiederm, Greg Ungerer
On Tue, Aug 14, 2012 at 6:45 AM, <gerg@snapgear.com> wrote:
> There is no specific atomic64 support code for any m68k CPUs, so we should
> select CONFIG_GENERIC_ATOMC64 for all. Remove the existing per CPU selection
> of this and select it for all m68k.
>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-14 13:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-14 4:45 [PATCH] m68k: select CONFIG_GENERIC_ATOMIC64 for all m68k CPU types gerg
2012-08-14 5:15 ` Fengguang Wu
2012-08-14 13:35 ` Greg Ungerer
2012-08-14 7:52 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).