* [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
@ 2012-08-20 14:04 Richard W.M. Jones
2012-08-20 14:05 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Richard W.M. Jones @ 2012-08-20 14:04 UTC (permalink / raw)
To: linux-kernel; +Cc: pbonzini, linux-scsi
From: "Richard W.M. Jones" <rjones@redhat.com>
The sg struct is used without being initialized.
https://bugzilla.redhat.com/show_bug.cgi?id=847548
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
drivers/scsi/virtio_scsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index c7030fb..8a66f83 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
struct scatterlist sg;
unsigned long flags;
- sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
+ sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
2012-08-20 14:04 [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure Richard W.M. Jones
@ 2012-08-20 14:05 ` Paolo Bonzini
2012-10-01 13:13 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2012-08-20 14:05 UTC (permalink / raw)
To: Richard W.M. Jones; +Cc: linux-kernel, linux-scsi
Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
> From: "Richard W.M. Jones" <rjones@redhat.com>
>
> The sg struct is used without being initialized.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> ---
> drivers/scsi/virtio_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index c7030fb..8a66f83 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
> struct scatterlist sg;
> unsigned long flags;
>
> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>
> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>
>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
2012-08-20 14:05 ` Paolo Bonzini
@ 2012-10-01 13:13 ` Paolo Bonzini
2012-10-01 13:18 ` Richard W.M. Jones
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2012-10-01 13:13 UTC (permalink / raw)
Cc: Richard W.M. Jones, linux-kernel, linux-scsi
Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
> Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
>> From: "Richard W.M. Jones" <rjones@redhat.com>
>>
>> The sg struct is used without being initialized.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>>
>> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
>> ---
>> drivers/scsi/virtio_scsi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
>> index c7030fb..8a66f83 100644
>> --- a/drivers/scsi/virtio_scsi.c
>> +++ b/drivers/scsi/virtio_scsi.c
>> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
>> struct scatterlist sg;
>> unsigned long flags;
>>
>> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>>
>> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>>
>>
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Paolo
>
Ping, is this patch going into 3.7?
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
2012-10-01 13:13 ` Paolo Bonzini
@ 2012-10-01 13:18 ` Richard W.M. Jones
2012-10-01 13:21 ` Paolo Bonzini
0 siblings, 1 reply; 5+ messages in thread
From: Richard W.M. Jones @ 2012-10-01 13:18 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: linux-kernel, linux-scsi
On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote:
> Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
> > Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
> >> From: "Richard W.M. Jones" <rjones@redhat.com>
> >>
> >> The sg struct is used without being initialized.
> >>
> >> https://bugzilla.redhat.com/show_bug.cgi?id=847548
> >>
> >> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> >> ---
> >> drivers/scsi/virtio_scsi.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> >> index c7030fb..8a66f83 100644
> >> --- a/drivers/scsi/virtio_scsi.c
> >> +++ b/drivers/scsi/virtio_scsi.c
> >> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
> >> struct scatterlist sg;
> >> unsigned long flags;
> >>
> >> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> >> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
> >>
> >> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
> >>
> >>
> >
> > Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> >
> > Paolo
> >
>
> Ping, is this patch going into 3.7?
I was a bit surprised to see this wasn't upstream since it's vital for
using virtio-scsi reliably (as well as being a one line fix for a
blatant bug).
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure.
2012-10-01 13:18 ` Richard W.M. Jones
@ 2012-10-01 13:21 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2012-10-01 13:21 UTC (permalink / raw)
To: Richard W.M. Jones; +Cc: linux-kernel, linux-scsi
Il 01/10/2012 15:18, Richard W.M. Jones ha scritto:
> On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote:
>> Il 20/08/2012 16:05, Paolo Bonzini ha scritto:
>>> Il 20/08/2012 16:04, Richard W.M. Jones ha scritto:
>>>> From: "Richard W.M. Jones" <rjones@redhat.com>
>>>>
>>>> The sg struct is used without being initialized.
>>>>
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=847548
>>>>
>>>> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
>>>> ---
>>>> drivers/scsi/virtio_scsi.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
>>>> index c7030fb..8a66f83 100644
>>>> --- a/drivers/scsi/virtio_scsi.c
>>>> +++ b/drivers/scsi/virtio_scsi.c
>>>> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi,
>>>> struct scatterlist sg;
>>>> unsigned long flags;
>>>>
>>>> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>>>> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event));
>>>>
>>>> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags);
>>>>
>>>>
>>>
>>> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Ping, is this patch going into 3.7?
>
> I was a bit surprised to see this wasn't upstream since it's vital for
> using virtio-scsi reliably (as well as being a one line fix for a
> blatant bug).
Indeed I enclosed it in a submission named "[PATCH for 3.6] urgent
virtio-scsi fixes"
(http://permalink.gmane.org/gmane.linux.kernel/1350337)...
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-01 13:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-20 14:04 [PATCH] [SCSI] virtio-scsi: Initialize scatterlist structure Richard W.M. Jones
2012-08-20 14:05 ` Paolo Bonzini
2012-10-01 13:13 ` Paolo Bonzini
2012-10-01 13:18 ` Richard W.M. Jones
2012-10-01 13:21 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).