* [PATCH 1/8] exofs: drop lock/unlock super
@ 2012-08-30 14:56 Marco Stornelli
0 siblings, 0 replies; 8+ messages in thread
From: Marco Stornelli @ 2012-08-30 14:56 UTC (permalink / raw)
To: Linux FS Devel, Al Viro; +Cc: Boaz Harrosh, artem.bityutskiy, linux-kernel
Removed lock/unlock super.
Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Acked-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
fs/exofs/super.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index dde41a7..c4360b5 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -384,8 +384,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
if (unlikely(ret))
goto out;
- lock_super(sb);
-
ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
memset(fscb, 0, ios->length);
fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
@@ -401,8 +399,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
if (unlikely(ret))
EXOFS_ERR("%s: ore_write failed.\n", __func__);
-
- unlock_super(sb);
out:
EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret);
ore_put_io_state(ios);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/8] exofs: drop lock/unlock super
2012-10-09 16:40 ` Al Viro
2012-10-09 17:44 ` Theodore Ts'o
@ 2012-10-10 8:04 ` Marco Stornelli
1 sibling, 0 replies; 8+ messages in thread
From: Marco Stornelli @ 2012-10-10 8:04 UTC (permalink / raw)
To: Al Viro; +Cc: Boaz Harrosh, Benny Halevy, osd-dev, linux-kernel, Linux FS Devel
2012/10/9 Al Viro <viro@zeniv.linux.org.uk>:
> On Tue, Oct 09, 2012 at 05:55:12PM +0200, Marco Stornelli wrote:
>
>> Thanks Al. For me there aren't problems to push it via Al or via
>> other trees. For example the patch for ext4 is in Ted's tree. You
>> tell me what you want and I do it :)
>
> Um... Then I'd better drop the ext4 part and hold the final one back,
> right? Are there other commits I need to skip to avoid duplicates with
> the stuff already in other trees?
No, or at least I know that only Ted (for ext4) has included the patch
in his tree, so no other problem.
Marco
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/8] exofs: drop lock/unlock super
2012-10-09 16:40 ` Al Viro
@ 2012-10-09 17:44 ` Theodore Ts'o
2012-10-10 8:04 ` Marco Stornelli
1 sibling, 0 replies; 8+ messages in thread
From: Theodore Ts'o @ 2012-10-09 17:44 UTC (permalink / raw)
To: Al Viro
Cc: Marco Stornelli, Boaz Harrosh, Benny Halevy, osd-dev,
linux-kernel, Linux FS Devel
Just to confirm, the ext4 lock_super removal is commit 07724f98978a,
and Linus has already pulled it into his tree.
- Ted
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/8] exofs: drop lock/unlock super
2012-10-09 15:55 ` Marco Stornelli
@ 2012-10-09 16:40 ` Al Viro
2012-10-09 17:44 ` Theodore Ts'o
2012-10-10 8:04 ` Marco Stornelli
0 siblings, 2 replies; 8+ messages in thread
From: Al Viro @ 2012-10-09 16:40 UTC (permalink / raw)
To: Marco Stornelli
Cc: Boaz Harrosh, Benny Halevy, osd-dev, linux-kernel, Linux FS Devel
On Tue, Oct 09, 2012 at 05:55:12PM +0200, Marco Stornelli wrote:
> Thanks Al. For me there aren't problems to push it via Al or via
> other trees. For example the patch for ext4 is in Ted's tree. You
> tell me what you want and I do it :)
Um... Then I'd better drop the ext4 part and hold the final one back,
right? Are there other commits I need to skip to avoid duplicates with
the stuff already in other trees?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/8] exofs: drop lock/unlock super
2012-10-08 23:24 ` Al Viro
@ 2012-10-09 15:55 ` Marco Stornelli
2012-10-09 16:40 ` Al Viro
0 siblings, 1 reply; 8+ messages in thread
From: Marco Stornelli @ 2012-10-09 15:55 UTC (permalink / raw)
To: Al Viro; +Cc: Boaz Harrosh, Benny Halevy, osd-dev, linux-kernel, Linux FS Devel
Il 09/10/2012 01:24, Al Viro ha scritto:
> On Mon, Oct 08, 2012 at 02:58:05PM -0700, Boaz Harrosh wrote:
>> Hi Marco
>>
>> I was sure you guys where pushing this patch through some
>> vfs tree. (Hence my Acked-by below). I have just sent Linus
>> a pull request for the 3.7 Kernel. I could perhaps append this
>> one and resend.
>>
>> I do want this patch, and it is completely independent and can
>> go through my tree. Please tell me what do you want to do with
>> this patch, should I push it? Or are you pushing it through Al
>
> This series is slated for tonight push; I'm testing the tree right
> now...
>
Thanks Al. For me there aren't problems to push it via Al or via other
trees. For example the patch for ext4 is in Ted's tree. You tell me what
you want and I do it :)
Marco
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/8] exofs: drop lock/unlock super
2012-10-08 21:58 ` Boaz Harrosh
@ 2012-10-08 23:24 ` Al Viro
2012-10-09 15:55 ` Marco Stornelli
0 siblings, 1 reply; 8+ messages in thread
From: Al Viro @ 2012-10-08 23:24 UTC (permalink / raw)
To: Boaz Harrosh
Cc: Marco Stornelli, Benny Halevy, osd-dev, linux-kernel, Linux FS Devel
On Mon, Oct 08, 2012 at 02:58:05PM -0700, Boaz Harrosh wrote:
> Hi Marco
>
> I was sure you guys where pushing this patch through some
> vfs tree. (Hence my Acked-by below). I have just sent Linus
> a pull request for the 3.7 Kernel. I could perhaps append this
> one and resend.
>
> I do want this patch, and it is completely independent and can
> go through my tree. Please tell me what do you want to do with
> this patch, should I push it? Or are you pushing it through Al
This series is slated for tonight push; I'm testing the tree right
now...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/8] exofs: drop lock/unlock super
2012-10-06 10:38 Marco Stornelli
@ 2012-10-08 21:58 ` Boaz Harrosh
2012-10-08 23:24 ` Al Viro
0 siblings, 1 reply; 8+ messages in thread
From: Boaz Harrosh @ 2012-10-08 21:58 UTC (permalink / raw)
To: Marco Stornelli
Cc: Al Viro, Benny Halevy, osd-dev, linux-kernel, Linux FS Devel
On 10/06/2012 03:38 AM, Marco Stornelli wrote:
> Removed lock/unlock super.
>
Hi Marco
I was sure you guys where pushing this patch through some
vfs tree. (Hence my Acked-by below). I have just sent Linus
a pull request for the 3.7 Kernel. I could perhaps append this
one and resend.
I do want this patch, and it is completely independent and can
go through my tree. Please tell me what do you want to do with
this patch, should I push it? Or are you pushing it through Al
Thanks
Boaz
> Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> Acked-by: Boaz Harrosh <bharrosh@panasas.com>
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
> fs/exofs/super.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/fs/exofs/super.c b/fs/exofs/super.c
> index 59e3bbf..5e59280 100644
> --- a/fs/exofs/super.c
> +++ b/fs/exofs/super.c
> @@ -389,8 +389,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
> if (unlikely(ret))
> goto out;
>
> - lock_super(sb);
> -
> ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
> memset(fscb, 0, ios->length);
> fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
> @@ -406,8 +404,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
> if (unlikely(ret))
> EXOFS_ERR("%s: ore_write failed.\n", __func__);
>
> -
> - unlock_super(sb);
> out:
> EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret);
> ore_put_io_state(ios);
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/8] exofs: drop lock/unlock super
@ 2012-10-06 10:38 Marco Stornelli
2012-10-08 21:58 ` Boaz Harrosh
0 siblings, 1 reply; 8+ messages in thread
From: Marco Stornelli @ 2012-10-06 10:38 UTC (permalink / raw)
To: Al Viro; +Cc: Boaz Harrosh, Benny Halevy, osd-dev, linux-kernel, Linux FS Devel
Removed lock/unlock super.
Acked-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Acked-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
fs/exofs/super.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index 59e3bbf..5e59280 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -389,8 +389,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
if (unlikely(ret))
goto out;
- lock_super(sb);
-
ios->length = offsetof(struct exofs_fscb, s_dev_table_oid);
memset(fscb, 0, ios->length);
fscb->s_nextid = cpu_to_le64(sbi->s_nextid);
@@ -406,8 +404,6 @@ static int exofs_sync_fs(struct super_block *sb, int wait)
if (unlikely(ret))
EXOFS_ERR("%s: ore_write failed.\n", __func__);
-
- unlock_super(sb);
out:
EXOFS_DBGMSG("s_nextid=0x%llx ret=%d\n", _LLU(sbi->s_nextid), ret);
ore_put_io_state(ios);
--
1.7.3.4
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2012-10-10 8:05 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-08-30 14:56 [PATCH 1/8] exofs: drop lock/unlock super Marco Stornelli
2012-10-06 10:38 Marco Stornelli
2012-10-08 21:58 ` Boaz Harrosh
2012-10-08 23:24 ` Al Viro
2012-10-09 15:55 ` Marco Stornelli
2012-10-09 16:40 ` Al Viro
2012-10-09 17:44 ` Theodore Ts'o
2012-10-10 8:04 ` Marco Stornelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).