* [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support'.
@ 2012-09-03 8:27 Javier Martin
2012-09-03 16:16 ` Fabio Estevam
2012-09-04 6:35 ` Gaëtan Carlier
0 siblings, 2 replies; 5+ messages in thread
From: Javier Martin @ 2012-09-03 8:27 UTC (permalink / raw)
To: linux-kernel
Cc: alsa-devel, broonie, gcembed, fabio.estevam, s.hauer, Javier Martin
The following commit should be reverted: 0865a75d4166bddc533fd50831829ceefb94f9b0
The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
Furthermore, after applying this patch sound in Visstrim_M10 is played
at slower rates.
Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
---
diff --git b/sound/soc/fsl/imx-ssi.c a/sound/soc/fsl/imx-ssi.c
index ac337ac..28dd76c 100644
--- b/sound/soc/fsl/imx-ssi.c
+++ a/sound/soc/fsl/imx-ssi.c
@@ -380,13 +380,13 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
static struct snd_soc_dai_driver imx_ssi_dai = {
.probe = imx_ssi_dai_probe,
.playback = {
- .channels_min = 2,
+ .channels_min = 1,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
- .channels_min = 2,
+ .channels_min = 1,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support'.
2012-09-03 8:27 [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support' Javier Martin
@ 2012-09-03 16:16 ` Fabio Estevam
2012-09-04 6:35 ` Gaëtan Carlier
1 sibling, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2012-09-03 16:16 UTC (permalink / raw)
To: Javier Martin
Cc: linux-kernel, alsa-devel, festevam, broonie, gcembed, s.hauer
Hi Javier,
Javier Martin wrote:
> The following commit should be reverted: 0865a75d4166bddc533fd50831829ceefb94f9b0
>
> The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
> Furthermore, after applying this patch sound in Visstrim_M10 is played
> at slower rates.
Acked-by: Fabio Estevam <fabio.estevam@freescale.com>
Sorry for breaking this.
Ok, I managed to fix the original issue inside the mc13783 codec driver and just sent a patch.
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support'.
2012-09-03 8:27 [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support' Javier Martin
2012-09-03 16:16 ` Fabio Estevam
@ 2012-09-04 6:35 ` Gaëtan Carlier
2012-09-04 9:09 ` javier Martin
1 sibling, 1 reply; 5+ messages in thread
From: Gaëtan Carlier @ 2012-09-04 6:35 UTC (permalink / raw)
To: Javier Martin; +Cc: linux-kernel, alsa-devel, broonie, fabio.estevam, s.hauer
Hi Javier,
On 09/03/2012 10:27 AM, Javier Martin wrote:
> The following commit should be reverted: 0865a75d4166bddc533fd50831829ceefb94f9b0
>
> The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
> Furthermore, after applying this patch sound in Visstrim_M10 is played
> at slower rates.
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
> ---
> diff --git b/sound/soc/fsl/imx-ssi.c a/sound/soc/fsl/imx-ssi.c
> index ac337ac..28dd76c 100644
> --- b/sound/soc/fsl/imx-ssi.c
> +++ a/sound/soc/fsl/imx-ssi.c
> @@ -380,13 +380,13 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
> static struct snd_soc_dai_driver imx_ssi_dai = {
> .probe = imx_ssi_dai_probe,
> .playback = {
> - .channels_min = 2,
> + .channels_min = 1,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
> },
> .capture = {
> - .channels_min = 2,
> + .channels_min = 1,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
>
When applied on linux-next-20120824, the patch failed because original
imx-ssi.c file looks like :
static struct snd_soc_dai_driver imx_ssi_dai = {
.probe = imx_ssi_dai_probe,
.playback = {
/* The SSI does not support monaural audio. */
.channels_min = 2,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
.channels_min = 2,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.ops = &imx_ssi_pcm_dai_ops,
};
The comment line is missing in your patch. Here is the right patch :
@@ -378,18 +378,17 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
}
static struct snd_soc_dai_driver imx_ssi_dai = {
.probe = imx_ssi_dai_probe,
.playback = {
- /* The SSI does not support monaural audio. */
- .channels_min = 2,
+ .channels_min = 1,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.capture = {
- .channels_min = 2,
+ .channels_min = 1,
.channels_max = 2,
.rates = SNDRV_PCM_RATE_8000_96000,
.formats = SNDRV_PCM_FMTBIT_S16_LE,
},
.ops = &imx_ssi_pcm_dai_ops,
Regards,
Gaëtan Carlier.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support'.
2012-09-04 6:35 ` Gaëtan Carlier
@ 2012-09-04 9:09 ` javier Martin
2012-09-06 0:19 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: javier Martin @ 2012-09-04 9:09 UTC (permalink / raw)
To: Gaëtan Carlier
Cc: linux-kernel, alsa-devel, broonie, fabio.estevam, s.hauer
On 4 September 2012 08:35, Gaëtan Carlier <gcembed@gmail.com> wrote:
> Hi Javier,
>
> On 09/03/2012 10:27 AM, Javier Martin wrote:
>>
>> The following commit should be reverted:
>> 0865a75d4166bddc533fd50831829ceefb94f9b0
>>
>> The bug this patch is meant to solve doesn't occur in Visstrim_M10 boards.
>> Furthermore, after applying this patch sound in Visstrim_M10 is played
>> at slower rates.
>>
>> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
>> ---
>> diff --git b/sound/soc/fsl/imx-ssi.c a/sound/soc/fsl/imx-ssi.c
>> index ac337ac..28dd76c 100644
>> --- b/sound/soc/fsl/imx-ssi.c
>> +++ a/sound/soc/fsl/imx-ssi.c
>> @@ -380,13 +380,13 @@ static int imx_ssi_dai_probe(struct snd_soc_dai
>> *dai)
>> static struct snd_soc_dai_driver imx_ssi_dai = {
>> .probe = imx_ssi_dai_probe,
>> .playback = {
>> - .channels_min = 2,
>> + .channels_min = 1,
>> .channels_max = 2,
>> .rates = SNDRV_PCM_RATE_8000_96000,
>> .formats = SNDRV_PCM_FMTBIT_S16_LE,
>> },
>> .capture = {
>> - .channels_min = 2,
>> + .channels_min = 1,
>> .channels_max = 2,
>> .rates = SNDRV_PCM_RATE_8000_96000,
>> .formats = SNDRV_PCM_FMTBIT_S16_LE,
>>
> When applied on linux-next-20120824, the patch failed because original
> imx-ssi.c file looks like :
>
> static struct snd_soc_dai_driver imx_ssi_dai = {
> .probe = imx_ssi_dai_probe,
> .playback = {
> /* The SSI does not support monaural audio. */
>
> .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
> },
> .capture = {
> .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
> },
> .ops = &imx_ssi_pcm_dai_ops,
> };
>
> The comment line is missing in your patch. Here is the right patch :
>
> @@ -378,18 +378,17 @@ static int imx_ssi_dai_probe(struct snd_soc_dai *dai)
>
> }
>
> static struct snd_soc_dai_driver imx_ssi_dai = {
> .probe = imx_ssi_dai_probe,
> .playback = {
> - /* The SSI does not support monaural audio. */
>
> - .channels_min = 2,
> + .channels_min = 1,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
> },
> .capture = {
> - .channels_min = 2,
> + .channels_min = 1,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = SNDRV_PCM_FMTBIT_S16_LE,
> },
> .ops = &imx_ssi_pcm_dai_ops,
>
> Regards,
> Gaëtan Carlier.
Mark,
could you pick up the fixed patch sent by Gaëtan?
Regards.
--
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support'.
2012-09-04 9:09 ` javier Martin
@ 2012-09-06 0:19 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-09-06 0:19 UTC (permalink / raw)
To: javier Martin
Cc: Gaëtan Carlier, linux-kernel, alsa-devel, fabio.estevam, s.hauer
On Tue, Sep 04, 2012 at 11:09:20AM +0200, javier Martin wrote:
> could you pick up the fixed patch sent by Gaëtan?
It's mangled, can someone resend please (ideally with an appropriate
subject line and so on).
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-06 0:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-03 8:27 [ASoC] Fix: Revert 'ASoC: imx-ssi: Remove mono support' Javier Martin
2012-09-03 16:16 ` Fabio Estevam
2012-09-04 6:35 ` Gaëtan Carlier
2012-09-04 9:09 ` javier Martin
2012-09-06 0:19 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).