From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Kevin Daughtridge <kevin@kdau.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usbhid: call report_fixup before comparing descriptors
Date: Tue, 18 Sep 2012 16:00:16 +0400 [thread overview]
Message-ID: <50586250.4060208@mvista.com> (raw)
In-Reply-To: <50578272.1020902@kdau.com>
Hello.
On 18-09-2012 0:05, Kevin Daughtridge wrote:
> hid_post_reset checks the stored report descriptor against what is currently
> returned by the device. An HID driver's report_fixup method may have changed the
> stored descriptor, however, creating false positives. These leave some devices
> nonfunctional after a resume, with a "reset_resume error 1" reported. This patch
> passes the new descriptor to the driver's report_fixup method, if any, before it
> is compared to the stored one.
> BugLink: http://bugs.launchpad.net/bugs/1049623
> Signed-off-by: Kevin Daughtridge <kevin@kdau.com>
> ---
> --- a/drivers/hid/usbhid/hid-core.c 2012-08-20 10:17:09.000000000 -0700
> +++ b/drivers/hid/usbhid/hid-core.c 2012-09-16 18:51:45.381868737 -0700
> @@ -1436,6 +1436,10 @@ static int hid_post_reset(struct usb_int
> kfree(rdesc);
> return 1;
> }
> +
> + if (hid->driver && hid->driver->report_fixup)
> + rdesc = hid->driver->report_fixup(hid, rdesc, &status);
> +
Your patch is whitespace damaged, i.e. has all tabs replaced by spaces.
WBR, Sergei
next prev parent reply other threads:[~2012-09-18 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 20:05 [PATCH] usbhid: call report_fixup before comparing descriptors Kevin Daughtridge
2012-09-18 12:00 ` Sergei Shtylyov [this message]
2012-09-18 16:16 ` Henrik Rydberg
2012-09-19 2:21 ` Kevin Daughtridge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50586250.4060208@mvista.com \
--to=sshtylyov@mvista.com \
--cc=jkosina@suse.cz \
--cc=kevin@kdau.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).