From: Saravana Kannan <skannan@codeaurora.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/10] ARM: msm: Remove custom clk_set_flags() API
Date: Mon, 24 Sep 2012 15:33:45 -0700 [thread overview]
Message-ID: <5060DFC9.1000207@codeaurora.org> (raw)
In-Reply-To: <1348194419-11486-6-git-send-email-sboyd@codeaurora.org>
On 09/20/2012 07:26 PM, Stephen Boyd wrote:
> Nobody is using this API upstream and it's just contributing
> cruft. Remove it so the MSM clock API is closer to the generic
> struct clock API.
>
> Cc: Saravana Kannan<skannan@codeaurora.org>
> Signed-off-by: Stephen Boyd<sboyd@codeaurora.org>
> ---
> arch/arm/mach-msm/clock-pcom.c | 10 ----------
> arch/arm/mach-msm/clock.c | 8 --------
> arch/arm/mach-msm/clock.h | 6 ------
> arch/arm/mach-msm/include/mach/clk.h | 3 ---
> 4 files changed, 27 deletions(-)
>
> diff --git a/arch/arm/mach-msm/clock-pcom.c b/arch/arm/mach-msm/clock-pcom.c
> index a52c970..bb75f8e 100644
> --- a/arch/arm/mach-msm/clock-pcom.c
> +++ b/arch/arm/mach-msm/clock-pcom.c
> @@ -85,15 +85,6 @@ static int pc_clk_set_max_rate(unsigned id, unsigned rate)
> return (int)id< 0 ? -EINVAL : 0;
> }
>
> -static int pc_clk_set_flags(unsigned id, unsigned flags)
> -{
> - int rc = msm_proc_comm(PCOM_CLKCTL_RPC_SET_FLAGS,&id,&flags);
> - if (rc< 0)
> - return rc;
> - else
> - return (int)id< 0 ? -EINVAL : 0;
> -}
> -
> static unsigned pc_clk_get_rate(unsigned id)
> {
> if (msm_proc_comm(PCOM_CLKCTL_RPC_RATE,&id, NULL))
> @@ -130,7 +121,6 @@ struct clk_ops clk_ops_pcom = {
> .set_rate = pc_clk_set_rate,
> .set_min_rate = pc_clk_set_min_rate,
> .set_max_rate = pc_clk_set_max_rate,
> - .set_flags = pc_clk_set_flags,
> .get_rate = pc_clk_get_rate,
> .is_enabled = pc_clk_is_enabled,
> .round_rate = pc_clk_round_rate,
> diff --git a/arch/arm/mach-msm/clock.c b/arch/arm/mach-msm/clock.c
> index d9145df..5fac2df 100644
> --- a/arch/arm/mach-msm/clock.c
> +++ b/arch/arm/mach-msm/clock.c
> @@ -121,14 +121,6 @@ struct clk *clk_get_parent(struct clk *clk)
> }
> EXPORT_SYMBOL(clk_get_parent);
>
> -int clk_set_flags(struct clk *clk, unsigned long flags)
> -{
> - if (clk == NULL || IS_ERR(clk))
> - return -EINVAL;
> - return clk->ops->set_flags(clk->id, flags);
> -}
> -EXPORT_SYMBOL(clk_set_flags);
> -
> /* EBI1 is the only shared clock that several clients want to vote on as of
> * this commit. If this changes in the future, then it might be better to
> * make clk_min_rate handle the voting or make ebi1_clk_set_min_rate more
> diff --git a/arch/arm/mach-msm/clock.h b/arch/arm/mach-msm/clock.h
> index 2c007f6..a25ff58 100644
> --- a/arch/arm/mach-msm/clock.h
> +++ b/arch/arm/mach-msm/clock.h
> @@ -21,11 +21,6 @@
> #include<linux/list.h>
> #include<mach/clk.h>
>
> -#define CLKFLAG_INVERT 0x00000001
> -#define CLKFLAG_NOINVERT 0x00000002
> -#define CLKFLAG_NONEST 0x00000004
> -#define CLKFLAG_NORESET 0x00000008
> -
> #define CLK_FIRST_AVAILABLE_FLAG 0x00000100
> #define CLKFLAG_AUTO_OFF 0x00000200
> #define CLKFLAG_MIN 0x00000400
> @@ -39,7 +34,6 @@ struct clk_ops {
> int (*set_rate)(unsigned id, unsigned rate);
> int (*set_min_rate)(unsigned id, unsigned rate);
> int (*set_max_rate)(unsigned id, unsigned rate);
> - int (*set_flags)(unsigned id, unsigned flags);
> unsigned (*get_rate)(unsigned id);
> unsigned (*is_enabled)(unsigned id);
> long (*round_rate)(unsigned id, unsigned rate);
> diff --git a/arch/arm/mach-msm/include/mach/clk.h b/arch/arm/mach-msm/include/mach/clk.h
> index e8d3842..5f1c37d 100644
> --- a/arch/arm/mach-msm/include/mach/clk.h
> +++ b/arch/arm/mach-msm/include/mach/clk.h
> @@ -34,7 +34,4 @@ int clk_set_max_rate(struct clk *clk, unsigned long rate);
> /* Assert/Deassert reset to a hardware block associated with a clock */
> int clk_reset(struct clk *clk, enum clk_reset_action action);
>
> -/* Set clock-specific configuration parameters */
> -int clk_set_flags(struct clk *clk, unsigned long flags);
> -
> #endif
Acked-by: Saravana Kannan <skannan@codeaurora.org>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-09-24 22:33 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 2:26 [PATCH 00/10] Convert MSM to common clock framework Stephen Boyd
2012-09-21 2:26 ` [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare Stephen Boyd
2012-09-26 16:58 ` Pankaj Jangra
2012-09-26 18:48 ` Stephen Boyd
2012-09-26 18:52 ` Pankaj Jangra
2012-09-21 2:26 ` [PATCH 02/10] msm_sdcc: " Stephen Boyd
2012-09-21 2:26 ` [PATCH 03/10] msm: iommu: " Stephen Boyd
2012-09-24 22:32 ` Saravana Kannan
2012-09-25 20:16 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 04/10] msm: iommu: Use clk_set_rate() instead of clk_set_min_rate() Stephen Boyd
2012-09-21 2:26 ` [PATCH 05/10] ARM: msm: Remove custom clk_set_flags() API Stephen Boyd
2012-09-24 22:33 ` Saravana Kannan [this message]
2012-09-21 2:26 ` [PATCH 06/10] ARM: msm: Remove custom clk_set_{max,min}_rate() API Stephen Boyd
2012-09-24 22:37 ` Saravana Kannan
2012-09-21 2:26 ` [PATCH 07/10] ARM: msm: Remove clock-7x30.h include file Stephen Boyd
2012-09-26 17:51 ` Pankaj Jangra
2012-09-26 18:18 ` Stephen Boyd
2012-09-26 18:54 ` Pankaj Jangra
2012-09-21 2:26 ` [PATCH 08/10] ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver Stephen Boyd
2012-09-26 17:35 ` Pankaj Jangra
2012-09-26 18:14 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 09/10] ARM: msm: Make proc_comm clock control into a platform driver Stephen Boyd
2012-09-26 18:03 ` Pankaj Jangra
2012-09-26 18:36 ` Stephen Boyd
2012-09-21 2:26 ` [PATCH 10/10] ARM: msm: Migrate to common clock framework Stephen Boyd
2012-09-26 18:47 ` Pankaj Jangra
2012-09-26 18:50 ` Stephen Boyd
2012-09-26 18:57 ` Pankaj Jangra
2012-09-22 1:10 ` [PATCH 00/10] Convert MSM " Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5060DFC9.1000207@codeaurora.org \
--to=skannan@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).