linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Pankaj Jangra <jangra.pankaj9@gmail.com>
Cc: David Brown <davidb@codeaurora.org>,
	Daniel Walker <dwalker@fifo99.com>,
	Bryan Huntsman <bryanh@codeaurora.org>,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
	Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare
Date: Wed, 26 Sep 2012 11:48:25 -0700	[thread overview]
Message-ID: <50634DF9.5010608@codeaurora.org> (raw)
In-Reply-To: <CADTbHxoFeYWPJpYTN85kBeF=kv2v1yDioJW-upzn1RcwVT_sKw@mail.gmail.com>

On 09/26/12 09:58, Pankaj Jangra wrote:
> On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
>> index 9f5fc90..2ae0639 100644
>> --- a/drivers/usb/otg/msm_otg.c
>> +++ b/drivers/usb/otg/msm_otg.c
>> @@ -514,13 +514,13 @@ static int msm_otg_suspend(struct msm_otg *motg)
>>                         motg->pdata->otg_control == OTG_PMIC_CONTROL)
>>                 writel(readl(USB_PHY_CTRL) | PHY_RETEN, USB_PHY_CTRL);
>>
>> -       clk_disable(motg->pclk);
>> -       clk_disable(motg->clk);
>> +       clk_disable_unprepare(motg->pclk);
>> +       clk_disable_unprepare(motg->clk);
>>         if (motg->core_clk)
>> -               clk_disable(motg->core_clk);
>> +               clk_disable_unprepare(motg->core_clk);
>>
> I was under assumption that system suspend/resume might be called from
> the interrupt context. If that is case then its not appropriate to
> call clk_prepare/unprepare here right? or my understanding is not correct????

Well we call disable_irq() at the top of this suspend function so I
suspect your understanding is incorrect. disable_irq() can call
schedule(). There are also a bunch of regulator calls in
msm_hsusb_ldo_set_mode() that this suspend function calls (almost all
regulator calls grab a mutex).

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation


  reply	other threads:[~2012-09-26 18:48 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-21  2:26 [PATCH 00/10] Convert MSM to common clock framework Stephen Boyd
2012-09-21  2:26 ` [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare Stephen Boyd
2012-09-26 16:58   ` Pankaj Jangra
2012-09-26 18:48     ` Stephen Boyd [this message]
2012-09-26 18:52       ` Pankaj Jangra
2012-09-21  2:26 ` [PATCH 02/10] msm_sdcc: " Stephen Boyd
2012-09-21  2:26 ` [PATCH 03/10] msm: iommu: " Stephen Boyd
2012-09-24 22:32   ` Saravana Kannan
2012-09-25 20:16     ` Stephen Boyd
2012-09-21  2:26 ` [PATCH 04/10] msm: iommu: Use clk_set_rate() instead of clk_set_min_rate() Stephen Boyd
2012-09-21  2:26 ` [PATCH 05/10] ARM: msm: Remove custom clk_set_flags() API Stephen Boyd
2012-09-24 22:33   ` Saravana Kannan
2012-09-21  2:26 ` [PATCH 06/10] ARM: msm: Remove custom clk_set_{max,min}_rate() API Stephen Boyd
2012-09-24 22:37   ` Saravana Kannan
2012-09-21  2:26 ` [PATCH 07/10] ARM: msm: Remove clock-7x30.h include file Stephen Boyd
2012-09-26 17:51   ` Pankaj Jangra
2012-09-26 18:18     ` Stephen Boyd
2012-09-26 18:54       ` Pankaj Jangra
2012-09-21  2:26 ` [PATCH 08/10] ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver Stephen Boyd
2012-09-26 17:35   ` Pankaj Jangra
2012-09-26 18:14     ` Stephen Boyd
2012-09-21  2:26 ` [PATCH 09/10] ARM: msm: Make proc_comm clock control into a platform driver Stephen Boyd
2012-09-26 18:03   ` Pankaj Jangra
2012-09-26 18:36     ` Stephen Boyd
2012-09-21  2:26 ` [PATCH 10/10] ARM: msm: Migrate to common clock framework Stephen Boyd
2012-09-26 18:47   ` Pankaj Jangra
2012-09-26 18:50     ` Stephen Boyd
2012-09-26 18:57       ` Pankaj Jangra
2012-09-22  1:10 ` [PATCH 00/10] Convert MSM " Mike Turquette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50634DF9.5010608@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=balbi@ti.com \
    --cc=bryanh@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=dwalker@fifo99.com \
    --cc=jangra.pankaj9@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).