From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Matthieu CASTET <castet.matthieu@free.fr>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH v2] hvc_dcc : add support to armv4 and armv5 core
Date: Tue, 25 Sep 2012 17:35:54 +0200 [thread overview]
Message-ID: <5061CF5A.2030201@parrot.com> (raw)
In-Reply-To: <201209031257.28213.arnd@arndb.de>
Arnd Bergmann a écrit :
> On Friday 31 August 2012, Stephen Boyd wrote:
>>> +static int hvc_dcc_put_chars_v6(uint32_t vt, const char *buf, int count)
>>> +{
>>> + int i;
>>> +
>>> + for (i = 0; i < count; i++) {
>>> + while (__dcc_getstatus_v6() & DCC_STATUS_TX_V6)
>>> + cpu_relax();
>>> +
>>> + __dcc_putchar_v6(buf[i]);
>>> + }
>>> +
>>> + return count;
>>> +}
>> It's unfortunate that the main logic is duplicated. I wonder if we could
>> push the runtime decision slightly lower into the accessor functions
>> instead and make some new functions dcc_tx_busy() and dcc_rx_busy() or
>> something. Then these loops stay the same.
The code is so small (30 asm + 30 C code) that I wonder if worth adding
complexity in the code.
Also calling cpu_architecture isn't free and if the want to put the runtime
decision into the hot path, this means we need to cache the result.
>
> Agreed. Ideally, you should be able to get the code to be compiled into
> the same binary as before for ARMv6+. If only the inline assembly differs,
> you can do something like
>
> static inline char __dcc_getchar(void)
> {
> char __c;
>
> if (__LINUX_ARM_ARCH >= 6)
> asm volatile("mrc p14, 0, %0, c0, c5, 0 @ read comms data reg"
> : "=r" (__c));
> else
> asm volatile ("mrc p14, 0, %0, c1, c0 @ read comms data reg"
> : "=r" (ret));
> isb();
>
> return __c;
> }
>
> Arnd
>
Yes doing that will be great!
But Alan wanted "all be runtime handled".
May be we can do something like:
static int cpu_arch;
static inline char __dcc_getchar(void)
{
char __c;
if (cpu_arch >= 6)
asm volatile("mrc p14, 0, %0, c0, c5, 0 @ read comms data reg"
: "=r" (__c));
else
asm volatile ("mrc p14, 0, %0, c1, c0 @ read comms data reg"
: "=r" (ret));
isb();
return __c;
}
static int __init hvc_dcc_console_init(void)
{
cpu_arch = cpu_architecture();
...
}
Matthieu
next prev parent reply other threads:[~2012-09-25 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 11:47 [PATCH v2] hvc_dcc : add support to armv4 and armv5 core Matthieu CASTET
2012-08-31 16:48 ` Stephen Boyd
2012-09-03 12:57 ` Arnd Bergmann
2012-09-25 15:35 ` Matthieu CASTET [this message]
2012-09-25 15:44 ` Arnd Bergmann
2012-09-25 17:37 ` matthieu castet
2012-09-25 15:40 ` Matthieu CASTET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5061CF5A.2030201@parrot.com \
--to=matthieu.castet@parrot.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=castet.matthieu@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).