From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Ansuel Smith <ansuelsmth@gmail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Sricharan R <sricharan@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] clk: qcom: clk-hfpll: use poll_timeout macro
Date: Fri, 29 Apr 2022 17:42:22 +0300 [thread overview]
Message-ID: <506f1669-b3a0-1543-9d9c-2a0931a2e3f2@linaro.org> (raw)
In-Reply-To: <20220429120108.9396-2-ansuelsmth@gmail.com>
On 29/04/2022 15:01, Ansuel Smith wrote:
> Use regmap_read_poll_timeout macro instead of do-while structure to tidy
> things up. Also set a timeout to prevent any sort of system stall.
>
> Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/clk/qcom/clk-hfpll.c | 15 +++++++++------
> 1 file changed, 9 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-hfpll.c b/drivers/clk/qcom/clk-hfpll.c
> index e847d586a73a..7dd17c184b69 100644
> --- a/drivers/clk/qcom/clk-hfpll.c
> +++ b/drivers/clk/qcom/clk-hfpll.c
> @@ -72,13 +72,16 @@ static void __clk_hfpll_enable(struct clk_hw *hw)
> regmap_update_bits(regmap, hd->mode_reg, PLL_RESET_N, PLL_RESET_N);
>
> /* Wait for PLL to lock. */
> - if (hd->status_reg) {
> - do {
> - regmap_read(regmap, hd->status_reg, &val);
> - } while (!(val & BIT(hd->lock_bit)));
> - } else {
> + if (hd->status_reg)
> + /*
> + * Busy wait. Should never timeout, we add a timeout to
> + * prevent any sort of stall.
> + */
> + regmap_read_poll_timeout(regmap, hd->status_reg, val,
> + !(val & BIT(hd->lock_bit)), 0,
> + 100 * USEC_PER_MSEC);
> + else
> udelay(60);
> - }
>
> /* Enable PLL output. */
> regmap_update_bits(regmap, hd->mode_reg, PLL_OUTCTRL, PLL_OUTCTRL);
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-04-29 14:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 12:01 [PATCH 0/4] Small fixes/improvement for hfpll and krait Ansuel Smith
2022-04-29 12:01 ` [PATCH 1/4] clk: qcom: clk-hfpll: use poll_timeout macro Ansuel Smith
2022-04-29 14:42 ` Dmitry Baryshkov [this message]
2022-04-29 12:01 ` [PATCH 2/4] clk: qcom: clk-krait: unlock spin after mux completion Ansuel Smith
2022-04-29 14:41 ` Dmitry Baryshkov
2022-04-29 12:01 ` [PATCH 3/4] clk: qcom: clk-krait: add hw_parent check for div2_round_rate Ansuel Smith
2022-04-29 14:53 ` Dmitry Baryshkov
2022-04-29 15:06 ` Ansuel Smith
2022-04-29 15:22 ` Dmitry Baryshkov
2022-04-29 12:01 ` [PATCH 4/4] clk: qcom: clk-krait: add apq/ipq8064 errata workaround Ansuel Smith
2022-04-29 15:00 ` Dmitry Baryshkov
2022-04-29 15:09 ` Ansuel Smith
2022-04-29 15:13 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=506f1669-b3a0-1543-9d9c-2a0931a2e3f2@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).