linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.cz>,
	linux-mm@kvack.org,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add some drop_caches documentation and info messsge
Date: Wed, 24 Oct 2012 13:28:19 -0700	[thread overview]
Message-ID: <50884F63.8030606@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121024125439.c17a510e.akpm@linux-foundation.org>

On 10/24/2012 12:54 PM, Andrew Morton wrote:
> hmpf.  This patch worries me.  If there are people out there who are
> regularly using drop_caches because the VM sucks, it seems pretty
> obnoxious of us to go dumping stuff into their syslog.  What are they
> supposed to do?  Stop using drop_caches?

People use drop_caches because they _think_ the VM sucks, or they
_think_ they're "tuning" their system.  _They_ are supposed to stop
using drop_caches. :)

What kind of interface _is_ it in the first place?  Is it really a
production-level thing that we expect users to be poking at?  Or, is it
a rarely-used debugging and benchmarking knob which is fair game for us
to tweak like this?

Do we have any valid uses of drop_caches where the printk() would truly
_be_ disruptive?  Are those cases where we _also_ have real kernel bugs
or issues that we should be working?  If it disrupts them and they go to
their vendor or the community directly, it gives us at least a shot at
fixing the real problems (or fixing the "invalid" use).

Adding taint, making this a single-shot printk, or adding vmstat
counters are all good ideas.  I guess I think the disruption is a
feature because I hope it will draw some folks out of the woodwork.


  reply	other threads:[~2012-10-24 20:28 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-12 12:57 [PATCH] add some drop_caches documentation and info messsge Michal Hocko
2012-10-12 18:54 ` KOSAKI Motohiro
2012-10-15  9:04 ` Kamezawa Hiroyuki
2012-10-15 14:05 ` Dave Hansen
2012-10-23 23:45 ` Andrew Morton
2012-10-24  6:29   ` Michal Hocko
2012-10-24 19:54     ` Andrew Morton
2012-10-24 20:28       ` Dave Hansen [this message]
2012-10-24 20:48         ` Andrew Morton
2012-10-24 21:06           ` Borislav Petkov
2012-10-24 21:13             ` Andrew Morton
2012-10-24 22:04               ` Rafael J. Wysocki
2012-10-25  1:17                 ` Andrew Morton
2012-10-25 20:16                   ` Rafael J. Wysocki
2012-10-29  8:59                   ` Jiri Kosina
2012-10-29  9:58                     ` Borislav Petkov
2012-10-29 10:01                       ` Jiri Kosina
2012-10-29 10:11                         ` Borislav Petkov
2012-10-31 17:31                       ` Pavel Machek
2012-10-31 17:46                         ` Borislav Petkov
2012-10-24 22:35               ` KOSAKI Motohiro
2012-10-25 14:21                 ` Michal Hocko
2012-10-24 21:18             ` Dave Hansen
2012-10-24 22:48               ` Borislav Petkov
2012-10-24 22:57                 ` Dave Hansen
2012-10-25  0:56                   ` KOSAKI Motohiro
2012-10-25  9:24                     ` Borislav Petkov
2012-10-25 11:57                       ` Dave Hansen
2012-10-25 14:24                         ` Borislav Petkov
2012-10-25 14:25                         ` Michal Hocko
2012-10-26  7:45           ` Mika Boström
2012-11-01 20:26           ` Pavel Machek
2012-10-25 14:09       ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50884F63.8030606@linux.vnet.ibm.com \
    --to=dave@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).