From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Borislav Petkov <bp@alien8.de>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add some drop_caches documentation and info messsge
Date: Wed, 24 Oct 2012 15:57:31 -0700 [thread overview]
Message-ID: <5088725B.2090700@linux.vnet.ibm.com> (raw)
In-Reply-To: <20121024224817.GB8828@liondog.tnic>
On 10/24/2012 03:48 PM, Borislav Petkov wrote:
> On Wed, Oct 24, 2012 at 02:18:38PM -0700, Dave Hansen wrote:
>> Sounds fairly valid to me. But, it's also one that would not be harmed
>> or disrupted in any way because of a single additional printk() during
>> each suspend-to-disk operation.
>
> back to the drop_caches patch. How about we hide the drop_caches
> interface behind some mm debugging option in "Kernel Hacking"? Assuming
> we don't need it otherwise on production kernels. Probably make it
> depend on CONFIG_DEBUG_VM like CONFIG_DEBUG_VM_RB or so.
>
> And then also add it to /proc/vmstat, in addition.
That effectively means removing it from the kernel since distros ship
with those config options off. We don't want to do that since there
_are_ valid, occasional uses like benchmarking that we want to be
consistent.
next prev parent reply other threads:[~2012-10-24 22:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 12:57 [PATCH] add some drop_caches documentation and info messsge Michal Hocko
2012-10-12 18:54 ` KOSAKI Motohiro
2012-10-15 9:04 ` Kamezawa Hiroyuki
2012-10-15 14:05 ` Dave Hansen
2012-10-23 23:45 ` Andrew Morton
2012-10-24 6:29 ` Michal Hocko
2012-10-24 19:54 ` Andrew Morton
2012-10-24 20:28 ` Dave Hansen
2012-10-24 20:48 ` Andrew Morton
2012-10-24 21:06 ` Borislav Petkov
2012-10-24 21:13 ` Andrew Morton
2012-10-24 22:04 ` Rafael J. Wysocki
2012-10-25 1:17 ` Andrew Morton
2012-10-25 20:16 ` Rafael J. Wysocki
2012-10-29 8:59 ` Jiri Kosina
2012-10-29 9:58 ` Borislav Petkov
2012-10-29 10:01 ` Jiri Kosina
2012-10-29 10:11 ` Borislav Petkov
2012-10-31 17:31 ` Pavel Machek
2012-10-31 17:46 ` Borislav Petkov
2012-10-24 22:35 ` KOSAKI Motohiro
2012-10-25 14:21 ` Michal Hocko
2012-10-24 21:18 ` Dave Hansen
2012-10-24 22:48 ` Borislav Petkov
2012-10-24 22:57 ` Dave Hansen [this message]
2012-10-25 0:56 ` KOSAKI Motohiro
2012-10-25 9:24 ` Borislav Petkov
2012-10-25 11:57 ` Dave Hansen
2012-10-25 14:24 ` Borislav Petkov
2012-10-25 14:25 ` Michal Hocko
2012-10-26 7:45 ` Mika Boström
2012-11-01 20:26 ` Pavel Machek
2012-10-25 14:09 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5088725B.2090700@linux.vnet.ibm.com \
--to=dave@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).