* [PATCH] Input: focaltech - mark focaltech_set_resolution() static
@ 2016-08-31 8:37 Baoyou Xie
2016-08-31 9:58 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Baoyou Xie @ 2016-08-31 8:37 UTC (permalink / raw)
To: dmitry.torokhov
Cc: pali.rohar, hdegoede, linux-input, linux-kernel, arnd,
baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
So this patch marks it 'static'.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/input/mouse/focaltech.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c
index c8c6a8c..d3ca02a 100644
--- a/drivers/input/mouse/focaltech.c
+++ b/drivers/input/mouse/focaltech.c
@@ -390,7 +390,8 @@ static int focaltech_read_size(struct psmouse *psmouse)
return 0;
}
-void focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution)
+static void
+focaltech_set_resolution(struct psmouse *psmouse, unsigned int resolution)
{
/* not supported yet */
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static
2016-08-31 8:37 [PATCH] Input: focaltech - mark focaltech_set_resolution() static Baoyou Xie
@ 2016-08-31 9:58 ` Arnd Bergmann
2016-09-05 17:33 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2016-08-31 9:58 UTC (permalink / raw)
To: Baoyou Xie
Cc: dmitry.torokhov, pali.rohar, hdegoede, linux-input, linux-kernel,
xie.baoyou
On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> So this patch marks it 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: focaltech - mark focaltech_set_resolution() static
2016-08-31 9:58 ` Arnd Bergmann
@ 2016-09-05 17:33 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2016-09-05 17:33 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Baoyou Xie, pali.rohar, hdegoede, linux-input, linux-kernel, xie.baoyou
On Wed, Aug 31, 2016 at 11:58:50AM +0200, Arnd Bergmann wrote:
> On Wednesday, August 31, 2016 4:37:41 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/input/mouse/focaltech.c:393:6: warning: no previous prototype for 'focaltech_set_resolution' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-05 17:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-31 8:37 [PATCH] Input: focaltech - mark focaltech_set_resolution() static Baoyou Xie
2016-08-31 9:58 ` Arnd Bergmann
2016-09-05 17:33 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).