* [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper
@ 2012-11-13 1:53 Shan Wei
2012-11-13 9:55 ` [B.A.T.M.A.N.] " Marek Lindner
0 siblings, 1 reply; 3+ messages in thread
From: Shan Wei @ 2012-11-13 1:53 UTC (permalink / raw)
To: lindner_marek, siwu, ordex, b.a.t.m.a.n, David Miller, NetDev,
Kernel-Maillist, Shan Wei, Christoph Lameter
From: Shan Wei <davidshan@tencent.com>
this_cpu_add is an atomic operation.
and be more faster than per_cpu_ptr operation.
Signed-off-by: Shan Wei <davidshan@tencent.com>
Reviewed-by: Christoph Lameter <cl@linux.com>
---
v4: no changes vs v3.
---
net/batman-adv/main.h | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index 897ba6a..3aef5b2 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp,
static inline void batadv_add_counter(struct batadv_priv *bat_priv, size_t idx,
size_t count)
{
- int cpu = get_cpu();
- per_cpu_ptr(bat_priv->bat_counters, cpu)[idx] += count;
- put_cpu();
+ this_cpu_add(bat_priv->bat_counters[idx], count);
}
#define batadv_inc_counter(b, i) batadv_add_counter(b, i, 1)
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper
2012-11-13 1:53 [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper Shan Wei
@ 2012-11-13 9:55 ` Marek Lindner
2012-11-13 10:25 ` Shan Wei
0 siblings, 1 reply; 3+ messages in thread
From: Marek Lindner @ 2012-11-13 9:55 UTC (permalink / raw)
To: b.a.t.m.a.n
Cc: Shan Wei, siwu, ordex, David Miller, NetDev, Kernel-Maillist,
Christoph Lameter
On Tuesday, November 13, 2012 09:53:26 Shan Wei wrote:
> From: Shan Wei <davidshan@tencent.com>
>
> this_cpu_add is an atomic operation.
> and be more faster than per_cpu_ptr operation.
>
> Signed-off-by: Shan Wei <davidshan@tencent.com>
> Reviewed-by: Christoph Lameter <cl@linux.com>
> ---
> v4: no changes vs v3.
> ---
> net/batman-adv/main.h | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
Applied in our tree (revision f8b19e1). We will pass along this patch through
our standard workflow. No need to resend this patch in the future.
Thanks,
Marek
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [B.A.T.M.A.N.] [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper
2012-11-13 9:55 ` [B.A.T.M.A.N.] " Marek Lindner
@ 2012-11-13 10:25 ` Shan Wei
0 siblings, 0 replies; 3+ messages in thread
From: Shan Wei @ 2012-11-13 10:25 UTC (permalink / raw)
To: Marek Lindner
Cc: b.a.t.m.a.n, siwu, ordex, David Miller, NetDev, Kernel-Maillist,
Christoph Lameter
Marek Lindner said, at 2012/11/13 17:55:
>> net/batman-adv/main.h | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> Applied in our tree (revision f8b19e1). We will pass along this patch through
> our standard workflow. No need to resend this patch in the future.
OK thanks~
>
> Thanks,
> Marek
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-13 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-13 1:53 [PATCH v4 9/9] net: batman-adv: use per_cpu_add helper Shan Wei
2012-11-13 9:55 ` [B.A.T.M.A.N.] " Marek Lindner
2012-11-13 10:25 ` Shan Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).