* [PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ
@ 2012-12-05 13:19 Axel Lin
2012-12-06 5:34 ` Laxman Dewangan
2012-12-09 14:22 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2012-12-05 13:19 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: Laxman Dewangan, linux-kernel
This driver uses regmap_irq APIs, thus need to select REGMAP_IRQ.
IRQ_DOMAIN will be selected if select REGMAP_IRQ, thus remove it here.
This fixes below build errors:
drivers/built-in.o: In function `tps80031_remove':
drivers/mfd/tps80031.c:534: undefined reference to `regmap_del_irq_chip'
drivers/built-in.o: In function `tps80031_irq_init':
drivers/mfd/tps80031.c:305: undefined reference to `regmap_add_irq_chip'
drivers/built-in.o: In function `tps80031_probe':
drivers/mfd/tps80031.c:496: undefined reference to `regmap_irq_get_domain'
drivers/mfd/tps80031.c:512: undefined reference to `regmap_del_irq_chip'
make: *** [vmlinux] Error 1
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/mfd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 09d43a9..1c0abd4 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -269,7 +269,7 @@ config MFD_TPS80031
depends on I2C=y && GENERIC_HARDIRQS
select MFD_CORE
select REGMAP_I2C
- select IRQ_DOMAIN
+ select REGMAP_IRQ
help
If you say yes here you get support for the Texas Instruments
TPS80031/ TPS80032 Fully Integrated Power Management with Power
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ
2012-12-05 13:19 [PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ Axel Lin
@ 2012-12-06 5:34 ` Laxman Dewangan
2012-12-09 14:22 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Laxman Dewangan @ 2012-12-06 5:34 UTC (permalink / raw)
To: Axel Lin; +Cc: Samuel Ortiz, linux-kernel
On Wednesday 05 December 2012 06:49 PM, Axel Lin wrote:
> This driver uses regmap_irq APIs, thus need to select REGMAP_IRQ.
> IRQ_DOMAIN will be selected if select REGMAP_IRQ, thus remove it here.
>
> This fixes below build errors:
>
> drivers/built-in.o: In function `tps80031_remove':
> drivers/mfd/tps80031.c:534: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps80031_irq_init':
> drivers/mfd/tps80031.c:305: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps80031_probe':
> drivers/mfd/tps80031.c:496: undefined reference to `regmap_irq_get_domain'
> drivers/mfd/tps80031.c:512: undefined reference to `regmap_del_irq_chip'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin<axel.lin@ingics.com>
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ
2012-12-05 13:19 [PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ Axel Lin
2012-12-06 5:34 ` Laxman Dewangan
@ 2012-12-09 14:22 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2012-12-09 14:22 UTC (permalink / raw)
To: Axel Lin; +Cc: Laxman Dewangan, linux-kernel
Hi Axel,
On Wed, Dec 05, 2012 at 09:19:48PM +0800, Axel Lin wrote:
> This driver uses regmap_irq APIs, thus need to select REGMAP_IRQ.
> IRQ_DOMAIN will be selected if select REGMAP_IRQ, thus remove it here.
>
> This fixes below build errors:
>
> drivers/built-in.o: In function `tps80031_remove':
> drivers/mfd/tps80031.c:534: undefined reference to `regmap_del_irq_chip'
> drivers/built-in.o: In function `tps80031_irq_init':
> drivers/mfd/tps80031.c:305: undefined reference to `regmap_add_irq_chip'
> drivers/built-in.o: In function `tps80031_probe':
> drivers/mfd/tps80031.c:496: undefined reference to `regmap_irq_get_domain'
> drivers/mfd/tps80031.c:512: undefined reference to `regmap_del_irq_chip'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/mfd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied as well, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-09 14:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-05 13:19 [PATCH] mfd: tps80031: MFD_TPS80031 needs to select REGMAP_IRQ Axel Lin
2012-12-06 5:34 ` Laxman Dewangan
2012-12-09 14:22 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).