[PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

[PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

[Venu Byravarasu]

Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy.
This ensures that all function pointers in member u_phy are
initialized to NULL.

Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
---
This patch is v3 patch for the patch discussed at
http://marc.info/?l=linux-kernel&m=135599303216132&w=2

 drivers/usb/phy/tegra_usb_phy.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/phy/tegra_usb_phy.c b/drivers/usb/phy/tegra_usb_phy.c
index 04bf5d2..dedead5 100644
--- a/drivers/usb/phy/tegra_usb_phy.c
+++ b/drivers/usb/phy/tegra_usb_phy.c
@@ -736,7 +736,7 @@ struct tegra_usb_phy *tegra_usb_phy_open(struct device *dev,
 	int err;
 	u8 index = is_legacy_mode ? 0 : 2;
 
-	phy = kmalloc(sizeof(struct tegra_usb_phy), GFP_KERNEL);
+	phy = kzalloc(sizeof(struct tegra_usb_phy), GFP_KERNEL);
 	if (!phy)
 		return ERR_PTR(-ENOMEM);
 
-- 
1.7.0.4

Re: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

[Stephen Warren]

On 12/20/2012 11:34 PM, Venu Byravarasu wrote:
> Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy.
> This ensures that all function pointers in member u_phy are
> initialized to NULL.

Seems fine to me. For the record, I'd like to take this through the
Tegra tree with all the other Tegra-related USB patches in order to
manage any dependencies, with the USB maintainers' Acks. Thanks.

RE: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

[Venu Byravarasu]

Thanks Stephen.
Venu


> -----Original Message-----
> From: Stephen Warren [mailto:swarren@wwwdotorg.org]
> Sent: Saturday, December 22, 2012 2:25 AM
> To: Venu Byravarasu
> Cc: balbi@ti.com; gregkh@linuxfoundation.org; sshtylyov@mvista.com;
> linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org
> Subject: Re: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy
> 
> On 12/20/2012 11:34 PM, Venu Byravarasu wrote:
> > Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy.
> > This ensures that all function pointers in member u_phy are
> > initialized to NULL.
> 
> Seems fine to me. For the record, I'd like to take this through the
> Tegra tree with all the other Tegra-related USB patches in order to
> manage any dependencies, with the USB maintainers' Acks. Thanks.

Re: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

[Greg KH]

On Fri, Dec 21, 2012 at 01:54:55PM -0700, Stephen Warren wrote:
> On 12/20/2012 11:34 PM, Venu Byravarasu wrote:
> > Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy.
> > This ensures that all function pointers in member u_phy are
> > initialized to NULL.
> 
> Seems fine to me. For the record, I'd like to take this through the
> Tegra tree with all the other Tegra-related USB patches in order to
> manage any dependencies, with the USB maintainers' Acks. Thanks.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Re: [PATCH v3] usb: phy: use kzalloc to allocate struct tegra_usb_phy

[Stephen Warren]

On 01/11/2013 05:14 PM, Greg KH wrote:
> On Fri, Dec 21, 2012 at 01:54:55PM -0700, Stephen Warren wrote:
>> On 12/20/2012 11:34 PM, Venu Byravarasu wrote:
>>> Use kzalloc instead of kmalloc to allocate struct tegra_usb_phy.
>>> This ensures that all function pointers in member u_phy are
>>> initialized to NULL.
>>
>> Seems fine to me. For the record, I'd like to take this through the
>> Tegra tree with all the other Tegra-related USB patches in order to
>> manage any dependencies, with the USB maintainers' Acks. Thanks.
> 
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Thanks, applied to Tegra's for-3.9/usb branch.