From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: tglx@linutronix.de, Dmitry.Prohorov@intel.com,
alexander.shishkin@linux.intel.com, acme@redhat.com,
mark.rutland@arm.com, linux-kernel@vger.kernel.org,
hpa@zytor.com, jolsa@redhat.com, torvalds@linux-foundation.org,
mingo@kernel.org, vincent.weaver@maine.edu, kan.liang@intel.com,
eranian@google.com, davidcc@google.com,
valery.cherepennikov@intel.com,
linux-tip-commits@vger.kernel.org
Subject: Re: [PATCH] perf: Fix sibling iteration
Date: Fri, 16 Mar 2018 13:53:07 +0300 [thread overview]
Message-ID: <50dd4160-63ea-2ec6-ae00-241632fb4998@linux.intel.com> (raw)
In-Reply-To: <20180316103129.GC4064@hirez.programming.kicks-ass.net>
On 16.03.2018 13:31, Peter Zijlstra wrote:
> On Fri, Mar 16, 2018 at 12:59:34PM +0300, Alexey Budankov wrote:
>> Hi,
>> On 15.03.2018 20:01, Peter Zijlstra wrote:
>>> Subject: perf: Fix sibling iteration
>>> From: Peter Zijlstra <peterz@infradead.org>
>>> Date: Thu Mar 15 17:36:56 CET 2018
>>>
>>> Mark noticed that the change to sibling_list changed some iteration
>>> semantics; because previously we used group_list as list entry,
>>> sibling events would always have an empty sibling_list.
>>>
>>> But because we now use sibling_list for both list head and list entry,
>>> siblings will report as having siblings.
>>>
>>> Fix this with a custom for_each_sibling_event() iterator.
>>>
>>> Suggested-by: Mark Rutland <mark.rutland@arm.com>
>>> Reported-by: Mark Rutland <mark.rutland@arm.com>
>>> Fixes: 8343aae66167 ("perf/core: Remove perf_event::group_entry")
>>> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
>>> ---
>>
>> Applied to tip repo and run testing on Fedora 27/x86_64 (client skylake 8 cores):
>
> There is at least one more known issue with that patch, but neither Mark
> nor me could reproduce so far, so we don't know if we're right about the
> cause.
Please share more information regarding the issue. I am ready to help.
Thanks,
Alexey
next prev parent reply other threads:[~2018-03-16 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-8343aae66167df6708128a778e750d48dbe31302@git.kernel.org>
2018-03-15 17:01 ` [PATCH] perf: Fix sibling iteration Peter Zijlstra
2018-03-16 9:59 ` Alexey Budankov
2018-03-16 10:31 ` Peter Zijlstra
2018-03-16 10:39 ` Jiri Olsa
2018-03-16 10:50 ` Peter Zijlstra
2018-03-16 12:07 ` Mark Rutland
2018-03-16 13:17 ` [PATCH] perf/core: clear sibling list of detached events (was "Re: [PATCH] perf: Fix sibling iteration") Mark Rutland
2018-03-16 13:44 ` Peter Zijlstra
2018-03-16 14:37 ` [tip:perf/core] perf/core: Clear sibling list of detached events tip-bot for Mark Rutland
2018-03-16 19:49 ` tip-bot for Mark Rutland
2018-03-16 10:53 ` Alexey Budankov [this message]
2018-03-16 14:36 ` [tip:perf/core] perf: Fix sibling iteration tip-bot for Peter Zijlstra
2018-03-16 19:49 ` tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50dd4160-63ea-2ec6-ae00-241632fb4998@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=Dmitry.Prohorov@intel.com \
--cc=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=valery.cherepennikov@intel.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).