linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Vishwanathrao Badarkhe, Manish" <manishv.b@ti.com>,
	<devicetree-discuss@lists.ozlabs.org>,
	<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<davinci-linux-open-source@linux.davincidsp.com>,
	<anilkumar@ti.com>, <tony@atomide.com>, <hs@denx.de>,
	<broonie@opensource.wolfsonmicro.com>, <sameo@linux.intel.com>,
	<khilman@deeprootsystems.com>, <linux@arm.linux.org.uk>,
	<rob@landley.net>, <rob.herring@calxeda.com>,
	<grant.likely@secretlab.ca>
Subject: Re: [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit
Date: Fri, 1 Feb 2013 12:35:30 +0530	[thread overview]
Message-ID: <510B693A.70807@ti.com> (raw)
In-Reply-To: <CACRpkdbf7TwrjfT2rhqQFGc3yh_Nt117RtzQO2y6g5Ddx5Ay_w@mail.gmail.com>

On 1/29/2013 4:29 PM, Linus Walleij wrote:
> On Tue, Jan 29, 2013 at 8:38 AM, Vishwanathrao Badarkhe, Manish
> <manishv.b@ti.com> wrote:
> 
>> Currently, I2C driver gets probed before pinctrl driver.
>> To achieve I2C pin muxing via pinctrl driver before I2C
>> probe get called, register pinctrl driver in arch_initcall.
>> Also, add module_exit to unregister pinctrl driver.
>>
>> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@ti.com>
> 
> So your I2C driver is not returning -EPROBE_DEFER
> if it cannot find its pins?
> 
> Hm, well I can live with this, if Tony ACKs it.

FWIW, most of the other pinctrl drivers seem to be using arch_initcall() 
already.

$ grep -r arch_initcall drivers/pinctrl/*
drivers/pinctrl/pinctrl-at91.c:arch_initcall(at91_pinctrl_init);
drivers/pinctrl/pinctrl-coh901.c:arch_initcall(u300_gpio_init);
drivers/pinctrl/pinctrl-imx35.c:arch_initcall(imx35_pinctrl_init);
drivers/pinctrl/pinctrl-imx51.c:arch_initcall(imx51_pinctrl_init);
drivers/pinctrl/pinctrl-imx53.c:arch_initcall(imx53_pinctrl_init);
drivers/pinctrl/pinctrl-imx6q.c:arch_initcall(imx6q_pinctrl_init);
drivers/pinctrl/pinctrl-sirf.c:arch_initcall(sirfsoc_pinmux_init);
drivers/pinctrl/pinctrl-tegra20.c:arch_initcall(tegra20_pinctrl_init);
drivers/pinctrl/pinctrl-tegra30.c:arch_initcall(tegra30_pinctrl_init);
drivers/pinctrl/pinctrl-u300.c:arch_initcall(u300_pmx_init);
drivers/pinctrl/spear/pinctrl-spear300.c:arch_initcall(spear300_pinctrl_init);
drivers/pinctrl/spear/pinctrl-spear320.c:arch_initcall(spear320_pinctrl_init);
drivers/pinctrl/spear/pinctrl-spear310.c:arch_initcall(spear310_pinctrl_init);
drivers/pinctrl/spear/pinctrl-spear1340.c:arch_initcall(spear1340_pinctrl_init);
drivers/pinctrl/spear/pinctrl-spear1310.c:arch_initcall(spear1310_pinctrl_init);

Thanks,
Sekhar

  parent reply	other threads:[~2013-02-01  7:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-29  7:38 [PATCH V2 0/6] davinci: DT support for i2c0 and tps6507x Vishwanathrao Badarkhe, Manish
2013-01-29  7:38 ` [PATCH V2 1/6] pinctrl: pinctrl-single: use arch_initcall and module_exit Vishwanathrao Badarkhe, Manish
2013-01-29 10:59   ` Linus Walleij
2013-01-29 12:02     ` Vishwanathrao Badarkhe, Manish
2013-02-01  7:05     ` Sekhar Nori [this message]
2013-02-01 17:09     ` Tony Lindgren
2013-02-01 17:11       ` Tony Lindgren
2013-02-05  6:36         ` Vishwanathrao Badarkhe, Manish
2013-02-05 11:27           ` Russell King - ARM Linux
2013-02-06  6:04             ` Vishwanathrao Badarkhe, Manish
2013-02-05 13:00           ` Linus Walleij
2013-02-06  4:57             ` Vishwanathrao Badarkhe, Manish
2013-01-29  7:38 ` [PATCH V2 2/6] ARM: davinci: da850: add OF_DEV_AUXDATA entry for I2C0 Vishwanathrao Badarkhe, Manish
2013-01-29  7:38 ` [PATCH V2 3/6] ARM: davinci: da850: add DT node " Vishwanathrao Badarkhe, Manish
2013-02-03 12:49   ` Sekhar Nori
2013-02-04  3:07     ` Vishwanathrao Badarkhe, Manish
2013-01-29  7:38 ` [PATCH V2 4/6] mfd: tps6507x: add device-tree support Vishwanathrao Badarkhe, Manish
2013-02-03 22:31   ` Samuel Ortiz
2013-01-29  7:38 ` [PATCH V2 5/6] ARM: regulator: add tps6507x device tree data Vishwanathrao Badarkhe, Manish
2013-02-07 10:21   ` Vishwanathrao Badarkhe, Manish
2013-01-29  7:38 ` [PATCH V2 6/6] ARM: davinci: da850: add tps6507x regulator DT data Vishwanathrao Badarkhe, Manish
2013-02-07 10:22   ` Vishwanathrao Badarkhe, Manish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510B693A.70807@ti.com \
    --to=nsekhar@ti.com \
    --cc=anilkumar@ti.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hs@denx.de \
    --cc=khilman@deeprootsystems.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=manishv.b@ti.com \
    --cc=rob.herring@calxeda.com \
    --cc=rob@landley.net \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).