From: Faiz Abbas <faiz_abbas@ti.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>
Cc: <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/2] mmc: sdhci: Add Quirk for enabling HISPD under special conditions
Date: Mon, 1 Apr 2019 16:14:21 +0530 [thread overview]
Message-ID: <51104203-068b-a25c-299b-ac9a2f720680@ti.com> (raw)
In-Reply-To: <6d8f9b8c-dd5c-a091-7a82-10e5f6606b4e@intel.com>
Hi Adrian,
On 01/04/19 2:42 PM, Adrian Hunter wrote:
> On 1/04/19 12:01 PM, Faiz Abbas wrote:
>> Hi Adrian,
>>
>> On 01/04/19 2:21 PM, Adrian Hunter wrote:
>>> On 29/03/19 4:22 PM, Faiz Abbas wrote:
>>>> Some controllers on TI devices requires the HISPD bit to be cleared
>>>> even in some high speed modes. Add a quirk that facilitates this
>>>> requirement.
>>>
>>> Could you use sdhci I/O accessors for this?
>>
>> Can you elaborate? Not sure how this would be solved with
>> CONFIG_MMC_SDHCI_IO_ACCESSORS.
>
> In ->writeb()
>
> if (reg == SDHCI_HOST_CONTROL) {
> if (host->mmc->ios->timing == whatever)
> val &= ~SDHCI_CTRL_HISPD;
> }
>
> writeb(val, host->ioaddr + reg);
This is a really good idea. Will use it in v2. Thanks.
Regards,
Faiz
next prev parent reply other threads:[~2019-04-01 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 14:22 [PATCH 0/2] Add QUIRK for special HISPD bit in am65x-evm Faiz Abbas
2019-03-29 14:22 ` [PATCH 1/2] mmc: sdhci: Add Quirk for enabling HISPD under special conditions Faiz Abbas
2019-04-01 8:51 ` Adrian Hunter
2019-04-01 9:01 ` Faiz Abbas
2019-04-01 9:12 ` Adrian Hunter
2019-04-01 10:44 ` Faiz Abbas [this message]
2019-03-29 14:22 ` [PATCH 2/2] mmc: sdhci_am654: Add QUIRK2_TI_HISPD_BIT Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51104203-068b-a25c-299b-ac9a2f720680@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).