[REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Joseph Salisbury]

Hello,

Please consider reverting commit 
3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the 
current stable releases.  It was included upstream as of v3.6-rc6.  This 
commit introduced a regression, described in the following bug report:

http://bugs.launchpad.net/bugs/1088733

Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 
kernel has been confirmed to resolve the aforementioned bug.


Sincerely,

Joseph Salisbury

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Ben Hutchings]

On Thu, Jan 17, 2013 at 01:34:41PM -0500, Joseph Salisbury wrote:
> Hello,
> 
> Please consider reverting commit
> 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in
> the current stable releases.  It was included upstream as of
> v3.6-rc6.  This commit introduced a regression, described in the
> following bug report:
> 
> http://bugs.launchpad.net/bugs/1088733
> 
> Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the
> v3.2 kernel has been confirmed to resolve the aforementioned bug.
 
If it's wrong in mainline then the revert needs to be done there
and cc'd to stable.  We only revert directly in stable branches if
the revert is not appropriate in mainline.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Joseph Salisbury]

On 01/17/2013 01:51 PM, Ben Hutchings wrote:
> On Thu, Jan 17, 2013 at 01:34:41PM -0500, Joseph Salisbury wrote:
>> Hello,
>>
>> Please consider reverting commit
>> 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in
>> the current stable releases.  It was included upstream as of
>> v3.6-rc6.  This commit introduced a regression, described in the
>> following bug report:
>>
>> http://bugs.launchpad.net/bugs/1088733
>>
>> Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the
>> v3.2 kernel has been confirmed to resolve the aforementioned bug.
>   
> If it's wrong in mainline then the revert needs to be done there
> and cc'd to stable.  We only revert directly in stable branches if
> the revert is not appropriate in mainline.
>
> Ben.
>
Hi Ben,

Understood.  Thanks for the feedback.  I'll resend as a patch to mainline.

Thanks,

Joe

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Alan Stern]

On Thu, 17 Jan 2013, Joseph Salisbury wrote:

> Hello,
> 
> Please consider reverting commit 
> 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the 
> current stable releases.  It was included upstream as of v3.6-rc6.  This 
> commit introduced a regression, described in the following bug report:
> 
> http://bugs.launchpad.net/bugs/1088733
> 
> Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2 
> kernel has been confirmed to resolve the aforementioned bug.

I do not want to revert this commit without first understanding what is 
going wrong.  Please ask the reporter to post usbmon traces showing 
what happens in both a failed and a successful recording attempt.

Alan Stern

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Joseph Salisbury]

On 01/17/2013 01:56 PM, Alan Stern wrote:
> On Thu, 17 Jan 2013, Joseph Salisbury wrote:
>
>> Hello,
>>
>> Please consider reverting commit
>> 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the
>> current stable releases.  It was included upstream as of v3.6-rc6.  This
>> commit introduced a regression, described in the following bug report:
>>
>> http://bugs.launchpad.net/bugs/1088733
>>
>> Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2
>> kernel has been confirmed to resolve the aforementioned bug.
> I do not want to revert this commit without first understanding what is
> going wrong.  Please ask the reporter to post usbmon traces showing
> what happens in both a failed and a successful recording attempt.
>
> Alan Stern
>
Will do.  Thanks, Alan.

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Joseph Salisbury]

On 01/17/2013 01:56 PM, Alan Stern wrote:
> On Thu, 17 Jan 2013, Joseph Salisbury wrote:
>
>> Hello,
>>
>> Please consider reverting commit
>> 3d037774b42ed677f699b1dce7d548d55f4e4c2b in mainline as well as in the
>> current stable releases.  It was included upstream as of v3.6-rc6.  This
>> commit introduced a regression, described in the following bug report:
>>
>> http://bugs.launchpad.net/bugs/1088733
>>
>> Reverting commit 3d037774b42ed677f699b1dce7d548d55f4e4c2b in the v3.2
>> kernel has been confirmed to resolve the aforementioned bug.
> I do not want to revert this commit without first understanding what is
> going wrong.  Please ask the reporter to post usbmon traces showing
> what happens in both a failed and a successful recording attempt.
>
> Alan Stern
>
Hi Alan,

There is a tar file[0] attached to the bug report[1].  The tar file 
contains a few examples of failed and successful recording attempts 
while collecting usbmon traces.  There is a readme.txt file available 
after extracting the files.

The bug reporter states that only the first recording after boot fails. 
Subsequent recordings succeed will succeed.

Thanks again for reviewing this, Alan.  Just let me know if you would 
like any additional data or testing.

Thanks,

Joe

[0] 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
[1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Alan Stern]

On Fri, 1 Feb 2013, Joseph Salisbury wrote:

> Hi Alan,
> 
> There is a tar file[0] attached to the bug report[1].  The tar file 
> contains a few examples of failed and successful recording attempts 
> while collecting usbmon traces.  There is a readme.txt file available 
> after extracting the files.
> 
> The bug reporter states that only the first recording after boot fails. 
> Subsequent recordings succeed will succeed.
> 
> Thanks again for reviewing this, Alan.  Just let me know if you would 
> like any additional data or testing.
> 
> Thanks,
> 
> Joe
> 
> [0] 
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733

I have replied to the original report at bugs.launchpad.net with a
diagnostic patch.  Maybe it will help indicate what's going wrong.

Alan Stern

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Joseph Salisbury]

On 02/04/2013 05:04 PM, Alan Stern wrote:
> On Fri, 1 Feb 2013, Joseph Salisbury wrote:
>
>> Hi Alan,
>>
>> There is a tar file[0] attached to the bug report[1].  The tar file
>> contains a few examples of failed and successful recording attempts
>> while collecting usbmon traces.  There is a readme.txt file available
>> after extracting the files.
>>
>> The bug reporter states that only the first recording after boot fails.
>> Subsequent recordings succeed will succeed.
>>
>> Thanks again for reviewing this, Alan.  Just let me know if you would
>> like any additional data or testing.
>>
>> Thanks,
>>
>> Joe
>>
>> [0]
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733
> I have replied to the original report at bugs.launchpad.net with a
> diagnostic patch.  Maybe it will help indicate what's going wrong.
>
> Alan Stern
>
Thanks so much for the assistance, Alan.  I'll work with the bug 
reporter to build a kernel with the patch and test.

Joe

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Alan Stern]

On Tue, 5 Feb 2013, Joseph Salisbury wrote:

> > I have replied to the original report at bugs.launchpad.net with a
> > diagnostic patch.  Maybe it will help indicate what's going wrong.
> >
> > Alan Stern
> >
> Thanks so much for the assistance, Alan.  I'll work with the bug 
> reporter to build a kernel with the patch and test.

The bug reporter may not need any help, considering that he was already 
able to carry out a git bisection search.

Alan Stern

Re: [REVERT][v3.x.y] EHCI: Update qTD next pointer in QH overlay region during unlink

[Joseph Salisbury]

On 02/04/2013 05:04 PM, Alan Stern wrote:
> On Fri, 1 Feb 2013, Joseph Salisbury wrote:
>
>> Hi Alan,
>>
>> There is a tar file[0] attached to the bug report[1].  The tar file
>> contains a few examples of failed and successful recording attempts
>> while collecting usbmon traces.  There is a readme.txt file available
>> after extracting the files.
>>
>> The bug reporter states that only the first recording after boot fails.
>> Subsequent recordings succeed will succeed.
>>
>> Thanks again for reviewing this, Alan.  Just let me know if you would
>> like any additional data or testing.
>>
>> Thanks,
>>
>> Joe
>>
>> [0]
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3510887/+files/usbmon-1088733.tar.gz
>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733
> I have replied to the original report at bugs.launchpad.net with a
> diagnostic patch.  Maybe it will help indicate what's going wrong.
>
> Alan Stern
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
Hi Alan,

The bug reporter collected some data[0] using your diagnostic patch.

Thanks again for all your help.

Joe


[0] 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1088733/+attachment/3516533/+files/usbmon-diag-1088733.tar.gz