* [PATCH] clk: tegra: local arrays should be static
@ 2013-02-07 16:30 Peter De Schrijver
2013-02-07 17:49 ` Mike Turquette
2013-02-08 5:22 ` Prashant Gaikwad
0 siblings, 2 replies; 4+ messages in thread
From: Peter De Schrijver @ 2013-02-07 16:30 UTC (permalink / raw)
To: pdeschrijver
Cc: Stephen Warren, Mike Turquette, Prashant Gaikwad, linux-kernel
cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
clk-tegra30.c. Declare them static to avoid namespace polution.
Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
drivers/clk/tegra/clk-tegra30.c | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
index a163812..d169ef0 100644
--- a/drivers/clk/tegra/clk-tegra30.c
+++ b/drivers/clk/tegra/clk-tegra30.c
@@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
}
-const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
- "pll_p_cclkg", "pll_p_out4_cclkg",
- "pll_p_out3_cclkg", "unused", "pll_x" };
-const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
- "pll_p_cclklp", "pll_p_out4_cclklp",
- "pll_p_out3_cclklp", "unused", "pll_x",
- "pll_x_out0" };
-const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
- "pll_p_out3", "pll_p_out2", "unused",
- "clk_32k", "pll_m_out1" };
+static const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
+ "pll_p_cclkg", "pll_p_out4_cclkg",
+ "pll_p_out3_cclkg", "unused", "pll_x" };
+static const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
+ "pll_p_cclklp", "pll_p_out4_cclklp",
+ "pll_p_out3_cclklp", "unused", "pll_x",
+ "pll_x_out0" };
+static const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
+ "pll_p_out3", "pll_p_out2", "unused",
+ "clk_32k", "pll_m_out1" };
static void __init tegra30_super_clk_init(void)
{
--
1.7.7.rc0.72.g4b5ea.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: tegra: local arrays should be static
2013-02-07 16:30 [PATCH] clk: tegra: local arrays should be static Peter De Schrijver
@ 2013-02-07 17:49 ` Mike Turquette
2013-02-07 19:13 ` Stephen Warren
2013-02-08 5:22 ` Prashant Gaikwad
1 sibling, 1 reply; 4+ messages in thread
From: Mike Turquette @ 2013-02-07 17:49 UTC (permalink / raw)
To: Peter De Schrijver, pdeschrijver
Cc: Stephen Warren, Prashant Gaikwad, linux-kernel
Quoting Peter De Schrijver (2013-02-07 08:30:36)
> cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
> clk-tegra30.c. Declare them static to avoid namespace polution.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Acked-by: Mike Turquette <mturquette@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: tegra: local arrays should be static
2013-02-07 17:49 ` Mike Turquette
@ 2013-02-07 19:13 ` Stephen Warren
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2013-02-07 19:13 UTC (permalink / raw)
To: Mike Turquette
Cc: Peter De Schrijver, Stephen Warren, Prashant Gaikwad, linux-kernel
On 02/07/2013 10:49 AM, Mike Turquette wrote:
> Quoting Peter De Schrijver (2013-02-07 08:30:36)
>> cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
>> clk-tegra30.c. Declare them static to avoid namespace polution.
>>
>> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
>
> Acked-by: Mike Turquette <mturquette@linaro.org>
I've applied this to Tegra's for-3.9/soc-ccf-fixes branch.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: tegra: local arrays should be static
2013-02-07 16:30 [PATCH] clk: tegra: local arrays should be static Peter De Schrijver
2013-02-07 17:49 ` Mike Turquette
@ 2013-02-08 5:22 ` Prashant Gaikwad
1 sibling, 0 replies; 4+ messages in thread
From: Prashant Gaikwad @ 2013-02-08 5:22 UTC (permalink / raw)
To: Peter De Schrijver; +Cc: Stephen Warren, Mike Turquette, linux-kernel
On Thursday 07 February 2013 10:00 PM, Peter De Schrijver wrote:
> cclk_g_parents, cclk_lp_parents and sclk_parents are only accessed from within
> clk-tegra30.c. Declare them static to avoid namespace polution.
>
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
Reviewed-by: Prashant Gaikwad <pgaikwad@nvidia.com>
> ---
> drivers/clk/tegra/clk-tegra30.c | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/clk/tegra/clk-tegra30.c b/drivers/clk/tegra/clk-tegra30.c
> index a163812..d169ef0 100644
> --- a/drivers/clk/tegra/clk-tegra30.c
> +++ b/drivers/clk/tegra/clk-tegra30.c
> @@ -1249,16 +1249,16 @@ static void __init tegra30_pmc_clk_init(void)
>
> }
>
> -const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> - "pll_p_cclkg", "pll_p_out4_cclkg",
> - "pll_p_out3_cclkg", "unused", "pll_x" };
> -const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> - "pll_p_cclklp", "pll_p_out4_cclklp",
> - "pll_p_out3_cclklp", "unused", "pll_x",
> - "pll_x_out0" };
> -const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
> - "pll_p_out3", "pll_p_out2", "unused",
> - "clk_32k", "pll_m_out1" };
> +static const char *cclk_g_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> + "pll_p_cclkg", "pll_p_out4_cclkg",
> + "pll_p_out3_cclkg", "unused", "pll_x" };
> +static const char *cclk_lp_parents[] = { "clk_m", "pll_c", "clk_32k", "pll_m",
> + "pll_p_cclklp", "pll_p_out4_cclklp",
> + "pll_p_out3_cclklp", "unused", "pll_x",
> + "pll_x_out0" };
> +static const char *sclk_parents[] = { "clk_m", "pll_c_out1", "pll_p_out4",
> + "pll_p_out3", "pll_p_out2", "unused",
> + "clk_32k", "pll_m_out1" };
>
> static void __init tegra30_super_clk_init(void)
> {
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-08 5:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-07 16:30 [PATCH] clk: tegra: local arrays should be static Peter De Schrijver
2013-02-07 17:49 ` Mike Turquette
2013-02-07 19:13 ` Stephen Warren
2013-02-08 5:22 ` Prashant Gaikwad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).