From: Fernando Luis Vazquez Cao <fernando_b1@lab.ntt.co.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ALSA: hda - no-primary-hp is a quirk for model ALC889 not ALC882
Date: Tue, 12 Feb 2013 18:42:59 +0900 [thread overview]
Message-ID: <511A0EA3.2080506@lab.ntt.co.jp> (raw)
In-Reply-To: <s5ha9r9opap.wl%tiwai@suse.de>
On 2013/02/12 18:27, Takashi Iwai wrote:
> At Tue, 12 Feb 2013 16:54:16 +0900,
> Fernando Luis Vázquez Cao wrote:
>> Substitute ALC889 for ALC882 in macro and function names.
>>
>> Cc: stable@vger.kernel.org
>> Cc: alsa-devel@alsa-project.org
>> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
> This fixup can work generically to all ALC882 variants, including
> ALC889. Unless you are really sure that this must be used exclusively
> only for ALC889, no reason to change the prefix.
Thank you for applying patches 1 and 2 (I agree that
the second patch is not needed for stable).
Regarding this patch, I am not completely sure whether
this issue is ALC889 specific so we probably shouldn't
apply it as you say.
Regards,
Fernando
next prev parent reply other threads:[~2013-02-12 9:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 7:47 [PATCH 1/3] ALSA: hda - Workaround for silent output on Sony Vaio VGC-LN51JGB with ALC889 Fernando Luis Vázquez Cao
2013-02-12 7:49 ` [PATCH 2/3] ALSA: hda - update documentation for no-primary-hp fixup Fernando Luis Vázquez Cao
2013-02-12 9:24 ` Takashi Iwai
2013-02-12 7:54 ` [PATCH 2/3] ALSA: hda - no-primary-hp is a quirk for model ALC889 not ALC882 Fernando Luis Vázquez Cao
2013-02-12 8:01 ` Fernando Luis Vazquez Cao
2013-02-12 9:27 ` Takashi Iwai
2013-02-12 9:42 ` Fernando Luis Vazquez Cao [this message]
2013-02-12 9:23 ` [PATCH 1/3] ALSA: hda - Workaround for silent output on Sony Vaio VGC-LN51JGB with ALC889 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=511A0EA3.2080506@lab.ntt.co.jp \
--to=fernando_b1@lab.ntt.co.jp \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).