From: Takashi Iwai <tiwai@suse.de>
To: "Fernando Luis Vázquez Cao" <fernando_b1@lab.ntt.co.jp>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ALSA: hda - update documentation for no-primary-hp fixup
Date: Tue, 12 Feb 2013 10:24:23 +0100 [thread overview]
Message-ID: <s5hbobpopfc.wl%tiwai@suse.de> (raw)
In-Reply-To: <1360655386.13766.4.camel@nexus.lab.ntt.co.jp>
At Tue, 12 Feb 2013 16:49:46 +0900,
Fernando Luis Vázquez Cao wrote:
>
> The problem addressed by this fixup is not specific to Vaio Z, affecting
> some Vaio all-in-one desktop PCs too. Update the code comments accordingly.
>
> Cc: stable@vger.kernel.org
> Cc: alsa-devel@alsa-project.org
> Signed-off-by: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
I applied this now to sound git tree but dropped Cc to stable because
the patch is no longer cleanly applicable due to the recent code
change. And this is just some minor documentation update, thus we can
still live peacefully without this fix.
thanks,
Takashi
> ---
>
> diff -urNp linux-3.7.6-orig/Documentation/sound/alsa/HD-Audio-Models.txt linux-3.7.6/Documentation/sound/alsa/HD-Audio-Models.txt
> --- linux-3.7.6-orig/Documentation/sound/alsa/HD-Audio-Models.txt 2012-12-11 12:30:57.000000000 +0900
> +++ linux-3.7.6/Documentation/sound/alsa/HD-Audio-Models.txt 2013-02-09 22:44:28.614772054 +0900
> @@ -53,7 +53,7 @@ ALC882/883/885/888/889
> acer-aspire-8930g Acer Aspire 8330G/6935G
> acer-aspire Acer Aspire others
> inv-dmic Inverted internal mic workaround
> - no-primary-hp VAIO Z workaround (for fixed speaker DAC)
> + no-primary-hp VAIO Z/VGC-LN51JGB workaround (for fixed speaker DAC)
>
> ALC861/660
> ==========
> diff -urNp linux-3.7.6-orig/sound/pci/hda/patch_realtek.c linux-3.7.6/sound/pci/hda/patch_realtek.c
> --- linux-3.7.6-orig/sound/pci/hda/patch_realtek.c 2013-02-09 22:39:11.745202168 +0900
> +++ linux-3.7.6/sound/pci/hda/patch_realtek.c 2013-02-09 22:50:10.924470402 +0900
> @@ -5153,7 +5153,8 @@ static void alc889_fixup_imac91_vref(str
> }
>
> /* Don't take HP output as primary
> - * strangely, the speaker output doesn't work on VAIO Z through DAC 0x05
> + * Strangely, the speaker output doesn't work on Vaio Z and some Vaio
> + * all-in-one desktop PCs (for example VGC-LN51JGB) through DAC 0x05
> */
> static void alc882_fixup_no_primary_hp(struct hda_codec *codec,
> const struct alc_fixup *fix, int action)
>
>
next prev parent reply other threads:[~2013-02-12 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 7:47 [PATCH 1/3] ALSA: hda - Workaround for silent output on Sony Vaio VGC-LN51JGB with ALC889 Fernando Luis Vázquez Cao
2013-02-12 7:49 ` [PATCH 2/3] ALSA: hda - update documentation for no-primary-hp fixup Fernando Luis Vázquez Cao
2013-02-12 9:24 ` Takashi Iwai [this message]
2013-02-12 7:54 ` [PATCH 2/3] ALSA: hda - no-primary-hp is a quirk for model ALC889 not ALC882 Fernando Luis Vázquez Cao
2013-02-12 8:01 ` Fernando Luis Vazquez Cao
2013-02-12 9:27 ` Takashi Iwai
2013-02-12 9:42 ` Fernando Luis Vazquez Cao
2013-02-12 9:23 ` [PATCH 1/3] ALSA: hda - Workaround for silent output on Sony Vaio VGC-LN51JGB with ALC889 Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hbobpopfc.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=fernando_b1@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).