* [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()
@ 2013-02-04 0:14 Jingoo Han
2013-02-18 1:48 ` gshark
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-02-04 0:14 UTC (permalink / raw)
To: 'Andrew Morton', 'LKML'
Cc: 'Richard Purdie', 'G.Shark Jeong', 'Jingoo Han'
There is no need to return -EIO, because backlight_device_register()
already returns correct error values.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/video/backlight/lm3630_bl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/backlight/lm3630_bl.c b/drivers/video/backlight/lm3630_bl.c
index a6d637b..76a62e9 100644
--- a/drivers/video/backlight/lm3630_bl.c
+++ b/drivers/video/backlight/lm3630_bl.c
@@ -320,7 +320,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
backlight_device_register(name, pchip->dev, pchip,
&lm3630_bank_a_ops, &props);
if (IS_ERR(pchip->bled1))
- return -EIO;
+ return PTR_ERR(pchip->bled1);
break;
case BLED_2:
props.brightness = pdata->init_brt_led2;
@@ -329,7 +329,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
backlight_device_register(name, pchip->dev, pchip,
&lm3630_bank_b_ops, &props);
if (IS_ERR(pchip->bled2))
- return -EIO;
+ return PTR_ERR(pchip->bled2);
break;
}
return 0;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()
2013-02-04 0:14 [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register() Jingoo Han
@ 2013-02-18 1:48 ` gshark
0 siblings, 0 replies; 2+ messages in thread
From: gshark @ 2013-02-18 1:48 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Andrew Morton', 'LKML', 'Richard Purdie',
'Daniel Jeong'
2013년 02월 04일 09:14, Jingoo Han 쓴 글:
> There is no need to return -EIO, because backlight_device_register()
> already returns correct error values.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/lm3630_bl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/lm3630_bl.c b/drivers/video/backlight/lm3630_bl.c
> index a6d637b..76a62e9 100644
> --- a/drivers/video/backlight/lm3630_bl.c
> +++ b/drivers/video/backlight/lm3630_bl.c
> @@ -320,7 +320,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
> backlight_device_register(name, pchip->dev, pchip,
> &lm3630_bank_a_ops, &props);
> if (IS_ERR(pchip->bled1))
> - return -EIO;
> + return PTR_ERR(pchip->bled1);
> break;
> case BLED_2:
> props.brightness = pdata->init_brt_led2;
> @@ -329,7 +329,7 @@ static int lm3630_backlight_register(struct lm3630_chip_data *pchip,
> backlight_device_register(name, pchip->dev, pchip,
> &lm3630_bank_b_ops, &props);
> if (IS_ERR(pchip->bled2))
> - return -EIO;
> + return PTR_ERR(pchip->bled2);
> break;
> }
> return 0;
Thank you. This patch looks good for us.
Acked-by: Daniel Jeong<daniel.jeong@ti.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-18 1:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-04 0:14 [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register() Jingoo Han
2013-02-18 1:48 ` gshark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).