From: "H. Peter Anvin" <hpa@zytor.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>,
Michal Marek <mmarek@suse.cz>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ebiederm@xmission.com,
xemul@parallels.com, Andrey Vagin <avagin@openvz.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Glauber Costa <glommer@parallels.com>,
Andi Kleen <andi@firstfloor.org>, Tejun Heo <tj@kernel.org>,
Matt Helsley <matthltc@us.ibm.com>,
Pekka Enberg <penberg@kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>,
Vasiliy Kulikov <segoon@openwall.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP
Date: Tue, 19 Feb 2013 13:48:27 -0800 [thread overview]
Message-ID: <5123F32B.3000401@zytor.com> (raw)
In-Reply-To: <20130219134256.f4cedf44.akpm@linux-foundation.org>
On 02/19/2013 01:42 PM, Andrew Morton wrote:
>> Index: linux-2.6.git/kernel/Makefile
>> ===================================================================
>> --- linux-2.6.git.orig/kernel/Makefile
>> +++ linux-2.6.git/kernel/Makefile
>> @@ -25,9 +25,7 @@ endif
>> obj-y += sched/
>> obj-y += power/
>>
>> -ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
>> -obj-$(CONFIG_X86) += kcmp.o
>> -endif
>> +obj-$(CONFIG_KCMP) += kcmp.o
>> obj-$(CONFIG_FREEZER) += freezer.o
>> obj-$(CONFIG_PROFILING) += profile.o
>> obj-$(CONFIG_STACKTRACE) += stacktrace.o
>
> This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n.
> Is there any point in doing that?
>
> What would be wrong with just doing
>
> obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o
>
The real question is if there are any potential use cases of kcmp()
outside checkpoint/restore. It is actually a very general facility.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2013-02-19 21:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 6:48 [patch 0/2] make kcmp own config entry Cyrill Gorcunov
2013-02-19 6:48 ` [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP Cyrill Gorcunov
2013-02-19 8:47 ` KOSAKI Motohiro
2013-02-19 9:22 ` Michal Marek
2013-02-19 9:31 ` Cyrill Gorcunov
2013-02-19 17:53 ` H. Peter Anvin
2013-02-19 18:28 ` Cyrill Gorcunov
2013-02-19 21:42 ` Andrew Morton
2013-02-19 21:48 ` H. Peter Anvin [this message]
2013-02-19 22:02 ` Cyrill Gorcunov
2013-02-19 21:54 ` Cyrill Gorcunov
2013-02-19 22:00 ` Andrew Morton
2013-02-19 22:11 ` Cyrill Gorcunov
2013-02-19 22:15 ` Cyrill Gorcunov
2013-02-19 22:32 ` Cyrill Gorcunov
2013-02-19 23:41 ` H. Peter Anvin
2013-02-19 6:48 ` [patch 2/2] arm: Wire up kcmp syscall Cyrill Gorcunov
2013-02-19 7:07 ` Cyrill Gorcunov
2013-02-20 23:17 ` Andrew Morton
2013-02-21 5:43 ` Cyrill Gorcunov
2013-02-23 22:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5123F32B.3000401@zytor.com \
--to=hpa@zytor.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avagin@openvz.org \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=fweisbec@gmail.com \
--cc=glommer@parallels.com \
--cc=gorcunov@openvz.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthltc@us.ibm.com \
--cc=mingo@elte.hu \
--cc=mmarek@suse.cz \
--cc=penberg@kernel.org \
--cc=segoon@openwall.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).