linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.
       [not found]   ` <51077BB3.2010809@asianux.com>
@ 2013-02-28  3:24     ` Chen Gang
  2013-02-28  6:07       ` Chen Gang
  0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-02-28  3:24 UTC (permalink / raw)
  To: JBottomley, David Miller, kxie, michaelc; +Cc: linux-scsi, linux-kernel

Hello relative Maintainers:

  could any one help checking this patch ?

    this patch fixes the compiling issue.
    the make command in my x86_64 laptop is: "make V=1 allmodconfig"
    the patch was sent in Jan-12-2013, and get non-reply now.

  could you please give a glance when you have time.

  thanks.

  :-)

gchen.


于 2013年01月29日 15:35, Chen Gang 写道:
> Hello JBottomley@parallels.com
> 
>   have you already fixed it by another patches ?
> 
>   if so:
>     better to let me know about it, so I should not bother you, again.
>   else
>     please give a glance to this patch, when you have time
>      (since compiling errors are always belong to critical errors)
> 
>   thanks.
> 
> 
> by the way:
>    I get the sending mail address from ./script/get_maintainer.pl.
>    if I sent to an incorrect member, please tell me.
> 
>   thanks.
> 
> gchen.
> 
> 
> 于 2013年01月20日 15:18, Chen Gang 写道:
>> Hello JBottomley@parallels.com
>>
>>   when you have free time, could you give a glance for this patch ?
>>
>>   thanks.
>>
>> gchen.
>>
>>
>> 于 2013年01月12日 20:42, Chen Gang 写道:
>>>
>>>   correct the include path,
>>>   or the compiler will report can not find "common.h"...
>>>
>>>   both cxgb3/ and cxgb4/ sub directly have l2t.h (they are different).
>>>   so it is not suitable to '-I' sub-directy, directly.
>>>
>>>
>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>> ---
>>>  drivers/scsi/cxgbi/Makefile        |    4 ++++
>>>  drivers/scsi/cxgbi/cxgb3i/cxgb3i.c |   14 +++++++-------
>>>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |   10 +++++-----
>>>  3 files changed, 16 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/drivers/scsi/cxgbi/Makefile b/drivers/scsi/cxgbi/Makefile
>>> index 86007e3..aff2998 100644
>>> --- a/drivers/scsi/cxgbi/Makefile
>>> +++ b/drivers/scsi/cxgbi/Makefile
>>> @@ -1,2 +1,6 @@
>>> +
>>> +ccflags-y			:= -Idrivers/net/ethernet/chelsio
>>> +subdir-ccflags-y		:= -Idrivers/net/ethernet/chelsio
>>> +
>>>  obj-$(CONFIG_SCSI_CXGB3_ISCSI)	+= libcxgbi.o cxgb3i/
>>>  obj-$(CONFIG_SCSI_CXGB4_ISCSI)	+= libcxgbi.o cxgb4i/
>>> diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>>> index 49692a1..ca92e72 100644
>>> --- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>>> +++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>>> @@ -18,13 +18,13 @@
>>>  #include <linux/moduleparam.h>
>>>  #include <scsi/scsi_host.h>
>>>  
>>> -#include "common.h"
>>> -#include "t3_cpl.h"
>>> -#include "t3cdev.h"
>>> -#include "cxgb3_defs.h"
>>> -#include "cxgb3_ctl_defs.h"
>>> -#include "cxgb3_offload.h"
>>> -#include "firmware_exports.h"
>>> +#include "cxgb3/common.h"
>>> +#include "cxgb3/t3_cpl.h"
>>> +#include "cxgb3/t3cdev.h"
>>> +#include "cxgb3/cxgb3_defs.h"
>>> +#include "cxgb3/cxgb3_ctl_defs.h"
>>> +#include "cxgb3/cxgb3_offload.h"
>>> +#include "cxgb3/firmware_exports.h"
>>>  #include "cxgb3i.h"
>>>  
>>>  static unsigned int dbg_level;
>>> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>>> index f924b3c..a5795d5 100644
>>> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>>> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>>> @@ -20,11 +20,11 @@
>>>  #include <net/dst.h>
>>>  #include <linux/netdevice.h>
>>>  
>>> -#include "t4_msg.h"
>>> -#include "cxgb4.h"
>>> -#include "cxgb4_uld.h"
>>> -#include "t4fw_api.h"
>>> -#include "l2t.h"
>>> +#include "cxgb4/t4_msg.h"
>>> +#include "cxgb4/cxgb4.h"
>>> +#include "cxgb4/cxgb4_uld.h"
>>> +#include "cxgb4/t4fw_api.h"
>>> +#include "cxgb4/l2t.h"
>>>  #include "cxgb4i.h"
>>>  
>>>  static unsigned int dbg_level;
>>>
>>
>>
> 
> 


-- 
Chen Gang

Asianux Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling.
  2013-02-28  3:24     ` [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling Chen Gang
@ 2013-02-28  6:07       ` Chen Gang
  2013-02-28  6:34         ` [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild Chen Gang
  0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-02-28  6:07 UTC (permalink / raw)
  To: JBottomley, David Miller, kxie, michaelc; +Cc: linux-scsi, linux-kernel


  I find another more suitable way to fix this issue.
    using ccflags-y instead of EXTRA_FLAGS.
    according to the file ./script/checkpatch.pl:

1755                 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1756                     ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1757                         my $flag = $1;
1758                         my $replacement = {
1759                                 'EXTRA_AFLAGS' =>   'asflags-y',
1760                                 'EXTRA_CFLAGS' =>   'ccflags-y',
1761                                 'EXTRA_CPPFLAGS' => 'cppflags-y',
1762                                 'EXTRA_LDFLAGS' =>  'ldflags-y',
1763                         };
1764                    
1765                         WARN("DEPRECATED_VARIABLE",
1766                              "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement  ->{$flag});


  I need send new patch for it.

  welcome any members to provide additional suggestions or completions.

  thanks.

  :-)

gchen.


于 2013年02月28日 11:24, Chen Gang 写道:
> Hello relative Maintainers:
> 
>   could any one help checking this patch ?
> 
>     this patch fixes the compiling issue.
>     the make command in my x86_64 laptop is: "make V=1 allmodconfig"
>     the patch was sent in Jan-12-2013, and get non-reply now.
> 
>   could you please give a glance when you have time.
> 
>   thanks.
> 
>   :-)
> 
> gchen.
> 
> 
> 于 2013年01月29日 15:35, Chen Gang 写道:
>> Hello JBottomley@parallels.com
>>
>>   have you already fixed it by another patches ?
>>
>>   if so:
>>     better to let me know about it, so I should not bother you, again.
>>   else
>>     please give a glance to this patch, when you have time
>>      (since compiling errors are always belong to critical errors)
>>
>>   thanks.
>>
>>
>> by the way:
>>    I get the sending mail address from ./script/get_maintainer.pl.
>>    if I sent to an incorrect member, please tell me.
>>
>>   thanks.
>>
>> gchen.
>>
>>
>> 于 2013年01月20日 15:18, Chen Gang 写道:
>>> Hello JBottomley@parallels.com
>>>
>>>   when you have free time, could you give a glance for this patch ?
>>>
>>>   thanks.
>>>
>>> gchen.
>>>
>>>
>>> 于 2013年01月12日 20:42, Chen Gang 写道:
>>>>
>>>>   correct the include path,
>>>>   or the compiler will report can not find "common.h"...
>>>>
>>>>   both cxgb3/ and cxgb4/ sub directly have l2t.h (they are different).
>>>>   so it is not suitable to '-I' sub-directy, directly.
>>>>
>>>>
>>>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
>>>> ---
>>>>  drivers/scsi/cxgbi/Makefile        |    4 ++++
>>>>  drivers/scsi/cxgbi/cxgb3i/cxgb3i.c |   14 +++++++-------
>>>>  drivers/scsi/cxgbi/cxgb4i/cxgb4i.c |   10 +++++-----
>>>>  3 files changed, 16 insertions(+), 12 deletions(-)
>>>>
>>>> diff --git a/drivers/scsi/cxgbi/Makefile b/drivers/scsi/cxgbi/Makefile
>>>> index 86007e3..aff2998 100644
>>>> --- a/drivers/scsi/cxgbi/Makefile
>>>> +++ b/drivers/scsi/cxgbi/Makefile
>>>> @@ -1,2 +1,6 @@
>>>> +
>>>> +ccflags-y			:= -Idrivers/net/ethernet/chelsio
>>>> +subdir-ccflags-y		:= -Idrivers/net/ethernet/chelsio
>>>> +
>>>>  obj-$(CONFIG_SCSI_CXGB3_ISCSI)	+= libcxgbi.o cxgb3i/
>>>>  obj-$(CONFIG_SCSI_CXGB4_ISCSI)	+= libcxgbi.o cxgb4i/
>>>> diff --git a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>>>> index 49692a1..ca92e72 100644
>>>> --- a/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>>>> +++ b/drivers/scsi/cxgbi/cxgb3i/cxgb3i.c
>>>> @@ -18,13 +18,13 @@
>>>>  #include <linux/moduleparam.h>
>>>>  #include <scsi/scsi_host.h>
>>>>  
>>>> -#include "common.h"
>>>> -#include "t3_cpl.h"
>>>> -#include "t3cdev.h"
>>>> -#include "cxgb3_defs.h"
>>>> -#include "cxgb3_ctl_defs.h"
>>>> -#include "cxgb3_offload.h"
>>>> -#include "firmware_exports.h"
>>>> +#include "cxgb3/common.h"
>>>> +#include "cxgb3/t3_cpl.h"
>>>> +#include "cxgb3/t3cdev.h"
>>>> +#include "cxgb3/cxgb3_defs.h"
>>>> +#include "cxgb3/cxgb3_ctl_defs.h"
>>>> +#include "cxgb3/cxgb3_offload.h"
>>>> +#include "cxgb3/firmware_exports.h"
>>>>  #include "cxgb3i.h"
>>>>  
>>>>  static unsigned int dbg_level;
>>>> diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>>>> index f924b3c..a5795d5 100644
>>>> --- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>>>> +++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
>>>> @@ -20,11 +20,11 @@
>>>>  #include <net/dst.h>
>>>>  #include <linux/netdevice.h>
>>>>  
>>>> -#include "t4_msg.h"
>>>> -#include "cxgb4.h"
>>>> -#include "cxgb4_uld.h"
>>>> -#include "t4fw_api.h"
>>>> -#include "l2t.h"
>>>> +#include "cxgb4/t4_msg.h"
>>>> +#include "cxgb4/cxgb4.h"
>>>> +#include "cxgb4/cxgb4_uld.h"
>>>> +#include "cxgb4/t4fw_api.h"
>>>> +#include "cxgb4/l2t.h"
>>>>  #include "cxgb4i.h"
>>>>  
>>>>  static unsigned int dbg_level;
>>>>
>>>
>>>
>>
>>
> 
> 


-- 
Chen Gang

Asianux Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild
  2013-02-28  6:07       ` Chen Gang
@ 2013-02-28  6:34         ` Chen Gang
  2013-04-07  3:17           ` Chen Gang
  0 siblings, 1 reply; 4+ messages in thread
From: Chen Gang @ 2013-02-28  6:34 UTC (permalink / raw)
  To: JBottomley, David Miller, kxie, michaelc; +Cc: linux-scsi, linux-kernel


  need using ccflags-y instead of EXTRA_CFLAGS
    can reference scripts/checkpatch.pl (1755..1766)

  when make EXTRA_CFLAGS=-W, the compiling issue will be occured.


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 drivers/scsi/cxgbi/cxgb3i/Kbuild |    2 +-
 drivers/scsi/cxgbi/cxgb4i/Kbuild |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/cxgbi/cxgb3i/Kbuild b/drivers/scsi/cxgbi/cxgb3i/Kbuild
index 6f095e2..961a12f 100644
--- a/drivers/scsi/cxgbi/cxgb3i/Kbuild
+++ b/drivers/scsi/cxgbi/cxgb3i/Kbuild
@@ -1,3 +1,3 @@
-EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3
+ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3
 
 obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o
diff --git a/drivers/scsi/cxgbi/cxgb4i/Kbuild b/drivers/scsi/cxgbi/cxgb4i/Kbuild
index 8290cda..3745864 100644
--- a/drivers/scsi/cxgbi/cxgb4i/Kbuild
+++ b/drivers/scsi/cxgbi/cxgb4i/Kbuild
@@ -1,3 +1,3 @@
-EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4
+ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4
 
 obj-$(CONFIG_SCSI_CXGB4_ISCSI) += cxgb4i.o
-- 
1.7.7.6

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild
  2013-02-28  6:34         ` [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild Chen Gang
@ 2013-04-07  3:17           ` Chen Gang
  0 siblings, 0 replies; 4+ messages in thread
From: Chen Gang @ 2013-04-07  3:17 UTC (permalink / raw)
  To: JBottomley, Greg KH, kxie, michaelc; +Cc: linux-scsi, linux-kernel

Hello Maintainers:

  please help check it when you have time.

  thanks.

gchen.

On 2013年02月28日 14:34, Chen Gang wrote:
> 
>   need using ccflags-y instead of EXTRA_CFLAGS
>     can reference scripts/checkpatch.pl (1755..1766)
> 
>   when make EXTRA_CFLAGS=-W, the compiling issue will be occured.
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  drivers/scsi/cxgbi/cxgb3i/Kbuild |    2 +-
>  drivers/scsi/cxgbi/cxgb4i/Kbuild |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/cxgbi/cxgb3i/Kbuild b/drivers/scsi/cxgbi/cxgb3i/Kbuild
> index 6f095e2..961a12f 100644
> --- a/drivers/scsi/cxgbi/cxgb3i/Kbuild
> +++ b/drivers/scsi/cxgbi/cxgb3i/Kbuild
> @@ -1,3 +1,3 @@
> -EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3
> +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb3
>  
>  obj-$(CONFIG_SCSI_CXGB3_ISCSI) += cxgb3i.o
> diff --git a/drivers/scsi/cxgbi/cxgb4i/Kbuild b/drivers/scsi/cxgbi/cxgb4i/Kbuild
> index 8290cda..3745864 100644
> --- a/drivers/scsi/cxgbi/cxgb4i/Kbuild
> +++ b/drivers/scsi/cxgbi/cxgb4i/Kbuild
> @@ -1,3 +1,3 @@
> -EXTRA_CFLAGS += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4
> +ccflags-y += -I$(srctree)/drivers/net/ethernet/chelsio/cxgb4
>  
>  obj-$(CONFIG_SCSI_CXGB4_ISCSI) += cxgb4i.o
> 


-- 
Chen Gang

Asianux Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-07  3:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <50F15A35.4000400@asianux.com>
     [not found] ` <50FB9A33.2090204@asianux.com>
     [not found]   ` <51077BB3.2010809@asianux.com>
2013-02-28  3:24     ` [PATCH] drivers/scsi/cxgbi: correcting the include path, so can pass compiling Chen Gang
2013-02-28  6:07       ` Chen Gang
2013-02-28  6:34         ` [PATCH] drivers/scsi/cxgbi: using ccflags-y instead of EXTRA_CFLAGS in Kbuild Chen Gang
2013-04-07  3:17           ` Chen Gang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).