From: Logan Gunthorpe <logang@deltatee.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-doc@vger.kernel.org, "Stephen Bates" <sbates@raithlin.com>,
"Christoph Hellwig" <hch@lst.de>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Ingo Molnar" <mingo@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Frederic Weisbecker" <frederic@kernel.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Christian König" <christian.koenig@amd.com>,
"Matthew Wilcox" <willy@infradead.org>
Subject: Re: [PATCH v8 1/4] PCI: Make specifying PCI devices in kernel parameters reusable
Date: Thu, 9 Aug 2018 15:18:16 -0600 [thread overview]
Message-ID: <512aa96e-1c31-ecbd-88c7-a5e417d533ba@deltatee.com> (raw)
In-Reply-To: <20180809211541.GF113140@bhelgaas-glaptop.roam.corp.google.com>
On 09/08/18 03:15 PM, Bjorn Helgaas wrote:
>> @@ -2994,7 +2994,26 @@
>> See header of drivers/block/paride/pcd.c.
>> See also Documentation/blockdev/paride.txt.
>>
>> - pci=option[,option...] [PCI] various PCI subsystem options:
>> + pci=option[,option...] [PCI] various PCI subsystem options.
>> +
>> + Some options herein operate on a specific device
>> + or a set of devices (<pci_dev>). These are
>> + specified in one of the following formats:
>> +
>> + [<domain>:]<bus>:<slot>.<func>
>> + pci:<vendor>:<device>[:<subvendor>:<subdevice>]
>> +
>> + Note: the first format specifies a PCI
>> + bus/slot/function address which may change
>
> Unless you object, I'm going to change "slot" references like this to
> "device" so they match "BDF" and the language in the spec, which uses
> "slot" to refer to a physical slot and "device" when referring to
> geographical device addresses. I can do this when I apply these, so
> no need for you to repost them.
No objection. I never liked the "slot" reference but was trying to
remain consistent with what was there before. If I remember correctly
there's a bunch of places in the kernel that use slot as well.
Thanks,
Logan
next prev parent reply other threads:[~2018-08-09 21:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 16:18 [PATCH v8 0/4] Add parameter for disabling ACS redirection for P2P Logan Gunthorpe
2018-07-30 16:18 ` [PATCH v8 1/4] PCI: Make specifying PCI devices in kernel parameters reusable Logan Gunthorpe
2018-08-09 21:15 ` Bjorn Helgaas
2018-08-09 21:18 ` Logan Gunthorpe [this message]
2018-07-30 16:18 ` [PATCH v8 2/4] PCI: Allow specifying devices using a base bus and path of devfns Logan Gunthorpe
2018-07-30 16:18 ` [PATCH v8 3/4] PCI: Introduce disable_acs_redir quirk Logan Gunthorpe
2018-08-09 21:17 ` Bjorn Helgaas
2018-08-09 21:21 ` Logan Gunthorpe
2018-07-30 16:18 ` [PATCH v8 4/4] PCI: Introduce the disable_acs_redir parameter Logan Gunthorpe
2018-07-30 16:41 ` [PATCH v8 0/4] Add parameter for disabling ACS redirection for P2P Logan Gunthorpe
2018-08-09 23:03 ` Bjorn Helgaas
2018-08-09 23:27 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512aa96e-1c31-ecbd-88c7-a5e417d533ba@deltatee.com \
--to=logang@deltatee.com \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=frederic@kernel.org \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=jglisse@redhat.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sbates@raithlin.com \
--cc=tglx@linutronix.de \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).