From: Arnd Bergmann <arnd@arndb.de>
To: ksummit-discuss@lists.linuxfoundation.org
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
"Levin, Alexander" <alexander.levin@verizon.com>,
Joe Perches <joe@perches.com>,
Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <levinsasha928@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ?
Date: Mon, 29 Aug 2016 11:01:08 +0200 [thread overview]
Message-ID: <5149968.BflLUdM3a8@wuerfel> (raw)
In-Reply-To: <20160829071515.wqlpjccq7a3vk7u6@piout.net>
On Monday, August 29, 2016 9:15:15 AM CEST Alexandre Belloni wrote:
> >
> > commiter commits issues
> > arnd 858 2155
> > axboe 53 22
> > corbet 15 9
> > davem 55 81
> > grant.likely 2 0
> > gregkh 38 46
> > hch 393 581
> > James.Bottomley 15 15
> > martin.petersen 18 20
> > mchehab 678 1042
> > mgorman 104 256
> > mingo 58 192
> > paulmck 176 68
> > peterz 226 511
> > rostedt 123 178
> > shuahkh 53 6
> > tglx 200 287
> > torvalds 64 89
> > tytso 37 77
> > viro 350 256
> >
> > And for the last 10,000 commits in the log, that script has observed 10,783 issues.
> >
> > It'll be interesting to hear from these people about their view of checkpatch, but IMO when on average there are more issues than commits I can suggest two possible causes:
> >
> > 1. People are used to ignore checkpatch warnings.
> > 2. People aren't using checkpatch.
> >
>
> Well, Arnd is used to move around old code when refactoring. As the code
> just moves, he rarely solves checkpatch issues when doing so which is
> the right thing to do.
I don't find checkpatch.pl overly useful for my own patches and rarely
run it. I looked over the last few hundred commits and found that almost
all the warnings were for:
- having overly long lines in commit messages when I quoted a long
compiler warning. I generally don't wrap those to make it easier to
search for the warnings in the git history
- missing the word "commit" before a reference to another changeset
in full-text. I'll change that in the future if that makes people
happy, but it doesn't seem important.
- existing style issues that I did not fix when fixing a bug. In many
cases I find it better not to change coding style while fixing
a bug, but there are other cases in which I do.
Arnd
next prev parent reply other threads:[~2016-08-29 9:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 20:40 checkkpatch (in)sanity ? Joe Perches
2016-08-28 1:06 ` Levin, Alexander
2016-08-28 1:42 ` Joe Perches
2016-08-28 2:20 ` Joe Perches
2016-08-28 2:47 ` Levin, Alexander
2016-08-28 17:15 ` Joe Perches
2016-08-28 17:59 ` Greg KH
2016-08-28 22:37 ` Levin, Alexander
2016-08-28 23:20 ` Joe Perches
2016-08-29 2:22 ` Levin, Alexander
2016-08-29 8:20 ` Christoph Hellwig
2016-08-29 7:15 ` [Ksummit-discuss] " Alexandre Belloni
2016-08-29 9:01 ` Arnd Bergmann [this message]
2016-08-29 12:47 ` Joe Perches
2016-08-29 17:16 ` Josh Triplett
2016-08-29 17:41 ` Joe Perches
2016-08-29 17:46 ` Luck, Tony
2016-08-29 18:01 ` Joe Perches
2016-08-29 18:47 ` Joe Perches
2016-08-29 19:08 ` Josh Triplett
2016-08-29 21:07 ` Arnd Bergmann
2016-08-29 11:15 ` Kalle Valo
2016-08-29 12:30 ` Joe Perches
2016-08-29 18:01 ` Kalle Valo
2016-08-29 19:00 ` Joe Perches
2016-08-29 21:00 ` [Ksummit-discuss] " Arnd Bergmann
2016-08-28 7:56 ` Alexey Dobriyan
2016-08-28 9:59 ` Julia Lawall
2016-08-28 19:52 ` Joe Perches
2016-08-28 20:35 ` Jiri Kosina
2016-08-28 21:24 ` Dennis Kaarsemaker
2016-08-28 21:57 ` Joe Perches
2016-08-29 19:06 ` Dan Carpenter
2016-08-29 19:10 ` Josh Triplett
2016-08-29 19:17 ` Dan Carpenter
2016-08-29 19:34 ` Joe Perches
2016-08-29 19:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149968.BflLUdM3a8@wuerfel \
--to=arnd@arndb.de \
--cc=alexander.levin@verizon.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).