* [Suggestion] ARM64:kernel: compiling issue for early_console.
@ 2013-03-27 11:44 Chen Gang
2013-03-27 11:55 ` Catalin Marinas
0 siblings, 1 reply; 12+ messages in thread
From: Chen Gang @ 2013-03-27 11:44 UTC (permalink / raw)
To: catalin.marinas, Will Deacon, marc.zyngier, anup.patel, Arnd Bergmann
Cc: linux-arm-kernel, linux-kernel
Hello Maintainers:
it is a compiling issue for early_console.
the make command:
make V=1 EXTRA_CFLAGS=-W ARCH=arm64 allmodconfig
make V=1 EXTRA_CFLAGS=-W ARCH=arm64 menuconfig
set aarch64-linux-gnu- for tool chain prefix.
make V=1 EXTRA_CFLAGS=-W ARCH=arm64
the error message:
arch/arm64/kernel/early_printk.c: At top level:
arch/arm64/kernel/early_printk.c:98:23: error: conflicting types for ‘early_console’
In file included from arch/arm64/kernel/early_printk.c:20:0:
include/linux/console.h:145:24: note: previous declaration of ‘early_console’ was here
make[1]: *** [arch/arm64/kernel/early_printk.o] Error 1
make: *** [arch/arm64/kernel] Error 2
I guess, we can just reference the 32-bit arm implementation is ok.
(it is in arch/arm/kernel/early_printk.c line 32..44)
if really just like what I guess, may I send related patch for it ?
:-)
gchen.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Suggestion] ARM64:kernel: compiling issue for early_console. 2013-03-27 11:44 [Suggestion] ARM64:kernel: compiling issue for early_console Chen Gang @ 2013-03-27 11:55 ` Catalin Marinas 2013-03-27 12:02 ` Chen Gang 0 siblings, 1 reply; 12+ messages in thread From: Catalin Marinas @ 2013-03-27 11:55 UTC (permalink / raw) To: Chen Gang Cc: Will Deacon, Marc Zyngier, anup.patel, Arnd Bergmann, linux-arm-kernel, linux-kernel On Wed, Mar 27, 2013 at 11:44:03AM +0000, Chen Gang wrote: > the error message: > arch/arm64/kernel/early_printk.c: At top level: > arch/arm64/kernel/early_printk.c:98:23: error: conflicting types for ‘early_console’ > In file included from arch/arm64/kernel/early_printk.c:20:0: > include/linux/console.h:145:24: note: previous declaration of ‘early_console’ was here > make[1]: *** [arch/arm64/kernel/early_printk.o] Error 1 > make: *** [arch/arm64/kernel] Error 2 Is this in linux-next? Mainline seems fine. I saw some patches from tglx on unifying the various early printk implementations, though not sure whether it's those patches causing it (in which case arm64 needs to be updated as well). -- Catalin ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Suggestion] ARM64:kernel: compiling issue for early_console. 2013-03-27 11:55 ` Catalin Marinas @ 2013-03-27 12:02 ` Chen Gang 2013-04-03 8:13 ` Chen Gang 0 siblings, 1 reply; 12+ messages in thread From: Chen Gang @ 2013-03-27 12:02 UTC (permalink / raw) To: Catalin Marinas Cc: Will Deacon, Marc Zyngier, anup.patel, Arnd Bergmann, linux-arm-kernel, linux-kernel On 2013年03月27日 19:55, Catalin Marinas wrote: > On Wed, Mar 27, 2013 at 11:44:03AM +0000, Chen Gang wrote: >> > the error message: >> > arch/arm64/kernel/early_printk.c: At top level: >> > arch/arm64/kernel/early_printk.c:98:23: error: conflicting types for ‘early_console’ >> > In file included from arch/arm64/kernel/early_printk.c:20:0: >> > include/linux/console.h:145:24: note: previous declaration of ‘early_console’ was here >> > make[1]: *** [arch/arm64/kernel/early_printk.o] Error 1 >> > make: *** [arch/arm64/kernel] Error 2 > Is this in linux-next? Mainline seems fine. yes, it is in next-20130326 at least :-) > > I saw some patches from tglx on unifying the various early printk > implementations, though not sure whether it's those patches causing it > (in which case arm64 needs to be updated as well). maybe, but we need check the details to prove it :-) thanks. -- Chen Gang Asianux Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Suggestion] ARM64:kernel: compiling issue for early_console. 2013-03-27 12:02 ` Chen Gang @ 2013-04-03 8:13 ` Chen Gang 2013-04-03 11:39 ` Christopher Covington 0 siblings, 1 reply; 12+ messages in thread From: Chen Gang @ 2013-04-03 8:13 UTC (permalink / raw) To: Catalin Marinas Cc: Will Deacon, Marc Zyngier, anup.patel, Arnd Bergmann, linux-arm-kernel, linux-kernel Hello Maintainers: it seems, this issue still exists in next-20130402. have you already fixed it in another tree ? if really no one fix it within this week, I should try (since I find it). thanks. gchen. On 2013年03月27日 20:02, Chen Gang wrote: > On 2013年03月27日 19:55, Catalin Marinas wrote: >> On Wed, Mar 27, 2013 at 11:44:03AM +0000, Chen Gang wrote: >>>> the error message: >>>> arch/arm64/kernel/early_printk.c: At top level: >>>> arch/arm64/kernel/early_printk.c:98:23: error: conflicting types for ‘early_console’ >>>> In file included from arch/arm64/kernel/early_printk.c:20:0: >>>> include/linux/console.h:145:24: note: previous declaration of ‘early_console’ was here >>>> make[1]: *** [arch/arm64/kernel/early_printk.o] Error 1 >>>> make: *** [arch/arm64/kernel] Error 2 >> Is this in linux-next? Mainline seems fine. > > yes, it is in next-20130326 at least :-) > >> >> I saw some patches from tglx on unifying the various early printk >> implementations, though not sure whether it's those patches causing it >> (in which case arm64 needs to be updated as well). > > maybe, but we need check the details to prove it :-) > > > thanks. > -- Chen Gang Asianux Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Suggestion] ARM64:kernel: compiling issue for early_console. 2013-04-03 8:13 ` Chen Gang @ 2013-04-03 11:39 ` Christopher Covington 2013-04-03 13:00 ` Chen Gang 0 siblings, 1 reply; 12+ messages in thread From: Christopher Covington @ 2013-04-03 11:39 UTC (permalink / raw) To: Chen Gang Cc: Catalin Marinas, anup.patel, Arnd Bergmann, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel Hi Chen, On 04/03/2013 04:13 AM, Chen Gang wrote: > Hello Maintainers: > > it seems, this issue still exists in next-20130402. > > have you already fixed it in another tree ? Maybe somebody else does have a fix, but Catalin mentioned he was going on vacation for two weeks on March 28th in "[GIT PULL] Preparatory GIC patches for arm64 support". > if really no one fix it within this week, I should try (since I find it). I'm sure a fix would be appreciated. > On 2013年03月27日 20:02, Chen Gang wrote: >> On 2013年03月27日 19:55, Catalin Marinas wrote: >>> On Wed, Mar 27, 2013 at 11:44:03AM +0000, Chen Gang wrote: >>>>> the error message: >>>>> arch/arm64/kernel/early_printk.c: At top level: >>>>> arch/arm64/kernel/early_printk.c:98:23: error: conflicting types for ‘early_console’ >>>>> In file included from arch/arm64/kernel/early_printk.c:20:0: >>>>> include/linux/console.h:145:24: note: previous declaration of ‘early_console’ was here >>>>> make[1]: *** [arch/arm64/kernel/early_printk.o] Error 1 >>>>> make: *** [arch/arm64/kernel] Error 2 >>> Is this in linux-next? Mainline seems fine. >> >> yes, it is in next-20130326 at least :-) >> >>> >>> I saw some patches from tglx on unifying the various early printk >>> implementations, though not sure whether it's those patches causing it >>> (in which case arm64 needs to be updated as well). I looked briefly and wasn't able to find this patchset. Regards, Christopher -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Suggestion] ARM64:kernel: compiling issue for early_console. 2013-04-03 11:39 ` Christopher Covington @ 2013-04-03 13:00 ` Chen Gang 2013-04-17 9:10 ` Chen Gang 0 siblings, 1 reply; 12+ messages in thread From: Chen Gang @ 2013-04-03 13:00 UTC (permalink / raw) To: Christopher Covington Cc: Catalin Marinas, anup.patel, Arnd Bergmann, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel On 2013年04月03日 19:39, Christopher Covington wrote: > Maybe somebody else does have a fix, but Catalin mentioned he was going on > vacation for two weeks on March 28th in "[GIT PULL] Preparatory GIC patches > for arm64 support". > ok, I can wait. >> > if really no one fix it within this week, I should try (since I find it). > I'm sure a fix would be appreciated. > ok, thanks. I prefer to wait (at least for the end of Catalin's vacation). >> > On 2013年03月27日 20:02, Chen Gang wrote: >>> >> On 2013年03月27日 19:55, Catalin Marinas wrote: >>>> >>> >>>> >>> I saw some patches from tglx on unifying the various early printk >>>> >>> implementations, though not sure whether it's those patches causing it >>>> >>> (in which case arm64 needs to be updated as well). > I looked briefly and wasn't able to find this patchset. ok, thank for your results. -- Chen Gang Asianux Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Suggestion] ARM64:kernel: compiling issue for early_console. 2013-04-03 13:00 ` Chen Gang @ 2013-04-17 9:10 ` Chen Gang 2013-04-19 10:53 ` [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console Chen Gang 0 siblings, 1 reply; 12+ messages in thread From: Chen Gang @ 2013-04-17 9:10 UTC (permalink / raw) To: Christopher Covington, Catalin Marinas Cc: anup.patel, Arnd Bergmann, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel On 2013年04月03日 21:00, Chen Gang wrote: > On 2013年04月03日 19:39, Christopher Covington wrote: >> Maybe somebody else does have a fix, but Catalin mentioned he was going on >> vacation for two weeks on March 28th in "[GIT PULL] Preparatory GIC patches >> for arm64 support". >> > ok, I can wait. > could you have time to fix it ? (if have no time, I should fix it). thanks. >>>> if really no one fix it within this week, I should try (since I find it). >> I'm sure a fix would be appreciated. >> > > ok, thanks. I prefer to wait (at least for the end of Catalin's vacation). > > >>>> On 2013年03月27日 20:02, Chen Gang wrote: >>>>>> On 2013年03月27日 19:55, Catalin Marinas wrote: >>>>>>>> >>>>>>>> I saw some patches from tglx on unifying the various early printk >>>>>>>> implementations, though not sure whether it's those patches causing it >>>>>>>> (in which case arm64 needs to be updated as well). >> I looked briefly and wasn't able to find this patchset. > > ok, thank for your results. > > -- Chen Gang Asianux Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console 2013-04-17 9:10 ` Chen Gang @ 2013-04-19 10:53 ` Chen Gang 2013-04-19 12:15 ` Arnd Bergmann 2013-04-19 12:31 ` Catalin Marinas 0 siblings, 2 replies; 12+ messages in thread From: Chen Gang @ 2013-04-19 10:53 UTC (permalink / raw) To: Christopher Covington, Catalin Marinas Cc: anup.patel, Arnd Bergmann, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel when compiling with allmodconfig. early_console is already defined as an extern global pointer. need let it point to the object which we intend to (like ARM32 done). Signed-off-by: Chen Gang <gang.chen@asianux.com> --- arch/arm64/kernel/early_printk.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/early_printk.c b/arch/arm64/kernel/early_printk.c index ac974f4..fbb6e18 100644 --- a/arch/arm64/kernel/early_printk.c +++ b/arch/arm64/kernel/early_printk.c @@ -95,7 +95,7 @@ static void early_write(struct console *con, const char *s, unsigned n) } } -static struct console early_console = { +static struct console early_console_dev = { .name = "earlycon", .write = early_write, .flags = CON_PRINTBUFFER | CON_BOOT, @@ -145,7 +145,8 @@ static int __init setup_early_printk(char *buf) early_base = early_io_map(paddr, EARLYCON_IOBASE); printch = match->printch; - register_console(&early_console); + early_console = &early_console_dev; + register_console(&early_console_dev); return 0; } -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console 2013-04-19 10:53 ` [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console Chen Gang @ 2013-04-19 12:15 ` Arnd Bergmann 2013-04-20 1:55 ` Chen Gang 2013-04-19 12:31 ` Catalin Marinas 1 sibling, 1 reply; 12+ messages in thread From: Arnd Bergmann @ 2013-04-19 12:15 UTC (permalink / raw) To: Chen Gang Cc: Christopher Covington, Catalin Marinas, anup.patel, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel On Friday 19 April 2013, Chen Gang wrote: > when compiling with allmodconfig. > early_console is already defined as an extern global pointer. > > need let it point to the object which we intend to (like ARM32 done). > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> Acked-by: Arnd Bergmann <arnd@arndb.de> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console 2013-04-19 12:15 ` Arnd Bergmann @ 2013-04-20 1:55 ` Chen Gang 0 siblings, 0 replies; 12+ messages in thread From: Chen Gang @ 2013-04-20 1:55 UTC (permalink / raw) To: Arnd Bergmann Cc: Christopher Covington, Catalin Marinas, anup.patel, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel On 2013年04月19日 20:15, Arnd Bergmann wrote: > On Friday 19 April 2013, Chen Gang wrote: >> > when compiling with allmodconfig. >> > early_console is already defined as an extern global pointer. >> > >> > need let it point to the object which we intend to (like ARM32 done). >> > >> > >> > Signed-off-by: Chen Gang <gang.chen@asianux.com> > Acked-by: Arnd Bergmann <arnd@arndb.de> > > thanks -- Chen Gang Asianux Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console 2013-04-19 10:53 ` [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console Chen Gang 2013-04-19 12:15 ` Arnd Bergmann @ 2013-04-19 12:31 ` Catalin Marinas 2013-04-20 1:54 ` Chen Gang 1 sibling, 1 reply; 12+ messages in thread From: Catalin Marinas @ 2013-04-19 12:31 UTC (permalink / raw) To: Chen Gang Cc: Christopher Covington, anup.patel, Arnd Bergmann, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel On Fri, Apr 19, 2013 at 11:53:07AM +0100, Chen Gang wrote: > when compiling with allmodconfig. > early_console is already defined as an extern global pointer. > > need let it point to the object which we intend to (like ARM32 done). > > > Signed-off-by: Chen Gang <gang.chen@asianux.com> Thanks for the patch. -- Catalin ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console 2013-04-19 12:31 ` Catalin Marinas @ 2013-04-20 1:54 ` Chen Gang 0 siblings, 0 replies; 12+ messages in thread From: Chen Gang @ 2013-04-20 1:54 UTC (permalink / raw) To: Catalin Marinas Cc: Christopher Covington, anup.patel, Arnd Bergmann, Marc Zyngier, Will Deacon, linux-kernel, linux-arm-kernel On 2013年04月19日 20:31, Catalin Marinas wrote: > On Fri, Apr 19, 2013 at 11:53:07AM +0100, Chen Gang wrote: >> when compiling with allmodconfig. >> early_console is already defined as an extern global pointer. >> >> need let it point to the object which we intend to (like ARM32 done). >> >> >> Signed-off-by: Chen Gang <gang.chen@asianux.com> > > Thanks for the patch. > :-) -- Chen Gang Asianux Corporation ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-04-20 1:56 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-03-27 11:44 [Suggestion] ARM64:kernel: compiling issue for early_console Chen Gang 2013-03-27 11:55 ` Catalin Marinas 2013-03-27 12:02 ` Chen Gang 2013-04-03 8:13 ` Chen Gang 2013-04-03 11:39 ` Christopher Covington 2013-04-03 13:00 ` Chen Gang 2013-04-17 9:10 ` Chen Gang 2013-04-19 10:53 ` [PATCH] ARM64: kernel: compiling issue, duplicate definition of early_console Chen Gang 2013-04-19 12:15 ` Arnd Bergmann 2013-04-20 1:55 ` Chen Gang 2013-04-19 12:31 ` Catalin Marinas 2013-04-20 1:54 ` Chen Gang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).