From: Lars-Peter Clausen <lars@metafoo.de>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
Cc: Doug Anderson <dianders@chromium.org>,
Jonathan Cameron <jic23@kernel.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
Olof Johansson <olof@lixom.net>,
Guenter Roeck <linux@roeck-us.net>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Rob Landley <rob@landley.net>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc
Date: Wed, 27 Mar 2013 19:40:52 +0100 [thread overview]
Message-ID: <51533D34.7020406@metafoo.de> (raw)
In-Reply-To: <CAHfPSqDLXD-T6__eF=d+U7Me953DqTgMXi=Jmx7LnHL+W-FLhQ@mail.gmail.com>
On 03/27/2013 07:35 PM, Naveen Krishna Ch wrote:
> On 13 March 2013 13:39, Doug Anderson <dianders@chromium.org> wrote:
>> The exynos ADC won't work without a regulator called "vdd" and a clock
>> called "adc". Document this fact in the device tree bindings.
>>
>> Signed-off-by: Doug Anderson <dianders@chromium.org>
> Reviewed-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>
> Lars, any update on this patch set. This change is required.
Uhm, looks fine to me. I'm sure Jonathan will pick it up :)
>> ---
>> Changes in v2: None
>>
>> Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> index f686378..96db940 100644
>> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-adc.txt
>> @@ -20,6 +20,9 @@ Required properties:
>> format is being dependent on which interrupt controller
>> the Samsung device uses.
>> - #io-channel-cells = <1>; As ADC has multiple outputs
>> +- clocks From common clock binding: handle to adc clock.
>> +- clock-names From common clock binding: Shall be "adc".
>> +- vdd-supply VDD input supply.
>>
>> Note: child nodes can be added for auto probing from device tree.
>>
>> @@ -31,6 +34,11 @@ adc: adc@12D10000 {
>> interrupts = <0 106 0>;
>> #io-channel-cells = <1>;
>> io-channel-ranges;
>> +
>> + clocks = <&clock 303>;
>> + clock-names = "adc";
>> +
>> + vdd-supply = <&buck5_reg>;
>> };
>>
>>
>> --
>> 1.8.1.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
>
>
> --
> Shine bright,
> (: Nav :)
next prev parent reply other threads:[~2013-03-27 18:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 23:13 [PATCH 0/4] Get exynos adc driver running on on exynos5250-snow Doug Anderson
2013-03-12 23:13 ` [PATCH 1/4] iio: adc: Document the regulator/clocks for exynos-adc Doug Anderson
2013-03-12 23:13 ` [PATCH 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc Doug Anderson
2013-03-12 23:13 ` [PATCH 3/4] ARM: dts: Add adc to exynos5250 device tree file Doug Anderson
2013-03-12 23:13 ` [PATCH 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow Doug Anderson
2013-03-13 20:39 ` [PATCH v2 0/4] This set of patches is based on Naveen Krishna Chatradhi's recent work Doug Anderson
2013-03-13 20:39 ` [PATCH v2 1/4] iio: adc: Document the regulator/clocks for exynos-adc Doug Anderson
2013-03-15 8:05 ` Naveen Krishna Ch
2013-03-27 18:35 ` Naveen Krishna Ch
2013-03-27 18:40 ` Lars-Peter Clausen [this message]
2013-03-27 18:46 ` Doug Anderson
2013-03-28 6:31 ` Jonathan Cameron
2013-03-29 9:36 ` Jonathan Cameron
2013-03-13 20:40 ` [PATCH v2 2/4] iio: adc: Add dt support for turning on the phy in exynos-adc Doug Anderson
2013-03-15 11:45 ` Naveen Krishna Ch
2013-03-15 15:43 ` Naveen Krishna Ch
2013-03-27 18:37 ` Naveen Krishna Ch
2013-03-27 18:44 ` Doug Anderson
2013-03-13 20:40 ` [PATCH v2 3/4] ARM: dts: Add adc to exynos5250 device tree file Doug Anderson
2013-03-15 15:45 ` Naveen Krishna Ch
2013-03-13 20:40 ` [PATCH v2 4/4] ARM: dts: Add adc and thermistors for exynos5250-snow Doug Anderson
2013-03-15 10:24 ` Naveen Krishna Ch
2013-03-15 15:42 ` Naveen Krishna Ch
2013-03-27 18:36 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51533D34.7020406@metafoo.de \
--to=lars@metafoo.de \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=grant.likely@secretlab.ca \
--cc=jic23@kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naveenkrishna.ch@gmail.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).