* [PATCH] fix:overlay: add missing header dependencies
@ 2016-08-28 5:02 Baoyou Xie
2016-08-29 10:41 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-08-28 5:02 UTC (permalink / raw)
To: bskeggs, airlied
Cc: dri-devel, nouveau, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
In fact, this function is declared in disp.h, so this patch
add missing header dependencies
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444ea..a79514d 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
#include "nouveau_connector.h"
#include "nouveau_display.h"
#include "nvreg.h"
-
+#include "disp.h"
struct nouveau_plane {
struct drm_plane base;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fix:overlay: add missing header dependencies
2016-08-28 5:02 [PATCH] fix:overlay: add missing header dependencies Baoyou Xie
@ 2016-08-29 10:41 ` Arnd Bergmann
0 siblings, 0 replies; 2+ messages in thread
From: Arnd Bergmann @ 2016-08-29 10:41 UTC (permalink / raw)
To: Baoyou Xie; +Cc: bskeggs, airlied, dri-devel, nouveau, linux-kernel, xie.baoyou
On Sunday, August 28, 2016 1:02:52 PM CEST Baoyou Xie wrote:
> We get 1 warning when build kernel with W=1:
> drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
>
> In fact, this function is declared in disp.h, so this patch
> add missing header dependencies
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
a few general notes:
- please use my arnd@arndb.de address on patch submissions, not the linaro
address.
- for the email subject lines, have a look at what the typical style
is for the file. "overlay:" is not a good name here because it's not
unique to the driver, so better use "drm/nouveau", which will also
get the attention of the right people.
- please drop the "fix:" prefix in the subject.
Arnd
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-29 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-28 5:02 [PATCH] fix:overlay: add missing header dependencies Baoyou Xie
2016-08-29 10:41 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).