From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Grant Likely <grant.likely@secretlab.ca>,
jimwall@q.com, brian@crystalfontz.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: fix irq_domain_add_simple usage
Date: Thu, 11 Apr 2013 09:50:11 +0200 [thread overview]
Message-ID: <51666B33.4070702@free-electrons.com> (raw)
In-Reply-To: <CACRpkdY=gJMCQ-qskDwXFg9cQH02+fZ00zU+=2cRdHE71cT9hw@mail.gmail.com>
Hi Linus,
Le 10/04/2013 22:54, Linus Walleij a écrit :
> On Wed, Apr 3, 2013 at 7:40 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
>
>> We actually have to pass chip as the host_data parameter of
>> irq_domain_add_simple() as later on, it is used to initialize chip_data
>> in pca953x_gpio_irq_map(). Failing to do so is leading to a NULL pointer
>> dereference after calling irq_data_get_irq_chip_data() in
>> pca953x_irq_mask(), pca953x_irq_unmask(), pca953x_irq_bus_lock(),
>> pca953x_irq_bus_sync_unlock() and pca953x_irq_set_type().
>>
>> Fixes regression introduced by commit
>> 0e8f2fdacf1d44651aa7e57063c76142d1f4988b (gpio: pca953x: use simple
>> irqdomain)
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>> ---
>>
>> This would probably be good to introduce that patch in the next 3.9 rc as the
>> regression leads to a lot of breakage (and cursing).
>
> OK patch applied let's see if I get it to Torvalds in time.
>
> Can I have some ACK from Maxime?
Sure,
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-04-11 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 17:40 [PATCH] gpio: pca953x: fix irq_domain_add_simple usage Alexandre Belloni
2013-04-09 21:34 ` Alexandre Belloni
2013-04-10 20:54 ` Linus Walleij
2013-04-11 7:50 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51666B33.4070702@free-electrons.com \
--to=maxime.ripard@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=brian@crystalfontz.com \
--cc=grant.likely@secretlab.ca \
--cc=jimwall@q.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).