From: Linus Walleij <linus.walleij@linaro.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
jimwall@q.com, brian@crystalfontz.com,
Maxime Ripard <maxime.ripard@free-electrons.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: fix irq_domain_add_simple usage
Date: Wed, 10 Apr 2013 22:54:31 +0200 [thread overview]
Message-ID: <CACRpkdY=gJMCQ-qskDwXFg9cQH02+fZ00zU+=2cRdHE71cT9hw@mail.gmail.com> (raw)
In-Reply-To: <1365010814-3263-1-git-send-email-alexandre.belloni@free-electrons.com>
On Wed, Apr 3, 2013 at 7:40 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> We actually have to pass chip as the host_data parameter of
> irq_domain_add_simple() as later on, it is used to initialize chip_data
> in pca953x_gpio_irq_map(). Failing to do so is leading to a NULL pointer
> dereference after calling irq_data_get_irq_chip_data() in
> pca953x_irq_mask(), pca953x_irq_unmask(), pca953x_irq_bus_lock(),
> pca953x_irq_bus_sync_unlock() and pca953x_irq_set_type().
>
> Fixes regression introduced by commit
> 0e8f2fdacf1d44651aa7e57063c76142d1f4988b (gpio: pca953x: use simple
> irqdomain)
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
>
> This would probably be good to introduce that patch in the next 3.9 rc as the
> regression leads to a lot of breakage (and cursing).
OK patch applied let's see if I get it to Torvalds in time.
Can I have some ACK from Maxime?
Yours,
Linus Walleij
next prev parent reply other threads:[~2013-04-10 20:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 17:40 [PATCH] gpio: pca953x: fix irq_domain_add_simple usage Alexandre Belloni
2013-04-09 21:34 ` Alexandre Belloni
2013-04-10 20:54 ` Linus Walleij [this message]
2013-04-11 7:50 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdY=gJMCQ-qskDwXFg9cQH02+fZ00zU+=2cRdHE71cT9hw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=brian@crystalfontz.com \
--cc=grant.likely@secretlab.ca \
--cc=jimwall@q.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).