* [PATCH 3/3] fsfreeze: use sb_start_write_killable instead of sb_start_write
@ 2013-04-13 10:38 Marco Stornelli
2013-04-15 12:00 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Marco Stornelli @ 2013-04-13 10:38 UTC (permalink / raw)
To: Linux FS Devel; +Cc: Linux Kernel, Al Viro, Jan Kara
Replace sb_start_write with sb_start_write_killable where
possible.
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
---
fs/open.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/open.c b/fs/open.c
index 8c74100..d621d76 100644
--- a/fs/open.c
+++ b/fs/open.c
@@ -182,7 +182,9 @@ static long do_sys_ftruncate(unsigned int fd, loff_t length, int small)
if (IS_APPEND(inode))
goto out_putf;
- sb_start_write(inode->i_sb);
+ error = sb_start_write_killable(inode->i_sb);
+ if (error < 0)
+ return error;
error = locks_verify_truncate(inode, f.file, length);
if (!error)
error = security_path_truncate(&f.file->f_path);
@@ -273,7 +275,9 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
if (!file->f_op->fallocate)
return -EOPNOTSUPP;
- sb_start_write(inode->i_sb);
+ ret = sb_start_write_killable(inode->i_sb);
+ if (ret < 0)
+ return ret;
ret = file->f_op->fallocate(file, mode, offset, len);
sb_end_write(inode->i_sb);
return ret;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/3] fsfreeze: use sb_start_write_killable instead of sb_start_write
2013-04-13 10:38 [PATCH 3/3] fsfreeze: use sb_start_write_killable instead of sb_start_write Marco Stornelli
@ 2013-04-15 12:00 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-04-15 12:00 UTC (permalink / raw)
To: Marco Stornelli; +Cc: Linux FS Devel, Linux Kernel, Al Viro, Jan Kara
On Sat 13-04-13 12:38:18, Marco Stornelli wrote:
> Replace sb_start_write with sb_start_write_killable where
> possible.
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
>
> Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
> ---
> fs/open.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fs/open.c b/fs/open.c
> index 8c74100..d621d76 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -182,7 +182,9 @@ static long do_sys_ftruncate(unsigned int fd, loff_t length, int small)
> if (IS_APPEND(inode))
> goto out_putf;
>
> - sb_start_write(inode->i_sb);
> + error = sb_start_write_killable(inode->i_sb);
> + if (error < 0)
> + return error;
> error = locks_verify_truncate(inode, f.file, length);
> if (!error)
> error = security_path_truncate(&f.file->f_path);
> @@ -273,7 +275,9 @@ int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
> if (!file->f_op->fallocate)
> return -EOPNOTSUPP;
>
> - sb_start_write(inode->i_sb);
> + ret = sb_start_write_killable(inode->i_sb);
> + if (ret < 0)
> + return ret;
> ret = file->f_op->fallocate(file, mode, offset, len);
> sb_end_write(inode->i_sb);
> return ret;
> --
> 1.7.3.4
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-16 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-13 10:38 [PATCH 3/3] fsfreeze: use sb_start_write_killable instead of sb_start_write Marco Stornelli
2013-04-15 12:00 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).