* [PATCH] mm: fix build warning about kernel_physical_mapping_remove()
@ 2013-04-17 7:15 Yijing Wang
[not found] ` <20130417072214.GA25283@hacker.(null)>
0 siblings, 1 reply; 2+ messages in thread
From: Yijing Wang @ 2013-04-17 7:15 UTC (permalink / raw)
To: Andrew Morton
Cc: linux-kernel, linux-mm, Hanjun Guo, jiang.liu, Yijing Wang,
Tang Chen, Wen Congyang
If CONFIG_MEMORY_HOTREMOVE is not set, a build warning about
"warning: ‘kernel_physical_mapping_remove’ defined but not used"
report.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Tang Chen <tangchen@cn.fujitsu.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
---
arch/x86/mm/init_64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 474e28f..dafdeb2 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -1019,6 +1019,7 @@ void __ref vmemmap_free(struct page *memmap, unsigned long nr_pages)
remove_pagetable(start, end, false);
}
+#ifdef CONFIG_MEMORY_HOTREMOVE
static void __meminit
kernel_physical_mapping_remove(unsigned long start, unsigned long end)
{
@@ -1028,7 +1029,6 @@ kernel_physical_mapping_remove(unsigned long start, unsigned long end)
remove_pagetable(start, end, true);
}
-#ifdef CONFIG_MEMORY_HOTREMOVE
int __ref arch_remove_memory(u64 start, u64 size)
{
unsigned long start_pfn = start >> PAGE_SHIFT;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mm: fix build warning about kernel_physical_mapping_remove()
[not found] ` <20130417072214.GA25283@hacker.(null)>
@ 2013-04-17 7:38 ` Yijing Wang
0 siblings, 0 replies; 2+ messages in thread
From: Yijing Wang @ 2013-04-17 7:38 UTC (permalink / raw)
To: Wanpeng Li
Cc: Andrew Morton, linux-kernel, linux-mm, Hanjun Guo, jiang.liu,
Tang Chen, Wen Congyang
On 2013/4/17 15:22, Wanpeng Li wrote:
> On Wed, Apr 17, 2013 at 03:15:58PM +0800, Yijing Wang wrote:
>> If CONFIG_MEMORY_HOTREMOVE is not set, a build warning about
>> "warning: ‘kernel_physical_mapping_remove’ defined but not used"
>> report.
>>
>
> This has already been fixed by Tang Chen.
> http://marc.info/?l=linux-mm&m=136614697618243&w=2
OK, I will drop this one, thanks!
>
>> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
>> Cc: Tang Chen <tangchen@cn.fujitsu.com>
>> Cc: Wen Congyang <wency@cn.fujitsu.com>
>> ---
>> arch/x86/mm/init_64.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
>> index 474e28f..dafdeb2 100644
>> --- a/arch/x86/mm/init_64.c
>> +++ b/arch/x86/mm/init_64.c
>> @@ -1019,6 +1019,7 @@ void __ref vmemmap_free(struct page *memmap, unsigned long nr_pages)
>> remove_pagetable(start, end, false);
>> }
>>
>> +#ifdef CONFIG_MEMORY_HOTREMOVE
>> static void __meminit
>> kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> {
>> @@ -1028,7 +1029,6 @@ kernel_physical_mapping_remove(unsigned long start, unsigned long end)
>> remove_pagetable(start, end, true);
>> }
>>
>> -#ifdef CONFIG_MEMORY_HOTREMOVE
>> int __ref arch_remove_memory(u64 start, u64 size)
>> {
>> unsigned long start_pfn = start >> PAGE_SHIFT;
>> --
>> 1.7.1
>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-mm' in
>> the body to majordomo@kvack.org. For more info on Linux MM,
>> see: http://www.linux-mm.org/ .
>> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>
>
> .
>
--
Thanks!
Yijing
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-17 7:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-17 7:15 [PATCH] mm: fix build warning about kernel_physical_mapping_remove() Yijing Wang
[not found] ` <20130417072214.GA25283@hacker.(null)>
2013-04-17 7:38 ` Yijing Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).