linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] f2fs: Continue to mount after failing recovery
@ 2013-05-02 21:07 Chris Fries
  0 siblings, 0 replies; only message in thread
From: Chris Fries @ 2013-05-02 21:07 UTC (permalink / raw)
  To: c.fries, jason.hrycay, jaegeuk.kim, linux-f2fs-devel, linux-kernel


From: Chris Fries <C.Fries@motorola.com>

When unable to roll forward the journal, we shouldn't bail out and
not mount, we should continue to attempt the mount.  Bad recovery data
is likely unrecoverable at this point, and requiring the user to try
to mount again doesn't solve any issues.

Signed-off-by: Chris Fries <C.Fries@motorola.com>
Reviewed-by: Russell Knize <rknize2@motorola.com>
Reviewed-by: Jason Hrycay <jason.hrycay@motorola.com>
---
 fs/f2fs/super.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2643c49..d8f7ed3 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -649,10 +649,9 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 	/* recover fsynced data */
 	if (!test_opt(sbi, DISABLE_ROLL_FORWARD)) {
 		err = recover_fsync_data(sbi);
-		if (err) {
-			f2fs_msg(sb, KERN_ERR, "Failed to recover fsync data");
-			goto free_root_inode;
-		}
+		if (err)
+			f2fs_msg(sb, KERN_ERR,
+				"Cannot recover all fsync data, continue\n");
 	}
 
 	/* After POR, we can run background GC thread */
-- 
1.8.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-05-02 21:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-02 21:07 [PATCH v2 1/2] f2fs: Continue to mount after failing recovery Chris Fries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).