From: Randy Dunlap <rdunlap@infradead.org>
To: Simon Wood <simon@mungewell.org>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hid-steelseries fix led class build issue
Date: Thu, 02 May 2013 14:50:27 -0700 [thread overview]
Message-ID: <5182DFA3.3040707@infradead.org> (raw)
In-Reply-To: <1367476041-25760-1-git-send-email-simon@mungewell.org>
On 05/01/13 23:27, Simon Wood wrote:
> Fixes 'undefined reference' issue when hid-steelseries is built in,
> but led-class is a module.
> --
> drivers/built-in.o: In function `steelseries_srws1_remove':
> hid-steelseries.c:(.text+0x3b97a1): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `steelseries_srws1_probe':
> hid-steelseries.c:(.text+0x3b9c51): undefined reference to `led_classdev_register'
> hid-steelseries.c:(.text+0x3b9ce5): undefined reference to `led_classdev_register'
> hid-steelseries.c:(.text+0x3b9d4b): undefined reference to `led_classdev_unregister'
> --
>
> Patch allows LED control when led-class is built in, or both hid-steelseries
> _and_ led-class are both modules.
OK, that builds. Thanks.
Missing lines: your Signed-off-by:
and
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> drivers/hid/hid-steelseries.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c
> index 2ed995c..dbd5e2e 100644
> --- a/drivers/hid/hid-steelseries.c
> +++ b/drivers/hid/hid-steelseries.c
> @@ -19,7 +19,8 @@
> #include "usbhid/usbhid.h"
> #include "hid-ids.h"
>
> -#if defined(CONFIG_LEDS_CLASS) || defined(CONFIG_LEDS_CLASS_MODULE)
> +#if defined(CONFIG_LEDS_CLASS) || \
> + (defined(CONFIG_LEDS_CLASS_MODULE) && defined(CONFIG_HID_STEELSERIES_MODULE))
> #define SRWS1_NUMBER_LEDS 15
> struct steelseries_srws1_data {
> __u16 led_state;
> @@ -108,7 +109,8 @@ static __u8 steelseries_srws1_rdesc_fixed[] = {
> 0xC0 /* End Collection */
> };
>
> -#if defined(CONFIG_LEDS_CLASS) || defined(CONFIG_LEDS_CLASS_MODULE)
> +#if defined(CONFIG_LEDS_CLASS) || \
> + (defined(CONFIG_LEDS_CLASS_MODULE) && defined(CONFIG_HID_STEELSERIES_MODULE))
> static void steelseries_srws1_set_leds(struct hid_device *hdev, __u16 leds)
> {
> struct list_head *report_list = &hdev->report_enum[HID_OUTPUT_REPORT].report_list;
> @@ -371,7 +373,8 @@ MODULE_DEVICE_TABLE(hid, steelseries_srws1_devices);
> static struct hid_driver steelseries_srws1_driver = {
> .name = "steelseries_srws1",
> .id_table = steelseries_srws1_devices,
> -#if defined(CONFIG_LEDS_CLASS) || defined(CONFIG_LEDS_CLASS_MODULE)
> +#if defined(CONFIG_LEDS_CLASS) || \
> + (defined(CONFIG_LEDS_CLASS_MODULE) && defined(CONFIG_HID_STEELSERIES_MODULE))
> .probe = steelseries_srws1_probe,
> .remove = steelseries_srws1_remove,
> #endif
>
--
~Randy
next prev parent reply other threads:[~2013-05-02 21:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 8:37 linux-next: Tree for May 1 Stephen Rothwell
2013-05-01 11:22 ` Sedat Dilek
2013-05-01 17:59 ` linux-next: Tree for May 1 (media/usb/stk1160) Randy Dunlap
2013-05-01 19:28 ` Yann E. MORIN
2013-05-01 19:32 ` Randy Dunlap
2013-05-01 19:58 ` David Rientjes
2013-05-01 20:23 ` Randy Dunlap
2013-05-01 20:40 ` David Rientjes
2013-05-01 20:53 ` Yann E. MORIN
2013-05-01 20:58 ` Randy Dunlap
2013-05-02 14:52 ` Mauro Carvalho Chehab
2013-05-02 21:23 ` Randy Dunlap
2013-05-04 17:21 ` Splitting stk1160-ac97 as a module (Re: linux-next: Tree for May 1 (media/usb/stk1160)) Ezequiel Garcia
2013-05-04 19:59 ` Yann E. MORIN
2013-05-06 13:11 ` Ezequiel Garcia
2013-05-01 18:44 ` [PATCH -next] hid: fix hid-steelseries kconfig/build Randy Dunlap
2013-05-01 19:27 ` simon
2013-05-01 19:39 ` Randy Dunlap
2013-05-01 20:32 ` simon
2013-05-02 6:27 ` [PATCH] HID: hid-steelseries fix led class build issue Simon Wood
2013-05-02 21:50 ` Randy Dunlap [this message]
2013-05-02 21:58 ` David Rientjes
2013-05-03 1:43 ` [PATCH-V2] " Simon Wood
2013-05-03 8:27 ` Jiri Kosina
2013-05-02 6:30 ` [PATCH] " Simon Wood
2013-05-01 19:18 ` [PATCH -next] power: fix lp8788-charger kconfig & build Randy Dunlap
2013-05-01 23:04 ` Kim, Milo
2013-05-03 4:22 ` Anton Vorontsov
2013-05-01 19:27 ` [PATCH -next] staging: sep: fix driver build and kconfig Randy Dunlap
2013-05-02 7:37 ` linux-next: Tree for May 1 ZX
2013-05-02 7:46 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5182DFA3.3040707@infradead.org \
--to=rdunlap@infradead.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).