From: David Rientjes <rientjes@google.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Simon Wood <simon@mungewell.org>,
linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: hid-steelseries fix led class build issue
Date: Thu, 2 May 2013 14:58:32 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.02.1305021455260.941@chino.kir.corp.google.com> (raw)
In-Reply-To: <5182DFA3.3040707@infradead.org>
On Thu, 2 May 2013, Randy Dunlap wrote:
> > ---
> > drivers/hid/hid-steelseries.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c
> > index 2ed995c..dbd5e2e 100644
> > --- a/drivers/hid/hid-steelseries.c
> > +++ b/drivers/hid/hid-steelseries.c
> > @@ -19,7 +19,8 @@
> > #include "usbhid/usbhid.h"
> > #include "hid-ids.h"
> >
> > -#if defined(CONFIG_LEDS_CLASS) || defined(CONFIG_LEDS_CLASS_MODULE)
> > +#if defined(CONFIG_LEDS_CLASS) || \
> > + (defined(CONFIG_LEDS_CLASS_MODULE) && defined(CONFIG_HID_STEELSERIES_MODULE))
> > #define SRWS1_NUMBER_LEDS 15
> > struct steelseries_srws1_data {
> > __u16 led_state;
While we're working on getting a signed-off-by line, the clean way of
handling this is
#if IS_BUILTIN(CONFIG_LEDS_CLASS) || \
(IS_MODULE(CONFIG_LEDS_CLASS) && IS_MODULE(CONFIG_HID_STEELSERIES))
next prev parent reply other threads:[~2013-05-02 21:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 8:37 linux-next: Tree for May 1 Stephen Rothwell
2013-05-01 11:22 ` Sedat Dilek
2013-05-01 17:59 ` linux-next: Tree for May 1 (media/usb/stk1160) Randy Dunlap
2013-05-01 19:28 ` Yann E. MORIN
2013-05-01 19:32 ` Randy Dunlap
2013-05-01 19:58 ` David Rientjes
2013-05-01 20:23 ` Randy Dunlap
2013-05-01 20:40 ` David Rientjes
2013-05-01 20:53 ` Yann E. MORIN
2013-05-01 20:58 ` Randy Dunlap
2013-05-02 14:52 ` Mauro Carvalho Chehab
2013-05-02 21:23 ` Randy Dunlap
2013-05-04 17:21 ` Splitting stk1160-ac97 as a module (Re: linux-next: Tree for May 1 (media/usb/stk1160)) Ezequiel Garcia
2013-05-04 19:59 ` Yann E. MORIN
2013-05-06 13:11 ` Ezequiel Garcia
2013-05-01 18:44 ` [PATCH -next] hid: fix hid-steelseries kconfig/build Randy Dunlap
2013-05-01 19:27 ` simon
2013-05-01 19:39 ` Randy Dunlap
2013-05-01 20:32 ` simon
2013-05-02 6:27 ` [PATCH] HID: hid-steelseries fix led class build issue Simon Wood
2013-05-02 21:50 ` Randy Dunlap
2013-05-02 21:58 ` David Rientjes [this message]
2013-05-03 1:43 ` [PATCH-V2] " Simon Wood
2013-05-03 8:27 ` Jiri Kosina
2013-05-02 6:30 ` [PATCH] " Simon Wood
2013-05-01 19:18 ` [PATCH -next] power: fix lp8788-charger kconfig & build Randy Dunlap
2013-05-01 23:04 ` Kim, Milo
2013-05-03 4:22 ` Anton Vorontsov
2013-05-01 19:27 ` [PATCH -next] staging: sep: fix driver build and kconfig Randy Dunlap
2013-05-02 7:37 ` linux-next: Tree for May 1 ZX
2013-05-02 7:46 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1305021455260.941@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).