* https://lkml.org/lkml/2013/2/1/531 @ 2013-05-22 11:36 Smart Weblications GmbH - Florian Wiessner 2013-05-22 13:57 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 0 siblings, 1 reply; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 11:36 UTC (permalink / raw) To: davem, liquidhorse; +Cc: andy, fubar, LKML, stable, nikolay, vfalico, gregkh Hi, why is this patch still not backported to 3.4? I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? WHY IS THAT? ====== 3.4 Series ====== diff -uprN linux-3.4.28/drivers/net/bonding/bond_alb.c linux-3.4.28-patched/drivers/net/bonding/bond_alb.c --- linux-3.4.28/drivers/net/bonding/bond_alb.c 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bond_alb.c 2013-01-30 15:37:25.121708311 -0500 @@ -704,6 +704,12 @@ static struct slave *rlb_arp_xmit(struct struct arp_pkt *arp = arp_pkt(skb); struct slave *tx_slave = NULL; + /* Don't modify or load balance ARPs that do not originate locally + * (e.g.,arrive via a bridge). + */ + if (!bond_slave_has_mac(bond, arp->mac_src)) + return NULL; + if (arp->op_code == htons(ARPOP_REPLY)) { /* the arp must be sent on the selected * rx channel diff -uprN linux-3.4.28/drivers/net/bonding/bonding.h linux-3.4.28-patched/drivers/net/bonding/bonding.h --- linux-3.4.28/drivers/net/bonding/bonding.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bonding.h 2013-01-30 15:37:25.121708311 -0500 @@ -18,6 +18,7 @@ #include <linux/timer.h> #include <linux/proc_fs.h> #include <linux/if_bonding.h> +#include <linux/etherdevice.h> #include <linux/cpumask.h> #include <linux/in6.h> #include <linux/netpoll.h> @@ -450,6 +451,18 @@ static inline void bond_destroy_proc_dir } #endif +static inline struct slave *bond_slave_has_mac(struct bonding *bond, + const u8 *mac) +{ + int i = 0; + struct slave *tmp; + + bond_for_each_slave(bond, tmp, i) + if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr)) + return tmp; + + return NULL; +} /* exported from bond_main.c */ extern int bond_net_id; diff -uprN linux-3.4.28/include/linux/etherdevice.h linux-3.4.28-patched/include/linux/etherdevice.h --- linux-3.4.28/include/linux/etherdevice.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/include/linux/etherdevice.h 2013-01-30 15:37:25.121708311 -0500 @@ -277,4 +277,37 @@ static inline unsigned long compare_ethe #endif } +/** + * ether_addr_equal_64bits - Compare two Ethernet addresses + * @addr1: Pointer to an array of 8 bytes + * @addr2: Pointer to an other array of 8 bytes + * + * Compare two Ethernet addresses, returns true if equal, false otherwise. + * + * The function doesn't need any conditional branches and possibly uses + * word memory accesses on CPU allowing cheap unaligned memory reads. + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } + * + * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits. + */ + +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], + const u8 addr2[6+2]) +{ +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS + unsigned long fold = ((*(unsigned long *)addr1) ^ + (*(unsigned long *)addr2)); + + if (sizeof(fold) == 8) + return zap_last_2bytes(fold) == 0; + + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ + (*(unsigned long *)(addr2 + 4))); + return fold == 0; +#else + return ether_addr_equal(addr1, addr2); +#endif +} + + #endif /* _LINUX_ETHERDEVICE_H */ -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 11:36 https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 13:57 ` Greg KH 2013-05-22 16:16 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 0 siblings, 1 reply; 24+ messages in thread From: Greg KH @ 2013-05-22 13:57 UTC (permalink / raw) To: Smart Weblications GmbH - Florian Wiessner Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > Hi, > > > why is this patch still not backported to 3.4? > > I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? > > > WHY IS THAT? <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. </formletter> ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 13:57 ` https://lkml.org/lkml/2013/2/1/531 Greg KH @ 2013-05-22 16:16 ` Smart Weblications GmbH - Florian Wiessner 2013-05-22 16:23 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 0 siblings, 1 reply; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 16:16 UTC (permalink / raw) To: Greg KH; +Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico Hi, Am 22.05.2013 15:57, schrieb Greg KH: > On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: >> Hi, >> >> >> why is this patch still not backported to 3.4? >> >> I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? >> >> >> WHY IS THAT? > > <formletter> > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > </formletter> > I don't want to submit a patch - i wanted to know why this patch still is not in the kernel (it is afaics at least 6 months old!) -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 16:16 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 16:23 ` Greg KH 2013-05-22 18:16 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 0 siblings, 1 reply; 24+ messages in thread From: Greg KH @ 2013-05-22 16:23 UTC (permalink / raw) To: Smart Weblications GmbH - Florian Wiessner Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico On Wed, May 22, 2013 at 06:16:11PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > Am 22.05.2013 15:57, schrieb Greg KH: > > On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > >> Hi, > >> > >> why is this patch still not backported to 3.4? > >> > >> I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? > >> > >> WHY IS THAT? > > > > <formletter> > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > for how to do this properly. > > > > </formletter> > > > > > I don't want to submit a patch - i wanted to know why this patch still is not in > the kernel (it is afaics at least 6 months old!) Perhaps because it was not submitted properly as documented above? thanks, greg k-h ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 16:23 ` https://lkml.org/lkml/2013/2/1/531 Greg KH @ 2013-05-22 18:16 ` Smart Weblications GmbH - Florian Wiessner 2013-05-22 19:06 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 0 siblings, 1 reply; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 18:16 UTC (permalink / raw) To: Greg KH; +Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico Hi, Am 22.05.2013 18:23, schrieb Greg KH: > On Wed, May 22, 2013 at 06:16:11PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: >> Am 22.05.2013 15:57, schrieb Greg KH: >>> On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: >>>> Hi, >>>> >>>> why is this patch still not backported to 3.4? >>>> >>>> I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? >>>> >>>> WHY IS THAT? >>> >>> <formletter> >>> >>> This is not the correct way to submit patches for inclusion in the >>> stable kernel tree. Please read Documentation/stable_kernel_rules.txt >>> for how to do this properly. >>> >>> </formletter> >>> >> >> >> I don't want to submit a patch - i wanted to know why this patch still is not in >> the kernel (it is afaics at least 6 months old!) > > Perhaps because it was not submitted properly as documented above? > Well, i don't know. I have not written that patch, but tested and applied it against 3.4.36 where it worked fine. But i am unable to apply it to 3.4.46 (there are rejects if i try to apply it, obviously because there were changes in the meanwhile) - It would be cool if someone could tell if that patch is really needed anymore with 3.4.46. I am no C coder and only have little C experience, but i'd like to use this patch with current 3.4 stable Kernel or at least make sure that this patch is not needed anymore with current stable kernels... -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 18:16 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 19:06 ` Greg KH 2013-05-22 19:35 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 0 siblings, 1 reply; 24+ messages in thread From: Greg KH @ 2013-05-22 19:06 UTC (permalink / raw) To: Smart Weblications GmbH - Florian Wiessner Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico On Wed, May 22, 2013 at 08:16:25PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > Hi, > > > Am 22.05.2013 18:23, schrieb Greg KH: > > On Wed, May 22, 2013 at 06:16:11PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > >> Am 22.05.2013 15:57, schrieb Greg KH: > >>> On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > >>>> Hi, > >>>> > >>>> why is this patch still not backported to 3.4? > >>>> > >>>> I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? > >>>> > >>>> WHY IS THAT? > >>> > >>> <formletter> > >>> > >>> This is not the correct way to submit patches for inclusion in the > >>> stable kernel tree. Please read Documentation/stable_kernel_rules.txt > >>> for how to do this properly. > >>> > >>> </formletter> > >>> > >> > >> > >> I don't want to submit a patch - i wanted to know why this patch still is not in > >> the kernel (it is afaics at least 6 months old!) > > > > Perhaps because it was not submitted properly as documented above? > > > > Well, i don't know. I have not written that patch, but tested and applied it > against 3.4.36 where it worked fine. > > But i am unable to apply it to 3.4.46 (there are rejects if i try to apply it, > obviously because there were changes in the meanwhile) - It would be cool if > someone could tell if that patch is really needed anymore with 3.4.46. > > I am no C coder and only have little C experience, but i'd like to use this > patch with current 3.4 stable Kernel or at least make sure that this patch is > not needed anymore with current stable kernels... Why do you think that it is needed? And does it match up to a specific change that is already in Linus's tree? That is a requirement here. thanks, greg k-h ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 19:06 ` https://lkml.org/lkml/2013/2/1/531 Greg KH @ 2013-05-22 19:35 ` Smart Weblications GmbH - Florian Wiessner 2013-05-22 20:04 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 0 siblings, 1 reply; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 19:35 UTC (permalink / raw) To: Greg KH; +Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico Hi Greg, Am 22.05.2013 21:06, schrieb Greg KH:> On Wed, May 22, 2013 at 08:16:25PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: >> Hi, >> >> >> Am 22.05.2013 18:23, schrieb Greg KH: >>> On Wed, May 22, 2013 at 06:16:11PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: >>>> Am 22.05.2013 15:57, schrieb Greg KH: >>>>> On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: >>>>>> Hi, >>>>>> >>>>>> why is this patch still not backported to 3.4? >>>>>> >>>>>> I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ included? >>>>>> >>>>>> WHY IS THAT? >>>>> >>>>> <formletter> >>>>> >>>>> This is not the correct way to submit patches for inclusion in the >>>>> stable kernel tree. Please read Documentation/stable_kernel_rules.txt >>>>> for how to do this properly. >>>>> >>>>> </formletter> >>>>> >>>> >>>> >>>> I don't want to submit a patch - i wanted to know why this patch still is not in >>>> the kernel (it is afaics at least 6 months old!) >>> >>> Perhaps because it was not submitted properly as documented above? >>> >> >> Well, i don't know. I have not written that patch, but tested and applied it >> against 3.4.36 where it worked fine. >> >> But i am unable to apply it to 3.4.46 (there are rejects if i try to apply it, >> obviously because there were changes in the meanwhile) - It would be cool if >> someone could tell if that patch is really needed anymore with 3.4.46. >> >> I am no C coder and only have little C experience, but i'd like to use this >> patch with current 3.4 stable Kernel or at least make sure that this patch is >> not needed anymore with current stable kernels... > > Why do you think that it is needed? And does it match up to a specific > change that is already in Linus's tree? That is a requirement here. > It is needed, because without it (at least in 3.4.36) virtualized guests (kvm/qemu) are unable to use br0 (bridge) if the bridge uses a bond with mode 6 (balance-alb). https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ http://lkml.indiana.edu/hypermail/linux/kernel/1302.0/00539.html Thanks, -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 19:35 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 20:04 ` Greg KH 2013-05-22 21:26 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 0 siblings, 1 reply; 24+ messages in thread From: Greg KH @ 2013-05-22 20:04 UTC (permalink / raw) To: Smart Weblications GmbH - Florian Wiessner Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico On Wed, May 22, 2013 at 09:35:11PM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > Hi Greg, > > Am 22.05.2013 21:06, schrieb Greg KH:> On Wed, May 22, 2013 at 08:16:25PM +0200, > Smart Weblications GmbH - Florian Wiessner wrote: > >> Hi, > >> > >> > >> Am 22.05.2013 18:23, schrieb Greg KH: > >>> On Wed, May 22, 2013 at 06:16:11PM +0200, Smart Weblications GmbH - Florian > Wiessner wrote: > >>>> Am 22.05.2013 15:57, schrieb Greg KH: > >>>>> On Wed, May 22, 2013 at 01:36:09PM +0200, Smart Weblications GmbH - > Florian Wiessner wrote: > >>>>>> Hi, > >>>>>> > >>>>>> why is this patch still not backported to 3.4? > >>>>>> > >>>>>> I today tried 3.4.46 from kernel.org, but the patch STILL seems _NOT_ > included? > >>>>>> > >>>>>> WHY IS THAT? > >>>>> > >>>>> <formletter> > >>>>> > >>>>> This is not the correct way to submit patches for inclusion in the > >>>>> stable kernel tree. Please read Documentation/stable_kernel_rules.txt > >>>>> for how to do this properly. > >>>>> > >>>>> </formletter> > >>>>> > >>>> > >>>> > >>>> I don't want to submit a patch - i wanted to know why this patch still is > not in > >>>> the kernel (it is afaics at least 6 months old!) > >>> > >>> Perhaps because it was not submitted properly as documented above? > >>> > >> > >> Well, i don't know. I have not written that patch, but tested and applied it > >> against 3.4.36 where it worked fine. > >> > >> But i am unable to apply it to 3.4.46 (there are rejects if i try to apply it, > >> obviously because there were changes in the meanwhile) - It would be cool if > >> someone could tell if that patch is really needed anymore with 3.4.46. > >> > >> I am no C coder and only have little C experience, but i'd like to use this > >> patch with current 3.4 stable Kernel or at least make sure that this patch is > >> not needed anymore with current stable kernels... > > > > Why do you think that it is needed? And does it match up to a specific > > change that is already in Linus's tree? That is a requirement here. > > > > It is needed, because without it (at least in 3.4.36) virtualized guests > (kvm/qemu) are unable to use br0 (bridge) if the bridge uses a bond with mode 6 > (balance-alb). > > https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ Ok, that's what we need. Now, please cc: the developers / maintainers of that patch and ask them to have it included in the 3.4-stable kernel series. Then, if they agree, the network maintainer will pick it up and send it to me for inclusion. thanks, greg k-h ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 20:04 ` https://lkml.org/lkml/2013/2/1/531 Greg KH @ 2013-05-22 21:26 ` Smart Weblications GmbH - Florian Wiessner 2013-05-22 21:54 ` https://lkml.org/lkml/2013/2/1/531 Jay Vosburgh 2013-05-22 23:17 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 0 siblings, 2 replies; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 21:26 UTC (permalink / raw) To: Greg KH; +Cc: davem, liquidhorse, andy, fubar, LKML, stable, nikolay, vfalico Hi Greg, Am 22.05.2013 22:04, schrieb Greg KH: >> >> https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ > > Ok, that's what we need. > > Now, please cc: the developers / maintainers of that patch and ask them > to have it included in the 3.4-stable kernel series. > > Then, if they agree, the network maintainer will pick it up and send it > to me for inclusion. > i set committer David S. Miller <davem@davemloft.net> in cc already, but do not know the network maintainer... this seems to me that "Matthew O'Connor" <liquidhorse@gmail.com> sent this to netdev on 2013-02-01: http://lists.openwall.net/netdev/2013/02/01/86 but i couldn't find a trace of the patch in 3.4.36?! Instead, i read another try to get it backported fail: http://permalink.gmane.org/gmane.linux.network/264198 -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 21:26 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 21:54 ` Jay Vosburgh 2013-05-22 22:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 22:32 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-05-22 23:17 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 1 sibling, 2 replies; 24+ messages in thread From: Jay Vosburgh @ 2013-05-22 21:54 UTC (permalink / raw) To: f.wiessner Cc: Greg KH, davem, liquidhorse, andy, LKML, stable, nikolay, vfalico Smart Weblications GmbH - Florian Wiessner wrote: >Am 22.05.2013 22:04, schrieb Greg KH: > > >>> >>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ >> >> Ok, that's what we need. >> >> Now, please cc: the developers / maintainers of that patch and ask them >> to have it included in the 3.4-stable kernel series. >> >> Then, if they agree, the network maintainer will pick it up and send it >> to me for inclusion. >> > >i set committer David S. Miller <davem@davemloft.net> in cc already, but do not >know the network maintainer... > >this seems to me that "Matthew O'Connor" <liquidhorse@gmail.com> sent this to >netdev on 2013-02-01: > >http://lists.openwall.net/netdev/2013/02/01/86 > >but i couldn't find a trace of the patch in 3.4.36?! The patch in question here is in net-next; the commit is: commit 567b871e503316b0927e54a3d7c86d50b722d955 Author: zheng.li <zheng.x.li@oracle.com> Date: Tue Nov 27 23:57:04 2012 +0000 bonding: rlb mode of bond should not alter ARP originating via bridge The additional change in the backport from Matthew O'Connor (to add ether_addr_equal_64bits) appears to still be necessary for 3.4.46. Alternatively, the patch could utilize ether_addr_equal instead, to minimize the change set. Greg, do you have a preference there? Submissions for stable from networking normally go through Davem; I can check the patch and repost it to netdev against 3.4.46 if everybody is ok with that. -J --- -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 21:54 ` https://lkml.org/lkml/2013/2/1/531 Jay Vosburgh @ 2013-05-22 22:24 ` Smart Weblications GmbH - Florian Wiessner 2013-05-22 22:32 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 1 sibling, 0 replies; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 22:24 UTC (permalink / raw) To: Jay Vosburgh Cc: Greg KH, davem, liquidhorse, andy, LKML, stable, nikolay, vfalico Am 22.05.2013 23:54, schrieb Jay Vosburgh: > Smart Weblications GmbH - Florian Wiessner wrote: > >> Am 22.05.2013 22:04, schrieb Greg KH: >> >> >>>> >>>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ >>> >>> Ok, that's what we need. >>> >>> Now, please cc: the developers / maintainers of that patch and ask them >>> to have it included in the 3.4-stable kernel series. >>> >>> Then, if they agree, the network maintainer will pick it up and send it >>> to me for inclusion. >>> >> >> i set committer David S. Miller <davem@davemloft.net> in cc already, but do not >> know the network maintainer... >> >> this seems to me that "Matthew O'Connor" <liquidhorse@gmail.com> sent this to >> netdev on 2013-02-01: >> >> http://lists.openwall.net/netdev/2013/02/01/86 >> >> but i couldn't find a trace of the patch in 3.4.36?! > > The patch in question here is in net-next; the commit is: > > commit 567b871e503316b0927e54a3d7c86d50b722d955 > Author: zheng.li <zheng.x.li@oracle.com> > Date: Tue Nov 27 23:57:04 2012 +0000 > > bonding: rlb mode of bond should not alter ARP originating via bridge > > > The additional change in the backport from Matthew O'Connor (to > add ether_addr_equal_64bits) appears to still be necessary for 3.4.46. > Alternatively, the patch could utilize ether_addr_equal instead, to > minimize the change set. Greg, do you have a preference there? > > Submissions for stable from networking normally go through > Davem; I can check the patch and repost it to netdev against 3.4.46 if > everybody is ok with that. > i would be happy if someone could provide a patch that works against 3.4.46 thank you. -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 21:54 ` https://lkml.org/lkml/2013/2/1/531 Jay Vosburgh 2013-05-22 22:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-22 22:32 ` Greg KH 1 sibling, 0 replies; 24+ messages in thread From: Greg KH @ 2013-05-22 22:32 UTC (permalink / raw) To: Jay Vosburgh Cc: f.wiessner, davem, liquidhorse, andy, LKML, stable, nikolay, vfalico On Wed, May 22, 2013 at 02:54:57PM -0700, Jay Vosburgh wrote: > Smart Weblications GmbH - Florian Wiessner wrote: > > >Am 22.05.2013 22:04, schrieb Greg KH: > > > > > >>> > >>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ > >> > >> Ok, that's what we need. > >> > >> Now, please cc: the developers / maintainers of that patch and ask them > >> to have it included in the 3.4-stable kernel series. > >> > >> Then, if they agree, the network maintainer will pick it up and send it > >> to me for inclusion. > >> > > > >i set committer David S. Miller <davem@davemloft.net> in cc already, but do not > >know the network maintainer... > > > >this seems to me that "Matthew O'Connor" <liquidhorse@gmail.com> sent this to > >netdev on 2013-02-01: > > > >http://lists.openwall.net/netdev/2013/02/01/86 > > > >but i couldn't find a trace of the patch in 3.4.36?! > > The patch in question here is in net-next; the commit is: > > commit 567b871e503316b0927e54a3d7c86d50b722d955 > Author: zheng.li <zheng.x.li@oracle.com> > Date: Tue Nov 27 23:57:04 2012 +0000 > > bonding: rlb mode of bond should not alter ARP originating via bridge > > > The additional change in the backport from Matthew O'Connor (to > add ether_addr_equal_64bits) appears to still be necessary for 3.4.46. > Alternatively, the patch could utilize ether_addr_equal instead, to > minimize the change set. Greg, do you have a preference there? What ever matches upstream is best. > Submissions for stable from networking normally go through > Davem; I can check the patch and repost it to netdev against 3.4.46 if > everybody is ok with that. Yes, I need networking stable patches to come to me from David. thanks, greg k-h ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 21:26 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 21:54 ` https://lkml.org/lkml/2013/2/1/531 Jay Vosburgh @ 2013-05-22 23:17 ` Matthew O'Connor 2013-05-23 10:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-06-13 1:15 ` https://lkml.org/lkml/2013/2/1/531 Ben Hutchings 1 sibling, 2 replies; 24+ messages in thread From: Matthew O'Connor @ 2013-05-22 23:17 UTC (permalink / raw) To: f.wiessner Cc: Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li, andy This is the backported patch I submitted previously. Hopefully this time around it won't be too messed up, I'm using Thunderbird instead of the web interface. I have applied it successfully and without warnings against 3.4.46. It builds, but is otherwise untested beyond what I did when I originally submitted back in Feb. This patch applies only to the 3.4 series kernel, although with minor changes it will work for 3.0, 3.2, and 3.7. If you're interested, I can submit the other patches shortly. If this submission still does not conform to standards, please let me know where I went wrong. For what it's worth I dropped the patch contents directly into the email, but I can attach it instead if that would work better. [ Upstream commit 567b871e503316b0927e54a3d7c86d50b722d955 ] bonding: rlb mode of bond should not alter ARP originating via bridge Do not modify or load balance ARP packets passing through balance-alb mode (wherein the ARP did not originate locally, and arrived via a bridge). Modifying pass-through ARP replies causes an incorrect MAC address to be placed into the ARP packet, rendering peers unable to communicate with the actual destination from which the ARP reply originated. Load balancing pass-through ARP requests causes an entry to be created for the peer in the rlb table, and bond_alb_monitor will occasionally issue ARP updates to all peers in the table instrucing them as to which MAC address they should communicate with; this occurs when some event sets rx_ntt. In the bridged case, however, the MAC address used for the update would be the MAC of the slave, not the actual source MAC of the originating destination. This would render peers unable to communicate with the destinations beyond the bridge. Signed-off-by: Matthew O'Connor <liquidhorse@gmail.com> CC: Zheng Li <zheng.x.li@oracle.com> Cc: Jay Vosburgh <fubar@us.ibm.com> Cc: Andy Gospodarek <andy@greyhouse.net> Cc: "David S. Miller" <davem@davemloft.net> diff -uprN linux-3.4.28/drivers/net/bonding/bond_alb.c linux-3.4.28-patched/drivers/net/bonding/bond_alb.c --- linux-3.4.28/drivers/net/bonding/bond_alb.c 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bond_alb.c 2013-01-30 15:37:25.121708311 -0500 @@ -704,6 +704,12 @@ static struct slave *rlb_arp_xmit(struct struct arp_pkt *arp = arp_pkt(skb); struct slave *tx_slave = NULL; + /* Don't modify or load balance ARPs that do not originate locally + * (e.g.,arrive via a bridge). + */ + if (!bond_slave_has_mac(bond, arp->mac_src)) + return NULL; + if (arp->op_code == htons(ARPOP_REPLY)) { /* the arp must be sent on the selected * rx channel diff -uprN linux-3.4.28/drivers/net/bonding/bonding.h linux-3.4.28-patched/drivers/net/bonding/bonding.h --- linux-3.4.28/drivers/net/bonding/bonding.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bonding.h 2013-01-30 15:37:25.121708311 -0500 @@ -18,6 +18,7 @@ #include <linux/timer.h> #include <linux/proc_fs.h> #include <linux/if_bonding.h> +#include <linux/etherdevice.h> #include <linux/cpumask.h> #include <linux/in6.h> #include <linux/netpoll.h> @@ -450,6 +451,18 @@ static inline void bond_destroy_proc_dir } #endif +static inline struct slave *bond_slave_has_mac(struct bonding *bond, + const u8 *mac) +{ + int i = 0; + struct slave *tmp; + + bond_for_each_slave(bond, tmp, i) + if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr)) + return tmp; + + return NULL; +} /* exported from bond_main.c */ extern int bond_net_id; diff -uprN linux-3.4.28/include/linux/etherdevice.h linux-3.4.28-patched/include/linux/etherdevice.h --- linux-3.4.28/include/linux/etherdevice.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/include/linux/etherdevice.h 2013-01-30 15:37:25.121708311 -0500 @@ -277,4 +277,37 @@ static inline unsigned long compare_ethe #endif } +/** + * ether_addr_equal_64bits - Compare two Ethernet addresses + * @addr1: Pointer to an array of 8 bytes + * @addr2: Pointer to an other array of 8 bytes + * + * Compare two Ethernet addresses, returns true if equal, false otherwise. + * + * The function doesn't need any conditional branches and possibly uses + * word memory accesses on CPU allowing cheap unaligned memory reads. + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } + * + * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits. + */ + +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], + const u8 addr2[6+2]) +{ +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS + unsigned long fold = ((*(unsigned long *)addr1) ^ + (*(unsigned long *)addr2)); + + if (sizeof(fold) == 8) + return zap_last_2bytes(fold) == 0; + + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ + (*(unsigned long *)(addr2 + 4))); + return fold == 0; +#else + return ether_addr_equal(addr1, addr2); +#endif +} + + #endif /* _LINUX_ETHERDEVICE_H */ On 05/22/2013 05:26 PM, Smart Weblications GmbH - Florian Wiessner wrote: > Hi Greg, > > > Am 22.05.2013 22:04, schrieb Greg KH: > > >>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ >> Ok, that's what we need. >> >> Now, please cc: the developers / maintainers of that patch and ask them >> to have it included in the 3.4-stable kernel series. >> >> Then, if they agree, the network maintainer will pick it up and send it >> to me for inclusion. >> > i set committer David S. Miller <davem@davemloft.net> in cc already, but do not > know the network maintainer... > > this seems to me that "Matthew O'Connor" <liquidhorse@gmail.com> sent this to > netdev on 2013-02-01: > > http://lists.openwall.net/netdev/2013/02/01/86 > > but i couldn't find a trace of the patch in 3.4.36?! > > Instead, i read another try to get it backported fail: > > http://permalink.gmane.org/gmane.linux.network/264198 > > > > > > ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 23:17 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor @ 2013-05-23 10:24 ` Smart Weblications GmbH - Florian Wiessner 2013-05-23 12:35 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-05-23 12:46 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-06-13 1:15 ` https://lkml.org/lkml/2013/2/1/531 Ben Hutchings 1 sibling, 2 replies; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-23 10:24 UTC (permalink / raw) To: Matthew O'Connor Cc: Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li [-- Attachment #1: Type: text/plain, Size: 9521 bytes --] Am 23.05.2013 01:17, schrieb Matthew O'Connor: > This is the backported patch I submitted previously. Hopefully this > time around it won't be too messed up, I'm using Thunderbird instead of > the web interface. I have applied it successfully and without warnings > against 3.4.46. It builds, but is otherwise untested beyond what I did > when I originally submitted back in Feb. This patch applies only to the > 3.4 series kernel, although with minor changes it will work for 3.0, > 3.2, and 3.7. If you're interested, I can submit the other patches > shortly. If this submission still does not conform to standards, please > let me know where I went wrong. For what it's worth I dropped the patch > contents directly into the email, but I can attach it instead if that > would work better. > Hm, i tried to apply it to 3.4.46 but it does not work: node02:/ocfs2/usr/src/linux-3.4.46# patch -p1 <../bridge-patch-3.4.46 patching file drivers/net/bonding/bond_alb.c Hunk #1 FAILED at 704. 1 out of 1 hunk FAILED -- saving rejects to file drivers/net/bonding/bond_alb.c.rej patching file drivers/net/bonding/bonding.h patching file include/linux/etherdevice.h Hunk #1 FAILED at 277. 1 out of 1 hunk FAILED -- saving rejects to file include/linux/etherdevice.h.rej node02:/ocfs2/usr/src/linux-3.4.46# cat drivers/net/bonding/bond_alb.c.rej --- drivers/net/bonding/bond_alb.c 2013-01-27 23:51:45.000000000 -0500 +++ drivers/net/bonding/bond_alb.c 2013-01-30 15:37:25.121708311 -0500 @@ -704,6 +704,12 @@ struct arp_pkt *arp = arp_pkt(skb); struct slave *tx_slave = NULL; + /* Don't modify or load balance ARPs that do not originate locally + * (e.g.,arrive via a bridge). + */ + if (!bond_slave_has_mac(bond, arp->mac_src)) + return NULL; + if (arp->op_code == htons(ARPOP_REPLY)) { /* the arp must be sent on the selected * rx channel node02:/ocfs2/usr/src/linux-3.4.46# cat include/linux/etherdevice.h.rej --- include/linux/etherdevice.h 2013-01-27 23:51:45.000000000 -0500 +++ include/linux/etherdevice.h 2013-01-30 15:37:25.121708311 -0500 @@ -277,4 +277,37 @@ #endif } +/** + * ether_addr_equal_64bits - Compare two Ethernet addresses + * @addr1: Pointer to an array of 8 bytes + * @addr2: Pointer to an other array of 8 bytes + * + * Compare two Ethernet addresses, returns true if equal, false otherwise. + * + * The function doesn't need any conditional branches and possibly uses + * word memory accesses on CPU allowing cheap unaligned memory reads. + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } + * + * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits. + */ + +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], + const u8 addr2[6+2]) +{ +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS + unsigned long fold = ((*(unsigned long *)addr1) ^ + (*(unsigned long *)addr2)); + + if (sizeof(fold) == 8) + return zap_last_2bytes(fold) == 0; + + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ + (*(unsigned long *)(addr2 + 4))); + return fold == 0; +#else + return ether_addr_equal(addr1, addr2); +#endif +} + + #endif /* _LINUX_ETHERDEVICE_H */ > > [ Upstream commit 567b871e503316b0927e54a3d7c86d50b722d955 ] > > bonding: rlb mode of bond should not alter ARP originating via bridge > > Do not modify or load balance ARP packets passing through balance-alb > mode (wherein the ARP did not originate locally, and arrived via a bridge). > > Modifying pass-through ARP replies causes an incorrect MAC address > to be placed into the ARP packet, rendering peers unable to communicate > with the actual destination from which the ARP reply originated. > > Load balancing pass-through ARP requests causes an entry to be > created for the peer in the rlb table, and bond_alb_monitor will > occasionally issue ARP updates to all peers in the table instrucing them > as to which MAC address they should communicate with; this occurs when > some event sets rx_ntt. In the bridged case, however, the MAC address > used for the update would be the MAC of the slave, not the actual source > MAC of the originating destination. This would render peers unable to > communicate with the destinations beyond the bridge. > > Signed-off-by: Matthew O'Connor <liquidhorse@gmail.com> > CC: Zheng Li <zheng.x.li@oracle.com> > Cc: Jay Vosburgh <fubar@us.ibm.com> > Cc: Andy Gospodarek <andy@greyhouse.net> > Cc: "David S. Miller" <davem@davemloft.net> > > > diff -uprN linux-3.4.28/drivers/net/bonding/bond_alb.c > linux-3.4.28-patched/drivers/net/bonding/bond_alb.c > --- linux-3.4.28/drivers/net/bonding/bond_alb.c 2013-01-27 > 23:51:45.000000000 -0500 > +++ linux-3.4.28-patched/drivers/net/bonding/bond_alb.c 2013-01-30 > 15:37:25.121708311 -0500 > @@ -704,6 +704,12 @@ static struct slave *rlb_arp_xmit(struct > struct arp_pkt *arp = arp_pkt(skb); > struct slave *tx_slave = NULL; > > + /* Don't modify or load balance ARPs that do not originate locally > + * (e.g.,arrive via a bridge). > + */ > + if (!bond_slave_has_mac(bond, arp->mac_src)) > + return NULL; > + > if (arp->op_code == htons(ARPOP_REPLY)) { > /* the arp must be sent on the selected > * rx channel > diff -uprN linux-3.4.28/drivers/net/bonding/bonding.h > linux-3.4.28-patched/drivers/net/bonding/bonding.h > --- linux-3.4.28/drivers/net/bonding/bonding.h 2013-01-27 > 23:51:45.000000000 -0500 > +++ linux-3.4.28-patched/drivers/net/bonding/bonding.h 2013-01-30 > 15:37:25.121708311 -0500 > @@ -18,6 +18,7 @@ > #include <linux/timer.h> > #include <linux/proc_fs.h> > #include <linux/if_bonding.h> > +#include <linux/etherdevice.h> > #include <linux/cpumask.h> > #include <linux/in6.h> > #include <linux/netpoll.h> > @@ -450,6 +451,18 @@ static inline void bond_destroy_proc_dir > } > #endif > > +static inline struct slave *bond_slave_has_mac(struct bonding *bond, > + const u8 *mac) > +{ > + int i = 0; > + struct slave *tmp; > + > + bond_for_each_slave(bond, tmp, i) > + if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr)) > + return tmp; > + > + return NULL; > +} > > /* exported from bond_main.c */ > extern int bond_net_id; > diff -uprN linux-3.4.28/include/linux/etherdevice.h > linux-3.4.28-patched/include/linux/etherdevice.h > --- linux-3.4.28/include/linux/etherdevice.h 2013-01-27 > 23:51:45.000000000 -0500 > +++ linux-3.4.28-patched/include/linux/etherdevice.h 2013-01-30 > 15:37:25.121708311 -0500 > @@ -277,4 +277,37 @@ static inline unsigned long compare_ethe > #endif > } > > +/** > + * ether_addr_equal_64bits - Compare two Ethernet addresses > + * @addr1: Pointer to an array of 8 bytes > + * @addr2: Pointer to an other array of 8 bytes > + * > + * Compare two Ethernet addresses, returns true if equal, false otherwise. > + * > + * The function doesn't need any conditional branches and possibly uses > + * word memory accesses on CPU allowing cheap unaligned memory reads. > + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } > + * > + * Please note that alignment of addr1 & addr2 are only guaranteed to > be 16 bits. > + */ > + > +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], > + const u8 addr2[6+2]) > +{ > +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS > + unsigned long fold = ((*(unsigned long *)addr1) ^ > + (*(unsigned long *)addr2)); > + > + if (sizeof(fold) == 8) > + return zap_last_2bytes(fold) == 0; > + > + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ > + (*(unsigned long *)(addr2 + 4))); > + return fold == 0; > +#else > + return ether_addr_equal(addr1, addr2); > +#endif > +} > + > + > #endif /* _LINUX_ETHERDEVICE_H */ > > > > > On 05/22/2013 05:26 PM, Smart Weblications GmbH - Florian Wiessner wrote: >> Hi Greg, >> >> >> Am 22.05.2013 22:04, schrieb Greg KH: >> >> >>>> https://kernel.googlesource.com/pub/scm/linux/kernel/git/jkirsher/net-next/+/567b871e503316b0927e54a3d7c86d50b722d955%5E!/ >>> Ok, that's what we need. >>> >>> Now, please cc: the developers / maintainers of that patch and ask them >>> to have it included in the 3.4-stable kernel series. >>> >>> Then, if they agree, the network maintainer will pick it up and send it >>> to me for inclusion. >>> >> i set committer David S. Miller <davem@davemloft.net> in cc already, but do not >> know the network maintainer... >> >> this seems to me that "Matthew O'Connor" <liquidhorse@gmail.com> sent this to >> netdev on 2013-02-01: >> >> http://lists.openwall.net/netdev/2013/02/01/86 >> >> but i couldn't find a trace of the patch in 3.4.36?! >> >> Instead, i read another try to get it backported fail: >> >> http://permalink.gmane.org/gmane.linux.network/264198 >> >> >> >> >> >> > -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz [-- Attachment #2: bridge-patch-3.4.46.txt --] [-- Type: text/plain, Size: 3327 bytes --] diff -uprN linux-3.4.28/drivers/net/bonding/bond_alb.c linux-3.4.28-patched/drivers/net/bonding/bond_alb.c --- linux-3.4.28/drivers/net/bonding/bond_alb.c 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bond_alb.c 2013-01-30 15:37:25.121708311 -0500 @@ -704,6 +704,12 @@ static struct slave *rlb_arp_xmit(struct struct arp_pkt *arp = arp_pkt(skb); struct slave *tx_slave = NULL; + /* Don't modify or load balance ARPs that do not originate locally + * (e.g.,arrive via a bridge). + */ + if (!bond_slave_has_mac(bond, arp->mac_src)) + return NULL; + if (arp->op_code == htons(ARPOP_REPLY)) { /* the arp must be sent on the selected * rx channel diff -uprN linux-3.4.28/drivers/net/bonding/bonding.h linux-3.4.28-patched/drivers/net/bonding/bonding.h --- linux-3.4.28/drivers/net/bonding/bonding.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bonding.h 2013-01-30 15:37:25.121708311 -0500 @@ -18,6 +18,7 @@ #include <linux/timer.h> #include <linux/proc_fs.h> #include <linux/if_bonding.h> +#include <linux/etherdevice.h> #include <linux/cpumask.h> #include <linux/in6.h> #include <linux/netpoll.h> @@ -450,6 +451,18 @@ static inline void bond_destroy_proc_dir } #endif +static inline struct slave *bond_slave_has_mac(struct bonding *bond, + const u8 *mac) +{ + int i = 0; + struct slave *tmp; + + bond_for_each_slave(bond, tmp, i) + if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr)) + return tmp; + + return NULL; +} /* exported from bond_main.c */ extern int bond_net_id; diff -uprN linux-3.4.28/include/linux/etherdevice.h linux-3.4.28-patched/include/linux/etherdevice.h --- linux-3.4.28/include/linux/etherdevice.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/include/linux/etherdevice.h 2013-01-30 15:37:25.121708311 -0500 @@ -277,4 +277,37 @@ static inline unsigned long compare_ethe #endif } +/** + * ether_addr_equal_64bits - Compare two Ethernet addresses + * @addr1: Pointer to an array of 8 bytes + * @addr2: Pointer to an other array of 8 bytes + * + * Compare two Ethernet addresses, returns true if equal, false otherwise. + * + * The function doesn't need any conditional branches and possibly uses + * word memory accesses on CPU allowing cheap unaligned memory reads. + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } + * + * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits. + */ + +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], + const u8 addr2[6+2]) +{ +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS + unsigned long fold = ((*(unsigned long *)addr1) ^ + (*(unsigned long *)addr2)); + + if (sizeof(fold) == 8) + return zap_last_2bytes(fold) == 0; + + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ + (*(unsigned long *)(addr2 + 4))); + return fold == 0; +#else + return ether_addr_equal(addr1, addr2); +#endif +} + + #endif /* _LINUX_ETHERDEVICE_H */ ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-23 10:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-23 12:35 ` Matthew O'Connor 2013-05-23 13:36 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-23 12:46 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 1 sibling, 1 reply; 24+ messages in thread From: Matthew O'Connor @ 2013-05-23 12:35 UTC (permalink / raw) To: f.wiessner Cc: Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li [-- Attachment #1: Type: text/plain, Size: 1023 bytes --] On 05/23/2013 06:24 AM, Smart Weblications GmbH - Florian Wiessner wrote: > Hm, i tried to apply it to 3.4.46 but it does not work: > > node02:/ocfs2/usr/src/linux-3.4.46# patch -p1 <../bridge-patch-3.4.46 > patching file drivers/net/bonding/bond_alb.c > Hunk #1 FAILED at 704. > 1 out of 1 hunk FAILED -- saving rejects to file drivers/net/bonding/bond_alb.c.rej > patching file drivers/net/bonding/bonding.h > patching file include/linux/etherdevice.h > Hunk #1 FAILED at 277. > 1 out of 1 hunk FAILED -- saving rejects to file include/linux/etherdevice.h.rej That is extremely odd, considering I applied this to a freshly downloaded kernel source directly from kernel.org before resubmitting it: hv11:~/kernel/linux-3.4.46$ patch -p1 < ../balance-alb-patches/balance-alb-3.4.patch patching file drivers/net/bonding/bond_alb.c patching file drivers/net/bonding/bonding.h patching file include/linux/etherdevice.h Here's the patch as an attachment instead; I suspect it keeps getting damaged by my method of inclusion. [-- Attachment #2: balance-alb-3.4.patch --] [-- Type: text/x-patch, Size: 3137 bytes --] diff -uprN linux-3.4.28/drivers/net/bonding/bond_alb.c linux-3.4.28-patched/drivers/net/bonding/bond_alb.c --- linux-3.4.28/drivers/net/bonding/bond_alb.c 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bond_alb.c 2013-01-30 15:37:25.121708311 -0500 @@ -704,6 +704,12 @@ static struct slave *rlb_arp_xmit(struct struct arp_pkt *arp = arp_pkt(skb); struct slave *tx_slave = NULL; + /* Don't modify or load balance ARPs that do not originate locally + * (e.g.,arrive via a bridge). + */ + if (!bond_slave_has_mac(bond, arp->mac_src)) + return NULL; + if (arp->op_code == htons(ARPOP_REPLY)) { /* the arp must be sent on the selected * rx channel diff -uprN linux-3.4.28/drivers/net/bonding/bonding.h linux-3.4.28-patched/drivers/net/bonding/bonding.h --- linux-3.4.28/drivers/net/bonding/bonding.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bonding.h 2013-01-30 15:37:25.121708311 -0500 @@ -18,6 +18,7 @@ #include <linux/timer.h> #include <linux/proc_fs.h> #include <linux/if_bonding.h> +#include <linux/etherdevice.h> #include <linux/cpumask.h> #include <linux/in6.h> #include <linux/netpoll.h> @@ -450,6 +451,18 @@ static inline void bond_destroy_proc_dir } #endif +static inline struct slave *bond_slave_has_mac(struct bonding *bond, + const u8 *mac) +{ + int i = 0; + struct slave *tmp; + + bond_for_each_slave(bond, tmp, i) + if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr)) + return tmp; + + return NULL; +} /* exported from bond_main.c */ extern int bond_net_id; diff -uprN linux-3.4.28/include/linux/etherdevice.h linux-3.4.28-patched/include/linux/etherdevice.h --- linux-3.4.28/include/linux/etherdevice.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/include/linux/etherdevice.h 2013-01-30 15:37:25.121708311 -0500 @@ -277,4 +277,37 @@ static inline unsigned long compare_ethe #endif } +/** + * ether_addr_equal_64bits - Compare two Ethernet addresses + * @addr1: Pointer to an array of 8 bytes + * @addr2: Pointer to an other array of 8 bytes + * + * Compare two Ethernet addresses, returns true if equal, false otherwise. + * + * The function doesn't need any conditional branches and possibly uses + * word memory accesses on CPU allowing cheap unaligned memory reads. + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } + * + * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits. + */ + +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], + const u8 addr2[6+2]) +{ +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS + unsigned long fold = ((*(unsigned long *)addr1) ^ + (*(unsigned long *)addr2)); + + if (sizeof(fold) == 8) + return zap_last_2bytes(fold) == 0; + + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ + (*(unsigned long *)(addr2 + 4))); + return fold == 0; +#else + return ether_addr_equal(addr1, addr2); +#endif +} + + #endif /* _LINUX_ETHERDEVICE_H */ ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-23 12:35 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor @ 2013-05-23 13:36 ` Smart Weblications GmbH - Florian Wiessner 0 siblings, 0 replies; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-23 13:36 UTC (permalink / raw) To: Matthew O'Connor Cc: Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li Am 23.05.2013 14:35, schrieb Matthew O'Connor: > On 05/23/2013 06:24 AM, Smart Weblications GmbH - Florian Wiessner wrote: >> Hm, i tried to apply it to 3.4.46 but it does not work: >> >> node02:/ocfs2/usr/src/linux-3.4.46# patch -p1 <../bridge-patch-3.4.46 >> patching file drivers/net/bonding/bond_alb.c >> Hunk #1 FAILED at 704. >> 1 out of 1 hunk FAILED -- saving rejects to file drivers/net/bonding/bond_alb.c.rej >> patching file drivers/net/bonding/bonding.h >> patching file include/linux/etherdevice.h >> Hunk #1 FAILED at 277. >> 1 out of 1 hunk FAILED -- saving rejects to file include/linux/etherdevice.h.rej > That is extremely odd, considering I applied this to a freshly > downloaded kernel source directly from kernel.org before resubmitting it: > > hv11:~/kernel/linux-3.4.46$ patch -p1 < > ../balance-alb-patches/balance-alb-3.4.patch > patching file drivers/net/bonding/bond_alb.c > patching file drivers/net/bonding/bonding.h > patching file include/linux/etherdevice.h > > > Here's the patch as an attachment instead; I suspect it keeps getting > damaged by my method of inclusion. Thank you, this now worked for me! -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-23 10:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-23 12:35 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor @ 2013-05-23 12:46 ` Matthew O'Connor 2013-05-29 1:01 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 1 sibling, 1 reply; 24+ messages in thread From: Matthew O'Connor @ 2013-05-23 12:46 UTC (permalink / raw) To: f.wiessner Cc: Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li, liquidhorse [-- Attachment #1: Type: text/plain, Size: 371 bytes --] On 05/23/2013 06:24 AM, Smart Weblications GmbH - Florian Wiessner wrote: > node02:/ocfs2/usr/src/linux-3.4.46# cat drivers/net/bonding/bond_alb.c.rej My most sincere apologies - one more time, from a different mail server that hopefully won't go around changing my attachments. If this doesn't work I guess sendmail will be the next alternative. -- Matthew [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: balance-alb-3.4.patch --] [-- Type: text/x-patch; name="balance-alb-3.4.patch", Size: 3224 bytes --] diff -uprN linux-3.4.28/drivers/net/bonding/bond_alb.c linux-3.4.28-patched/drivers/net/bonding/bond_alb.c --- linux-3.4.28/drivers/net/bonding/bond_alb.c 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bond_alb.c 2013-01-30 15:37:25.121708311 -0500 @@ -704,6 +704,12 @@ static struct slave *rlb_arp_xmit(struct struct arp_pkt *arp = arp_pkt(skb); struct slave *tx_slave = NULL; + /* Don't modify or load balance ARPs that do not originate locally + * (e.g.,arrive via a bridge). + */ + if (!bond_slave_has_mac(bond, arp->mac_src)) + return NULL; + if (arp->op_code == htons(ARPOP_REPLY)) { /* the arp must be sent on the selected * rx channel diff -uprN linux-3.4.28/drivers/net/bonding/bonding.h linux-3.4.28-patched/drivers/net/bonding/bonding.h --- linux-3.4.28/drivers/net/bonding/bonding.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/drivers/net/bonding/bonding.h 2013-01-30 15:37:25.121708311 -0500 @@ -18,6 +18,7 @@ #include <linux/timer.h> #include <linux/proc_fs.h> #include <linux/if_bonding.h> +#include <linux/etherdevice.h> #include <linux/cpumask.h> #include <linux/in6.h> #include <linux/netpoll.h> @@ -450,6 +451,18 @@ static inline void bond_destroy_proc_dir } #endif +static inline struct slave *bond_slave_has_mac(struct bonding *bond, + const u8 *mac) +{ + int i = 0; + struct slave *tmp; + + bond_for_each_slave(bond, tmp, i) + if (ether_addr_equal_64bits(mac, tmp->dev->dev_addr)) + return tmp; + + return NULL; +} /* exported from bond_main.c */ extern int bond_net_id; diff -uprN linux-3.4.28/include/linux/etherdevice.h linux-3.4.28-patched/include/linux/etherdevice.h --- linux-3.4.28/include/linux/etherdevice.h 2013-01-27 23:51:45.000000000 -0500 +++ linux-3.4.28-patched/include/linux/etherdevice.h 2013-01-30 15:37:25.121708311 -0500 @@ -277,4 +277,37 @@ static inline unsigned long compare_ethe #endif } +/** + * ether_addr_equal_64bits - Compare two Ethernet addresses + * @addr1: Pointer to an array of 8 bytes + * @addr2: Pointer to an other array of 8 bytes + * + * Compare two Ethernet addresses, returns true if equal, false otherwise. + * + * The function doesn't need any conditional branches and possibly uses + * word memory accesses on CPU allowing cheap unaligned memory reads. + * arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 } + * + * Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits. + */ + +static inline bool ether_addr_equal_64bits(const u8 addr1[6+2], + const u8 addr2[6+2]) +{ +#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS + unsigned long fold = ((*(unsigned long *)addr1) ^ + (*(unsigned long *)addr2)); + + if (sizeof(fold) == 8) + return zap_last_2bytes(fold) == 0; + + fold |= zap_last_2bytes((*(unsigned long *)(addr1 + 4)) ^ + (*(unsigned long *)(addr2 + 4))); + return fold == 0; +#else + return ether_addr_equal(addr1, addr2); +#endif +} + + #endif /* _LINUX_ETHERDEVICE_H */ ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-23 12:46 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor @ 2013-05-29 1:01 ` Smart Weblications GmbH - Florian Wiessner 2013-05-29 1:10 ` https://lkml.org/lkml/2013/2/1/531 David Miller 2013-05-29 1:15 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 0 siblings, 2 replies; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-05-29 1:01 UTC (permalink / raw) To: Matthew O'Connor Cc: Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li, liquidhorse Am 23.05.2013 14:46, schrieb Matthew O'Connor: > On 05/23/2013 06:24 AM, Smart Weblications GmbH - Florian Wiessner wrote: >> node02:/ocfs2/usr/src/linux-3.4.46# cat drivers/net/bonding/bond_alb.c.rej > My most sincere apologies - one more time, from a different mail server > that hopefully won't go around changing my attachments. If this doesn't > work I guess sendmail will be the next alternative. > 3.4.47 got released without that included :-/?! https://www.kernel.org/pub/linux/kernel/v3.x/ChangeLog-3.4.47 -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-29 1:01 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-05-29 1:10 ` David Miller 2013-05-29 1:15 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 1 sibling, 0 replies; 24+ messages in thread From: David Miller @ 2013-05-29 1:10 UTC (permalink / raw) To: f.wiessner Cc: matt, gregkh, andy, fubar, linux-kernel, stable, nikolay, vfalico, zheng.x.li, liquidhorse From: Smart Weblications GmbH - Florian Wiessner <f.wiessner@smart-weblications.de> Date: Wed, 29 May 2013 03:01:53 +0200 > Am 23.05.2013 14:46, schrieb Matthew O'Connor: >> On 05/23/2013 06:24 AM, Smart Weblications GmbH - Florian Wiessner wrote: >>> node02:/ocfs2/usr/src/linux-3.4.46# cat drivers/net/bonding/bond_alb.c.rej >> My most sincere apologies - one more time, from a different mail server >> that hopefully won't go around changing my attachments. If this doesn't >> work I guess sendmail will be the next alternative. >> > > 3.4.47 got released without that included :-/?! > > https://www.kernel.org/pub/linux/kernel/v3.x/ChangeLog-3.4.47 Things take time, I haven't worked on a networking -stable submission in a while, I'll get to it by the end of the wake. Be patient. ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-29 1:01 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-29 1:10 ` https://lkml.org/lkml/2013/2/1/531 David Miller @ 2013-05-29 1:15 ` Greg KH 1 sibling, 0 replies; 24+ messages in thread From: Greg KH @ 2013-05-29 1:15 UTC (permalink / raw) To: Smart Weblications GmbH - Florian Wiessner Cc: Matthew O'Connor, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li, liquidhorse On Wed, May 29, 2013 at 03:01:53AM +0200, Smart Weblications GmbH - Florian Wiessner wrote: > Am 23.05.2013 14:46, schrieb Matthew O'Connor: > > On 05/23/2013 06:24 AM, Smart Weblications GmbH - Florian Wiessner wrote: > >> node02:/ocfs2/usr/src/linux-3.4.46# cat drivers/net/bonding/bond_alb.c.rej > > My most sincere apologies - one more time, from a different mail server > > that hopefully won't go around changing my attachments. If this doesn't > > work I guess sendmail will be the next alternative. > > > > 3.4.47 got released without that included :-/?! > > https://www.kernel.org/pub/linux/kernel/v3.x/ChangeLog-3.4.47 Yes, it missed that last release, I'll get a new one out when I get back from Japan next week. thanks, greg k-h ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-05-22 23:17 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-05-23 10:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-06-13 1:15 ` Ben Hutchings 2013-06-18 11:47 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 1 sibling, 1 reply; 24+ messages in thread From: Ben Hutchings @ 2013-06-13 1:15 UTC (permalink / raw) To: Matthew O'Connor Cc: f.wiessner, Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li [-- Attachment #1: Type: text/plain, Size: 555 bytes --] On Wed, 2013-05-22 at 19:17 -0400, Matthew O'Connor wrote: > This is the backported patch I submitted previously. Hopefully this > time around it won't be too messed up, I'm using Thunderbird instead of > the web interface. [...] This was whitespace-damaged; please read Documentation/email-clients.txt Also put the description in the subject line, like this: Subject: [PATCH 3.4.y] bonding: rlb mode of bond should not alter ARP originating via bridge Ben. -- Ben Hutchings friends: People who know you well, but like you anyway. [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 828 bytes --] ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-06-13 1:15 ` https://lkml.org/lkml/2013/2/1/531 Ben Hutchings @ 2013-06-18 11:47 ` Smart Weblications GmbH - Florian Wiessner 2013-06-18 17:23 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 0 siblings, 1 reply; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-06-18 11:47 UTC (permalink / raw) To: Ben Hutchings Cc: Matthew O'Connor, Greg KH, davem, andy, fubar, LKML, stable, nikolay, vfalico, zheng.x.li Am 13.06.2013 03:15, schrieb Ben Hutchings: > On Wed, 2013-05-22 at 19:17 -0400, Matthew O'Connor wrote: >> This is the backported patch I submitted previously. Hopefully this time >> around it won't be too messed up, I'm using Thunderbird instead of the >> web interface. > [...] > > This was whitespace-damaged; please read Documentation/email-clients.txt > > Also put the description in the subject line, like this: > > Subject: [PATCH 3.4.y] bonding: rlb mode of bond should not alter ARP > originating via bridge > > Ben. > Now we have 3.4.49, still this patch is not included? WHY? -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-06-18 11:47 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner @ 2013-06-18 17:23 ` Matthew O'Connor 2013-06-20 15:59 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 0 siblings, 1 reply; 24+ messages in thread From: Matthew O'Connor @ 2013-06-18 17:23 UTC (permalink / raw) To: f.wiessner Cc: Ben Hutchings, Greg KH, davem, andy, Jay Vosburgh, LKML, stable, nikolay, vfalico, zheng.x.li Because all of my submissions are damaged and I haven't had the time to correct them or my badly configured email clients. Trust me this affects me in the exact same way it does you; I'll try to redo the patches and send them upstream soon, for all our sake's. On Tue, Jun 18, 2013 at 7:47 AM, Smart Weblications GmbH - Florian Wiessner <f.wiessner@smart-weblications.de> wrote: > Am 13.06.2013 03:15, schrieb Ben Hutchings: >> On Wed, 2013-05-22 at 19:17 -0400, Matthew O'Connor wrote: >>> This is the backported patch I submitted previously. Hopefully this time >>> around it won't be too messed up, I'm using Thunderbird instead of the >>> web interface. >> [...] >> >> This was whitespace-damaged; please read Documentation/email-clients.txt >> >> Also put the description in the subject line, like this: >> >> Subject: [PATCH 3.4.y] bonding: rlb mode of bond should not alter ARP >> originating via bridge >> >> Ben. >> > > > Now we have 3.4.49, still this patch is not included? WHY? > > -- > > Mit freundlichen Grüßen, > > Florian Wiessner > > Smart Weblications GmbH > Martinsberger Str. 1 > D-95119 Naila > > fon.: +49 9282 9638 200 > fax.: +49 9282 9638 205 > 24/7: +49 900 144 000 00 - 0,99 EUR/Min* > http://www.smart-weblications.de > > -- > Sitz der Gesellschaft: Naila > Geschäftsführer: Florian Wiessner > HRB-Nr.: HRB 3840 Amtsgericht Hof > *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: https://lkml.org/lkml/2013/2/1/531 2013-06-18 17:23 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor @ 2013-06-20 15:59 ` Smart Weblications GmbH - Florian Wiessner 0 siblings, 0 replies; 24+ messages in thread From: Smart Weblications GmbH - Florian Wiessner @ 2013-06-20 15:59 UTC (permalink / raw) To: Matthew O'Connor Cc: Ben Hutchings, Greg KH, davem, andy, Jay Vosburgh, LKML, stable, nikolay, vfalico, zheng.x.li Hi Matthew, Am 18.06.2013 19:23, schrieb Matthew O'Connor: > Because all of my submissions are damaged and I haven't had the time > to correct them or my badly configured email clients. Trust me this > affects me in the exact same way it does you; I'll try to redo the > patches and send them upstream soon, for all our sake's. > Strange - your last patch worked without any flaws?! -- Mit freundlichen Grüßen, Florian Wiessner Smart Weblications GmbH Martinsberger Str. 1 D-95119 Naila fon.: +49 9282 9638 200 fax.: +49 9282 9638 205 24/7: +49 900 144 000 00 - 0,99 EUR/Min* http://www.smart-weblications.de -- Sitz der Gesellschaft: Naila Geschäftsführer: Florian Wiessner HRB-Nr.: HRB 3840 Amtsgericht Hof *aus dem dt. Festnetz, ggf. abweichende Preise aus dem Mobilfunknetz ^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2013-06-20 15:58 UTC | newest] Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2013-05-22 11:36 https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 13:57 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-05-22 16:16 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 16:23 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-05-22 18:16 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 19:06 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-05-22 19:35 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 20:04 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-05-22 21:26 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 21:54 ` https://lkml.org/lkml/2013/2/1/531 Jay Vosburgh 2013-05-22 22:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-22 22:32 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-05-22 23:17 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-05-23 10:24 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-23 12:35 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-05-23 13:36 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-23 12:46 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-05-29 1:01 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-05-29 1:10 ` https://lkml.org/lkml/2013/2/1/531 David Miller 2013-05-29 1:15 ` https://lkml.org/lkml/2013/2/1/531 Greg KH 2013-06-13 1:15 ` https://lkml.org/lkml/2013/2/1/531 Ben Hutchings 2013-06-18 11:47 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner 2013-06-18 17:23 ` https://lkml.org/lkml/2013/2/1/531 Matthew O'Connor 2013-06-20 15:59 ` https://lkml.org/lkml/2013/2/1/531 Smart Weblications GmbH - Florian Wiessner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).