From: David Daney <ddaney@caviumnetworks.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: David Daney <ddaney.cavm@gmail.com>, <linux-mips@linux-mips.org>,
<ralf@linux-mips.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
David Daney <david.daney@cavium.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jonas Gorski <jogo@openwrt.org>
Subject: Re: [PATCH] MIPS: Enable interrupts before WAIT instruction.
Date: Wed, 22 May 2013 15:36:51 -0700 [thread overview]
Message-ID: <519D4883.9050905@caviumnetworks.com> (raw)
In-Reply-To: <20130522223225.GH31836@blackmetal.musicnaut.iki.fi>
On 05/22/2013 03:32 PM, Aaro Koskinen wrote:
> Hi,
>
> On Thu, May 02, 2013 at 01:48:12PM -0700, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
>> As noted by Thomas Gleixner:
>>
>> commit cdbedc61c8 (mips: Use generic idle loop) broke MIPS as I did
>> not realize that MIPS wants to invoke the wait instructions with
>> interrupts enabled.
>>
>> Instead of enabling interrupts in arch_cpu_idle() as Thomas' initial
>> patch does, we follow Linus' suggestion of doing it in the assembly
>> code to prevent the compiler from rearranging things.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> Reported-by: EunBong Song <eunb.song@samsung.com>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Jonas Gorski <jogo@openwrt.org>
>> ---
>>
>> This is only very lightly tested, we need more testing before
>> declaring it the definitive fix.
>
> I wonder what is the status of this patch? Or is there some alternative
> fix?
>
> I have Octeon+ board that hangs during 3.10-rc2 boot in spawn_ksoftirqd()
> without this. Also, this patch does not apply cleanly to 3.10-rc2
> anymore...
>
> A.
>
Ralf has an alternate fix here:
http://git.linux-mips.org/pub/scm/ralf/upstream-linus.git
If all goes well, it will be merged soon.
David Daney
prev parent reply other threads:[~2013-05-22 22:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 4:57 mips; boot fail after merge 3.9+ EUNBONG SONG
2013-05-02 8:32 ` Jonas Gorski
2013-05-02 10:42 ` Thomas Gleixner
2013-05-02 11:20 ` Jonas Gorski
2013-05-02 14:33 ` [PATCH] MIPS: Enable interrupts in arch_cpu_idle() Thomas Gleixner
2013-05-02 14:58 ` Ralf Baechle
2013-05-02 16:45 ` Linus Torvalds
2013-05-02 20:48 ` [PATCH] MIPS: Enable interrupts before WAIT instruction David Daney
2013-05-02 21:04 ` Thomas Gleixner
2013-05-03 9:54 ` Jonas Gorski
2013-05-06 14:26 ` Manuel Lauss
2013-05-22 22:32 ` Aaro Koskinen
2013-05-22 22:36 ` David Daney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519D4883.9050905@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).