From: Thomas Gleixner <tglx@linutronix.de>
To: Jonas Gorski <jogo@openwrt.org>
Cc: eunb.song@samsung.com,
"ralf@linux-mips.org" <ralf@linux-mips.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: mips; boot fail after merge 3.9+
Date: Thu, 2 May 2013 12:42:08 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.02.1305021241040.3972@ionos> (raw)
In-Reply-To: <CAOiHx=mBPHmDse4EwL-+Fgmpz0=XhcgF_0nWdyvErFO4NU7E0Q@mail.gmail.com>
On Thu, 2 May 2013, Jonas Gorski wrote:
> On Wed, May 1, 2013 at 6:57 AM, EUNBONG SONG <eunb.song@samsung.com> wrote:
> >
> > Hello.
> > After merge cavium board boots fail, boot log messages are as follows.
> > I enabled initcall_debug for debugging.
>
> I can confirm that MIPS does not seem to finish to boot after using
> the generic idle loop, I have the same problem on a different platform
> (bcm63xx), and bisecting showed the same commit.
>
> (snip)
>
> > I found this issue after cdbedc61c8d0122ad682815936f0d11df1fe5f57.
> > And i found something strange. I ran the git show for this commit.
> > As below "select GENERIC_IDLE_LOOP" is added for CONFIG_MIPS.
> > but the latest arch/mips/Kconfig file has not this one. I have tried to find when this is gone. but i can't find.
> > Is there any problem with this?
>
> No, after all architectures were converted to use the generic idle
> loop the config symbol was removed, so it's now always on. The problem
> is rather that the generic idle loop does not seem to work on MIPS.
> Unfortunately due to limited knowledge in this area I can't really
> tell which part broke it.
Does the patch below fix your issue ?
Thanks,
tglx
diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c
index 8b86c0c..a8972fe 100644
--- a/kernel/cpu/idle.c
+++ b/kernel/cpu/idle.c
@@ -70,8 +70,10 @@ static void cpu_idle_loop(void)
check_pgt_cache();
rmb();
- if (cpu_is_offline(smp_processor_id()))
+ if (cpu_is_offline(smp_processor_id())) {
arch_cpu_idle_dead();
+ continue;
+ }
local_irq_disable();
arch_cpu_idle_enter();
next prev parent reply other threads:[~2013-05-02 10:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 4:57 mips; boot fail after merge 3.9+ EUNBONG SONG
2013-05-02 8:32 ` Jonas Gorski
2013-05-02 10:42 ` Thomas Gleixner [this message]
2013-05-02 11:20 ` Jonas Gorski
2013-05-02 14:33 ` [PATCH] MIPS: Enable interrupts in arch_cpu_idle() Thomas Gleixner
2013-05-02 14:58 ` Ralf Baechle
2013-05-02 16:45 ` Linus Torvalds
2013-05-02 20:48 ` [PATCH] MIPS: Enable interrupts before WAIT instruction David Daney
2013-05-02 21:04 ` Thomas Gleixner
2013-05-03 9:54 ` Jonas Gorski
2013-05-06 14:26 ` Manuel Lauss
2013-05-22 22:32 ` Aaro Koskinen
2013-05-22 22:36 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.02.1305021241040.3972@ionos \
--to=tglx@linutronix.de \
--cc=eunb.song@samsung.com \
--cc=jogo@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).