* [PATCH -next] remoteproc: make rproc_check_carveout_da static
@ 2019-02-01 3:13 YueHaibing
2019-02-01 15:56 ` Loic PALLARDY
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-02-01 3:13 UTC (permalink / raw)
To: ohad, bjorn.andersson; +Cc: linux-kernel, linux-remoteproc, YueHaibing
Fixes the following sparse warnings:
drivers/remoteproc/remoteproc_core.c:279:5: warning:
symbol 'rproc_check_carveout_da' was not declared. Should it be static?
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/remoteproc/remoteproc_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 54ec38f..5d4954d 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc, const char *name, ...)
*
* Return: 0 if carveout match request else -ENOMEM
*/
-int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry *mem,
- u32 da, u32 len)
+static int rproc_check_carveout_da(struct rproc *rproc,
+ struct rproc_mem_entry *mem,
+ u32 da, u32 len)
{
struct device *dev = &rproc->dev;
int delta = 0;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH -next] remoteproc: make rproc_check_carveout_da static
2019-02-01 3:13 [PATCH -next] remoteproc: make rproc_check_carveout_da static YueHaibing
@ 2019-02-01 15:56 ` Loic PALLARDY
0 siblings, 0 replies; 2+ messages in thread
From: Loic PALLARDY @ 2019-02-01 15:56 UTC (permalink / raw)
To: YueHaibing, ohad, bjorn.andersson; +Cc: linux-kernel, linux-remoteproc
Hi Yue,
> -----Original Message-----
> From: linux-remoteproc-owner@vger.kernel.org <linux-remoteproc-
> owner@vger.kernel.org> On Behalf Of YueHaibing
> Sent: vendredi 1 février 2019 04:13
> To: ohad@wizery.com; bjorn.andersson@linaro.org
> Cc: linux-kernel@vger.kernel.org; linux-remoteproc@vger.kernel.org;
> YueHaibing <yuehaibing@huawei.com>
> Subject: [PATCH -next] remoteproc: make rproc_check_carveout_da static
>
> Fixes the following sparse warnings:
>
> drivers/remoteproc/remoteproc_core.c:279:5: warning:
> symbol 'rproc_check_carveout_da' was not declared. Should it be static?
Correction already sent on ML few weeks ago. See [1]
Regards,
Loic
[1] https://patchwork.kernel.org/patch/10755763/
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/remoteproc/remoteproc_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 54ec38f..5d4954d 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc,
> const char *name, ...)
> *
> * Return: 0 if carveout match request else -ENOMEM
> */
> -int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry
> *mem,
> - u32 da, u32 len)
> +static int rproc_check_carveout_da(struct rproc *rproc,
> + struct rproc_mem_entry *mem,
> + u32 da, u32 len)
> {
> struct device *dev = &rproc->dev;
> int delta = 0;
> --
> 2.7.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-01 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-01 3:13 [PATCH -next] remoteproc: make rproc_check_carveout_da static YueHaibing
2019-02-01 15:56 ` Loic PALLARDY
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).