* [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig
@ 2013-06-21 8:36 Aruna Balakrishnaiah
2013-06-24 1:21 ` Michael Neuling
0 siblings, 1 reply; 3+ messages in thread
From: Aruna Balakrishnaiah @ 2013-06-21 8:36 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel, benh; +Cc: mahesh, ananth
Enable PSTORE in pseries_defconfig
Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
---
arch/powerpc/configs/pseries_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index c4dfbaf..9630a50 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -347,3 +347,4 @@ CONFIG_VIRTUALIZATION=y
CONFIG_KVM_BOOK3S_64=m
CONFIG_KVM_BOOK3S_64_HV=y
CONFIG_VHOST_NET=m
+CONFIG_PSTORE=y
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig
2013-06-21 8:36 [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig Aruna Balakrishnaiah
@ 2013-06-24 1:21 ` Michael Neuling
2013-06-24 6:43 ` Aruna Balakrishnaiah
0 siblings, 1 reply; 3+ messages in thread
From: Michael Neuling @ 2013-06-24 1:21 UTC (permalink / raw)
To: Aruna Balakrishnaiah; +Cc: linuxppc-dev, linux-kernel, benh, mahesh
> Enable PSTORE in pseries_defconfig
Please add a "why" to your changelogs eg. "Now we have pstore support for
nvram on pseries, enable it in the default config"
"Why" you are changing something is more important than "what", since
you can always determine "what" is being changed, by looking at the diff.
The "why" will be long forgotten.
>
> Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
> ---
> arch/powerpc/configs/pseries_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
> index c4dfbaf..9630a50 100644
> --- a/arch/powerpc/configs/pseries_defconfig
> +++ b/arch/powerpc/configs/pseries_defconfig
> @@ -347,3 +347,4 @@ CONFIG_VIRTUALIZATION=y
> CONFIG_KVM_BOOK3S_64=m
> CONFIG_KVM_BOOK3S_64_HV=y
> CONFIG_VHOST_NET=m
> +CONFIG_PSTORE=y
This should really be added in the right location on the config, not
just at the end. ie.
@@ -296,6 +293,7 @@
CONFIG_SQUASHFS_XATTR=y
CONFIG_SQUASHFS_LZO=y
CONFIG_SQUASHFS_XZ=y
+CONFIG_PSTORE=y
CONFIG_NFS_FS=y
CONFIG_NFS_V3_ACL=y
CONFIG_NFS_V4=y
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig
2013-06-24 1:21 ` Michael Neuling
@ 2013-06-24 6:43 ` Aruna Balakrishnaiah
0 siblings, 0 replies; 3+ messages in thread
From: Aruna Balakrishnaiah @ 2013-06-24 6:43 UTC (permalink / raw)
To: Michael Neuling; +Cc: mahesh, linuxppc-dev, linux-kernel
Hi Michael,
On Monday 24 June 2013 06:51 AM, Michael Neuling wrote:
>> Enable PSTORE in pseries_defconfig
> Please add a "why" to your changelogs eg. "Now we have pstore support for
> nvram on pseries, enable it in the default config"
>
> "Why" you are changing something is more important than "what", since
> you can always determine "what" is being changed, by looking at the diff.
> The "why" will be long forgotten.
>
>> Signed-off-by: Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com>
>> ---
>> arch/powerpc/configs/pseries_defconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
>> index c4dfbaf..9630a50 100644
>> --- a/arch/powerpc/configs/pseries_defconfig
>> +++ b/arch/powerpc/configs/pseries_defconfig
>> @@ -347,3 +347,4 @@ CONFIG_VIRTUALIZATION=y
>> CONFIG_KVM_BOOK3S_64=m
>> CONFIG_KVM_BOOK3S_64_HV=y
>> CONFIG_VHOST_NET=m
>> +CONFIG_PSTORE=y
> This should really be added in the right location on the config, not
> just at the end. ie.
Sorry, I overlooked this commentin my v2 patch. Will resend.
> @@ -296,6 +293,7 @@
> CONFIG_SQUASHFS_XATTR=y
> CONFIG_SQUASHFS_LZO=y
> CONFIG_SQUASHFS_XZ=y
> +CONFIG_PSTORE=y
> CONFIG_NFS_FS=y
> CONFIG_NFS_V3_ACL=y
> CONFIG_NFS_V4=y
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-24 6:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-21 8:36 [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig Aruna Balakrishnaiah
2013-06-24 1:21 ` Michael Neuling
2013-06-24 6:43 ` Aruna Balakrishnaiah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).