* [PATCH] m68knommu: Mark config_BSP() __init
@ 2013-06-25 19:40 Geert Uytterhoeven
2013-06-26 23:08 ` Greg Ungerer
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2013-06-25 19:40 UTC (permalink / raw)
To: Greg Ungerer; +Cc: uclinux-dev, linux-m68k, linux-kernel, Geert Uytterhoeven
Some instances of config_BSP() lack an __init annotation.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
arch/m68k/platform/68000/m68328.c | 3 ++-
arch/m68k/platform/68000/m68EZ328.c | 3 ++-
arch/m68k/platform/68000/m68VZ328.c | 3 ++-
arch/m68k/platform/68360/config.c | 3 ++-
4 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/m68k/platform/68000/m68328.c b/arch/m68k/platform/68000/m68328.c
index a86eb66..e53caf4 100644
--- a/arch/m68k/platform/68000/m68328.c
+++ b/arch/m68k/platform/68000/m68328.c
@@ -15,6 +15,7 @@
/***************************************************************************/
+#include <linux/init.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/rtc.h>
@@ -42,7 +43,7 @@ void m68328_reset (void)
/***************************************************************************/
-void config_BSP(char *command, int len)
+void __init config_BSP(char *command, int len)
{
printk(KERN_INFO "\n68328 support D. Jeff Dionne <jeff@uclinux.org>\n");
printk(KERN_INFO "68328 support Kenneth Albanowski <kjahds@kjshds.com>\n");
diff --git a/arch/m68k/platform/68000/m68EZ328.c b/arch/m68k/platform/68000/m68EZ328.c
index a6eb72d..332b5e8 100644
--- a/arch/m68k/platform/68000/m68EZ328.c
+++ b/arch/m68k/platform/68000/m68EZ328.c
@@ -13,6 +13,7 @@
/***************************************************************************/
+#include <linux/init.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/rtc.h>
@@ -52,7 +53,7 @@ _bsc1(unsigned char *, gethwaddr, int, a)
_bsc1(char *, getbenv, char *, a)
#endif
-void config_BSP(char *command, int len)
+void __init config_BSP(char *command, int len)
{
unsigned char *p;
diff --git a/arch/m68k/platform/68000/m68VZ328.c b/arch/m68k/platform/68000/m68VZ328.c
index eb6964f..42e1ada 100644
--- a/arch/m68k/platform/68000/m68VZ328.c
+++ b/arch/m68k/platform/68000/m68VZ328.c
@@ -14,6 +14,7 @@
/***************************************************************************/
+#include <linux/init.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/kd.h>
@@ -175,7 +176,7 @@ static void init_hardware(char *command, int size)
#endif
/***************************************************************************/
-void config_BSP(char *command, int size)
+void __init config_BSP(char *command, int size)
{
printk(KERN_INFO "68VZ328 DragonBallVZ support (c) 2001 Lineo, Inc.\n");
diff --git a/arch/m68k/platform/68360/config.c b/arch/m68k/platform/68360/config.c
index 9877cef..0570741 100644
--- a/arch/m68k/platform/68360/config.c
+++ b/arch/m68k/platform/68360/config.c
@@ -11,6 +11,7 @@
*/
#include <stdarg.h>
+#include <linux/init.h>
#include <linux/types.h>
#include <linux/kernel.h>
#include <linux/mm.h>
@@ -140,7 +141,7 @@ _bsc1(char *, getbenv, char *, a)
#endif
-void config_BSP(char *command, int len)
+void __init config_BSP(char *command, int len)
{
unsigned char *p;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] m68knommu: Mark config_BSP() __init
2013-06-25 19:40 [PATCH] m68knommu: Mark config_BSP() __init Geert Uytterhoeven
@ 2013-06-26 23:08 ` Greg Ungerer
2013-06-27 6:49 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Greg Ungerer @ 2013-06-26 23:08 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: uclinux-dev, linux-m68k, linux-kernel
Hi Geert,
On 26/06/13 05:40, Geert Uytterhoeven wrote:
> Some instances of config_BSP() lack an __init annotation.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Greg Ungerer <gerg@uclinux.org>
Looks good. Are you going to push it via your tree, or do you want
me too?
Regards
Greg
> ---
> arch/m68k/platform/68000/m68328.c | 3 ++-
> arch/m68k/platform/68000/m68EZ328.c | 3 ++-
> arch/m68k/platform/68000/m68VZ328.c | 3 ++-
> arch/m68k/platform/68360/config.c | 3 ++-
> 4 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/arch/m68k/platform/68000/m68328.c b/arch/m68k/platform/68000/m68328.c
> index a86eb66..e53caf4 100644
> --- a/arch/m68k/platform/68000/m68328.c
> +++ b/arch/m68k/platform/68000/m68328.c
> @@ -15,6 +15,7 @@
>
> /***************************************************************************/
>
> +#include <linux/init.h>
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/rtc.h>
> @@ -42,7 +43,7 @@ void m68328_reset (void)
>
> /***************************************************************************/
>
> -void config_BSP(char *command, int len)
> +void __init config_BSP(char *command, int len)
> {
> printk(KERN_INFO "\n68328 support D. Jeff Dionne <jeff@uclinux.org>\n");
> printk(KERN_INFO "68328 support Kenneth Albanowski <kjahds@kjshds.com>\n");
> diff --git a/arch/m68k/platform/68000/m68EZ328.c b/arch/m68k/platform/68000/m68EZ328.c
> index a6eb72d..332b5e8 100644
> --- a/arch/m68k/platform/68000/m68EZ328.c
> +++ b/arch/m68k/platform/68000/m68EZ328.c
> @@ -13,6 +13,7 @@
>
> /***************************************************************************/
>
> +#include <linux/init.h>
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/rtc.h>
> @@ -52,7 +53,7 @@ _bsc1(unsigned char *, gethwaddr, int, a)
> _bsc1(char *, getbenv, char *, a)
> #endif
>
> -void config_BSP(char *command, int len)
> +void __init config_BSP(char *command, int len)
> {
> unsigned char *p;
>
> diff --git a/arch/m68k/platform/68000/m68VZ328.c b/arch/m68k/platform/68000/m68VZ328.c
> index eb6964f..42e1ada 100644
> --- a/arch/m68k/platform/68000/m68VZ328.c
> +++ b/arch/m68k/platform/68000/m68VZ328.c
> @@ -14,6 +14,7 @@
>
> /***************************************************************************/
>
> +#include <linux/init.h>
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/kd.h>
> @@ -175,7 +176,7 @@ static void init_hardware(char *command, int size)
> #endif
> /***************************************************************************/
>
> -void config_BSP(char *command, int size)
> +void __init config_BSP(char *command, int size)
> {
> printk(KERN_INFO "68VZ328 DragonBallVZ support (c) 2001 Lineo, Inc.\n");
>
> diff --git a/arch/m68k/platform/68360/config.c b/arch/m68k/platform/68360/config.c
> index 9877cef..0570741 100644
> --- a/arch/m68k/platform/68360/config.c
> +++ b/arch/m68k/platform/68360/config.c
> @@ -11,6 +11,7 @@
> */
>
> #include <stdarg.h>
> +#include <linux/init.h>
> #include <linux/types.h>
> #include <linux/kernel.h>
> #include <linux/mm.h>
> @@ -140,7 +141,7 @@ _bsc1(char *, getbenv, char *, a)
> #endif
>
>
> -void config_BSP(char *command, int len)
> +void __init config_BSP(char *command, int len)
> {
> unsigned char *p;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] m68knommu: Mark config_BSP() __init
2013-06-26 23:08 ` Greg Ungerer
@ 2013-06-27 6:49 ` Geert Uytterhoeven
2013-06-30 2:50 ` Greg Ungerer
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2013-06-27 6:49 UTC (permalink / raw)
To: Greg Ungerer; +Cc: uClinux development list, linux-m68k, linux-kernel
On Thu, Jun 27, 2013 at 1:08 AM, Greg Ungerer <gerg@uclinux.org> wrote:
> On 26/06/13 05:40, Geert Uytterhoeven wrote:
>>
>> Some instances of config_BSP() lack an __init annotation.
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
>
> Acked-by: Greg Ungerer <gerg@uclinux.org>
>
> Looks good. Are you going to push it via your tree, or do you want
> me too?
As it's m68nommu, perhaps through your tree? Unless you don't have time to
handle it.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] m68knommu: Mark config_BSP() __init
2013-06-27 6:49 ` Geert Uytterhoeven
@ 2013-06-30 2:50 ` Greg Ungerer
0 siblings, 0 replies; 4+ messages in thread
From: Greg Ungerer @ 2013-06-30 2:50 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: uClinux development list, linux-m68k, linux-kernel
Hi Geert,
On 27/06/13 16:49, Geert Uytterhoeven wrote:
> On Thu, Jun 27, 2013 at 1:08 AM, Greg Ungerer <gerg@uclinux.org> wrote:
>> On 26/06/13 05:40, Geert Uytterhoeven wrote:
>>>
>>> Some instances of config_BSP() lack an __init annotation.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>
>>
>> Acked-by: Greg Ungerer <gerg@uclinux.org>
>>
>> Looks good. Are you going to push it via your tree, or do you want
>> me too?
>
> As it's m68nommu, perhaps through your tree? Unless you don't have time to
> handle it.
I can take care of it. Though I may be a little slower than usual,
I am traveling at the moment.
Regards
Greg
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-30 2:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-25 19:40 [PATCH] m68knommu: Mark config_BSP() __init Geert Uytterhoeven
2013-06-26 23:08 ` Greg Ungerer
2013-06-27 6:49 ` Geert Uytterhoeven
2013-06-30 2:50 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).