* [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling
@ 2013-07-04 11:04 zhangwei(Jovi)
2013-07-04 12:56 ` Masami Hiramatsu
2013-07-04 17:53 ` Oleg Nesterov
0 siblings, 2 replies; 3+ messages in thread
From: zhangwei(Jovi) @ 2013-07-04 11:04 UTC (permalink / raw)
To: Steven Rostedt, Oleg Nesterov, Masami Hiramatsu
Cc: Srikar Dronamraju, Frederic Weisbecker, Ingo Molnar, linux-kernel
Support soft-mode disabling on uprobe-based dynamic events.
Soft-disabling is just ignoring recording if the soft disabled
flag is set.
Signed-off-by: zhangwei(Jovi) <jovi.zhangwe@huawei.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
kernel/trace/trace_uprobe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index 2fc9931..94f180d 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
WARN_ON(call != ftrace_file->event_call);
+ if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
+ return;
+
size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
call->event.type,
--
1.7.9.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling
2013-07-04 11:04 [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling zhangwei(Jovi)
@ 2013-07-04 12:56 ` Masami Hiramatsu
2013-07-04 17:53 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2013-07-04 12:56 UTC (permalink / raw)
To: zhangwei(Jovi)
Cc: Steven Rostedt, Oleg Nesterov, Srikar Dronamraju,
Frederic Weisbecker, Ingo Molnar, linux-kernel
(2013/07/04 20:04), zhangwei(Jovi) wrote:
> Support soft-mode disabling on uprobe-based dynamic events.
> Soft-disabling is just ignoring recording if the soft disabled
> flag is set.
>
> Signed-off-by: zhangwei(Jovi) <jovi.zhangwe@huawei.com>
looks good for me too.
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Thanks!
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> Cc: Frederic Weisbecker <fweisbec@gmail.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/trace/trace_uprobe.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 2fc9931..94f180d 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
>
> WARN_ON(call != ftrace_file->event_call);
>
> + if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
> + return;
> +
> size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
> event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
> call->event.type,
>
--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling
2013-07-04 11:04 [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling zhangwei(Jovi)
2013-07-04 12:56 ` Masami Hiramatsu
@ 2013-07-04 17:53 ` Oleg Nesterov
1 sibling, 0 replies; 3+ messages in thread
From: Oleg Nesterov @ 2013-07-04 17:53 UTC (permalink / raw)
To: zhangwei(Jovi)
Cc: Steven Rostedt, Masami Hiramatsu, Srikar Dronamraju,
Frederic Weisbecker, Ingo Molnar, linux-kernel
On 07/04, zhangwei(Jovi) wrote:
>
> Support soft-mode disabling on uprobe-based dynamic events.
> Soft-disabling is just ignoring recording if the soft disabled
> flag is set.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-04 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-04 11:04 [PATCH 2/2 v6] tracing/uprobes: Support soft-mode disabling zhangwei(Jovi)
2013-07-04 12:56 ` Masami Hiramatsu
2013-07-04 17:53 ` Oleg Nesterov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).