[PATCH V2] ARM: tegra: enable gpio-keys on dalmore

[PATCH V2] ARM: tegra: enable gpio-keys on dalmore

[Laxman Dewangan]

Dalmore have the keys mounted on board which are connected
to different pins of Tegra.

Add the keys entry in DTS file to enable key functionality.
This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and
KEY_VOLUMEDOWN.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
Changes from V1:
- Reorder the nodes.

 arch/arm/boot/dts/tegra114-dalmore.dts |   30 ++++++++++++++++++++++++++++++
 1 files changed, 30 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index cb640eb..259b517 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -883,6 +883,35 @@
 		};
 	};
 
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		home {
+			label = "Home";
+			gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
+			linux,code = <102>; /* KEY_HOME */
+		};
+
+		power {
+			label = "Power";
+			gpios = <&gpio TEGRA_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
+			linux,code = <116>; /* KEY_POWER */
+			gpio-key,wakeup;
+		};
+
+		volume_down {
+			label = "VolumeDown";
+			gpios = <&gpio TEGRA_GPIO(R, 1) GPIO_ACTIVE_LOW>;
+			linux,code = <114>; /* KEY_VOLUMEDOWN */
+		};
+
+		volume_up {
+			label = "VolumeUp";
+			gpios = <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_LOW>;
+			linux,code = <115>; /* KEY_VOLUMEUP */
+		};
+	};
+
 	regulators {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -976,4 +1005,5 @@
 			 <&tegra_car TEGRA114_CLK_EXTERN1>;
 		clock-names = "pll_a", "pll_a_out0", "mclk";
 	};
+
 };
-- 
1.7.1.1

Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore

[Stephen Warren]

On 07/06/2013 03:14 AM, Laxman Dewangan wrote:
> Dalmore have the keys mounted on board which are connected
> to different pins of Tegra.
> 
> Add the keys entry in DTS file to enable key functionality.
> This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and
> KEY_VOLUMEDOWN.

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts

> @@ -976,4 +1005,5 @@
>  			 <&tegra_car TEGRA114_CLK_EXTERN1>;
>  		clock-names = "pll_a", "pll_a_out0", "mclk";
>  	};
> +
>  };

What's that? I'll try to remember to fix this up when applying, but
proof-reading would help.

Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore

[Laxman Dewangan]

On Monday 08 July 2013 09:21 PM, Stephen Warren wrote:
> On 07/06/2013 03:14 AM, Laxman Dewangan wrote:
>
>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
>> @@ -976,4 +1005,5 @@
>>   			 <&tegra_car TEGRA114_CLK_EXTERN1>;
>>   		clock-names = "pll_a", "pll_a_out0", "mclk";
>>   	};
>> +
>>   };
> What's that? I'll try to remember to fix this up when applying, but
> proof-reading would help.

Oops.. My bad.. Did not see the bottom when doing patch review.

Let me know if I need to send V4 if it is easy for you to handle?

Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

On Sat, Jul 06, 2013 at 02:44:29PM +0530, Laxman Dewangan wrote:
> Dalmore have the keys mounted on board which are connected
> to different pins of Tegra.
> 
> Add the keys entry in DTS file to enable key functionality.
> This will enable KEY_POWER, KEY_HOME, KEY_VOLUMEUP and
> KEY_VOLUMEDOWN.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Changes from V1:
> - Reorder the nodes.
> 
>  arch/arm/boot/dts/tegra114-dalmore.dts |   30 ++++++++++++++++++++++++++++++
>  1 files changed, 30 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> index cb640eb..259b517 100644
> --- a/arch/arm/boot/dts/tegra114-dalmore.dts
> +++ b/arch/arm/boot/dts/tegra114-dalmore.dts
> @@ -883,6 +883,35 @@
>  		};
>  	};
>  
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		home {
> +			label = "Home";
> +			gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
> +			linux,code = <102>; /* KEY_HOME */

I wonder if these should maybe go into a header file as well so that
symbolic names can be used. That'll make the value self-descriptive and
allow the comment to be dropped.

> +		volume_down {
> +			label = "VolumeDown";
> +			gpios = <&gpio TEGRA_GPIO(R, 1) GPIO_ACTIVE_LOW>;
> +			linux,code = <114>; /* KEY_VOLUMEDOWN */
> +		};
> +
> +		volume_up {
> +			label = "VolumeUp";
> +			gpios = <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_LOW>;
> +			linux,code = <115>; /* KEY_VOLUMEUP */
> +		};
> +	};

Nit: Perhaps the labels should be "Volume Down" and "Volume Up" here?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH V2] ARM: tegra: enable gpio-keys on dalmore

[Laxman Dewangan]

On Tuesday 09 July 2013 11:34 AM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Sat, Jul 06, 2013 at 02:44:29PM +0530, Laxman Dewangan wrote:
>> D
>> +
>> +		home {
>> +			label = "Home";
>> +			gpios = <&gpio TEGRA_GPIO(I, 5) GPIO_ACTIVE_LOW>;
>> +			linux,code = <102>; /* KEY_HOME */
> I wonder if these should maybe go into a header file as well so that
> symbolic names can be used. That'll make the value self-descriptive and
> allow the comment to be dropped.
>
Currently there is no header for input.h in dt-binding include. We need 
to add them first and then use it.
Probably it can be done along with all cleanups on dts file atleast for 
Tegra.
I can start this if no one faster than me for this activity but for this 
patch, I like to go on legacy way.