From: Wei Ni <wni@nvidia.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Thierry Reding <thierry.reding@gmail.com>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"lm-sensors@lm-sensors.org" <lm-sensors@lm-sensors.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] hwmon: (lm90) split set&show temp as common codes
Date: Wed, 17 Jul 2013 17:54:54 +0800 [thread overview]
Message-ID: <51E669EE.6000705@nvidia.com> (raw)
In-Reply-To: <20130717111144.491e9958@endymion.delvare>
On 07/17/2013 05:11 PM, Jean Delvare wrote:
> On Wed, 17 Jul 2013 14:26:54 +0800, Wei Ni wrote:
>> On 07/17/2013 01:14 PM, Guenter Roeck wrote:
>>> On Wed, Jul 17, 2013 at 06:26:20AM +0200, Thierry Reding wrote:
>>>> On Mon, Jul 15, 2013 at 09:24:15AM +0200, Jean Delvare wrote:
>>>>> On Mon, 15 Jul 2013 14:25:29 +0800, Wei Ni wrote:
>>>>>> I think we can decide it in the DT, we can add a dt property in the lm90
>>>>>> device node, such as:
>>>>>> sys-interface = SYS_HWMON;
>>>>>> or
>>>>>> sys-interface = SYS_THERMAL;
>>>>>> So we register it as the hwmon or thermal device
>>>>>
>>>>> This is an option, but please keep in mind that DT is not the only way
>>>>> to instantiate LM90-like devices, and we should not expose duplicate
>>>>> inputs by default. It is fine with me if the default is to create only a
>>>>> HWMON device (as the lm90 driver was doing so far), and only
>>>>> DT-instantiated devices have the choice.
>>>>
>>>> I don't think this information belongs in the device tree. Whether the
>>>> device is exposed as hwmon or thermal device (or both) is entirely a
>>>> software issue whereas DT is a means to describe the hardware.
>>>>
>>> Correct; this is exactly the type of information which does _not_ belong int
>>> devicetree.
>>>
>>>> It seems to me that the earlier proposal of communicating to the bridge
>>>> whether or not a device should be exposed as hwmon device is the right
>>>> thing to do here.
>>>
>>> Agreed..
>>
>> Sorry, what's the "bridge" mean,
>
> The code which creates a virtual hwmon input when a new thermal zone is
> registered (this code is in thermal_core.c.)
>
>> does it mean we need to add a flag in
>> the thermal_zone_device_register() to indicate if we want to register
>> virtual hwmon device or not?
>
> I think so, yes.
>
> Alternatively the flag could be added to struct
> thermal_zone_device_ops, so that you don't have to update all the
> callers. But I admit it's a hack as the flag doesn't really belong
> there, so I suppose we don't really want to do that.
I think it's better to add it to struct thermal_zone_params, the
thermal_zone_device_ops is for the callback functions.
And I ask it with thermal fw engineers in
http://thread.gmane.org/gmane.linux.power-management.general/35874.
May be you can look it.
>
> I have been thinking of an automatic approach, based on comparing the
> type string passed to thermal_zone_device_register() with already
> registered hwmon devices, but I couldn't come up with something good
> and robust enough, so let's forget about it.
>
next prev parent reply other threads:[~2013-07-17 9:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 7:48 [PATCH v3 0/4] Lm90 Enhancements Wei Ni
2013-07-12 7:48 ` [PATCH v3 1/4] hwmon: (lm90) split set&show temp as common codes Wei Ni
2013-07-12 13:26 ` Jean Delvare
2013-07-12 13:50 ` Guenter Roeck
2013-07-12 14:30 ` Jean Delvare
2013-07-12 14:40 ` Guenter Roeck
2013-07-15 6:25 ` Wei Ni
2013-07-15 7:24 ` Jean Delvare
2013-07-15 9:14 ` Wei Ni
2013-07-15 17:52 ` Jean Delvare
2013-07-17 4:26 ` Thierry Reding
2013-07-17 5:14 ` Guenter Roeck
2013-07-17 6:26 ` Wei Ni
2013-07-17 9:11 ` Jean Delvare
2013-07-17 9:54 ` Wei Ni [this message]
2013-07-15 6:05 ` Wei Ni
2013-07-15 7:29 ` Jean Delvare
2013-07-12 7:48 ` [PATCH v3 2/4] hwmon: (lm90) use macro defines for the status bit Wei Ni
2013-07-15 16:57 ` Jean Delvare
2013-07-15 17:33 ` Guenter Roeck
2013-10-30 15:33 ` Jean Delvare
2013-10-30 16:11 ` Guenter Roeck
2013-10-30 16:56 ` Guenter Roeck
2013-07-17 7:03 ` Wei Ni
2013-07-17 7:09 ` Wei Ni
2013-07-17 8:28 ` Jean Delvare
2013-07-17 9:29 ` Wei Ni
2013-07-17 9:46 ` Jean Delvare
2013-07-12 7:48 ` [PATCH v3 3/4] hwmon: (lm90) add support to handle IRQ Wei Ni
2013-07-18 15:58 ` Jean Delvare
2013-07-19 6:41 ` Wei Ni
2013-07-24 7:46 ` Wei Ni
2013-07-24 8:08 ` Jean Delvare
2013-07-27 15:02 ` Jean Delvare
2013-07-29 10:14 ` Wei Ni
2013-07-29 15:58 ` Jean Delvare
2013-07-30 8:18 ` Wei Ni
2013-09-16 12:34 ` Jean Delvare
2013-07-12 7:48 ` [PATCH v3 4/4] hwmon: (lm90) use enums for the indexes of temp8 and temp11 Wei Ni
2013-07-27 15:38 ` Jean Delvare
2013-07-29 11:15 ` Wei Ni
2013-07-29 15:48 ` Jean Delvare
2014-08-25 6:29 [PATCH v3 0/4] expose lm90 to thermal fw Wei Ni
2014-08-25 6:29 ` [PATCH v3 1/4] hwmon: (lm90) split set&show temp as common codes Wei Ni
2014-08-25 12:23 ` Mikko Perttunen
2014-08-26 2:27 ` Wei Ni
2014-08-26 12:17 ` Eduardo Valentin
2014-08-26 16:37 ` Stephen Warren
2014-08-27 2:25 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E669EE.6000705@nvidia.com \
--to=wni@nvidia.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).