From: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
To: Stephen Boyd <swboyd@chromium.org>, <agross@kernel.org>,
<alsa-devel@alsa-project.org>, <bgoswami@quicinc.com>,
<bjorn.andersson@linaro.org>, <broonie@kernel.org>,
<devicetree@vger.kernel.org>, <judyhsiao@chromium.org>,
<lgirdwood@gmail.com>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <perex@perex.cz>,
<quic_plai@quicinc.com>, <quic_rohkumar@quicinc.com>,
<robh+dt@kernel.org>, <srinivas.kandagatla@linaro.org>,
<tiwai@suse.com>, <vkoul@kernel.org>
Subject: Re: [PATCH v2] ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS
Date: Tue, 24 May 2022 16:19:47 +0530 [thread overview]
Message-ID: <51b8aca1-e038-4907-e973-ebdbebaf9b28@quicinc.com> (raw)
In-Reply-To: <CAE-0n53g9rWks+euk5KHBzmJNEB3xLbJzMgCxN52DO5x+9-Wgg@mail.gmail.com>
On 5/21/2022 8:43 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-05-18 05:42:35)
>> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
>> index da1ad7e..445e481 100644
>> --- a/drivers/soundwire/qcom.c
>> +++ b/drivers/soundwire/qcom.c
>> @@ -1333,6 +1337,10 @@ static int qcom_swrm_probe(struct platform_device *pdev)
>> ctrl->bus.compute_params = &qcom_swrm_compute_params;
>> ctrl->bus.clk_stop_timeout = 300;
>>
>> + ctrl->audio_cgcr = devm_reset_control_get_exclusive(dev, "swr_audio_cgcr");
>> + if (IS_ERR(ctrl->audio_cgcr))
>> + dev_err(dev, "Failed to get audio_cgcr reset required for soundwire-v1.6.0\n");
> Why is there no return on error here? Is the reset optional?
Yes it's optional. For older platforms this is not required.
>
>> +
>> ret = qcom_swrm_get_port_config(ctrl);
>> if (ret)
>> goto err_clk;
next prev parent reply other threads:[~2022-05-24 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 12:42 [PATCH v2] ASoC: qcom: soundwire: Add support for controlling audio CGCR from HLOS Srinivasa Rao Mandadapu
2022-05-21 3:13 ` Stephen Boyd
2022-05-24 10:49 ` Srinivasa Rao Mandadapu [this message]
2022-05-31 22:32 ` Matthias Kaehlcke
2022-06-01 12:57 ` Srinivasa Rao Mandadapu
2022-06-01 13:06 ` Srinivas Kandagatla
[not found] ` <61c151e2-c44c-3b84-9fed-a83abef83c17@quicinc.com>
2022-06-01 13:42 ` Srinivas Kandagatla
2022-06-01 16:55 ` Matthias Kaehlcke
2022-06-07 10:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b8aca1-e038-4907-e973-ebdbebaf9b28@quicinc.com \
--to=quic_srivasam@quicinc.com \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_plai@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).