linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Christian Hewitt <christianshewitt@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Benoit Masson <yahoo@perenite.com>
Subject: Re: [RFC PATCH 0/9] arm64: dts: meson: add support for aac2xx devices
Date: Tue, 30 Nov 2021 11:40:20 +0100	[thread overview]
Message-ID: <51fb0be9-9186-3d79-38fa-b8a5151ccba9@baylibre.com> (raw)
In-Reply-To: <20211130060523.19161-1-christianshewitt@gmail.com>

Hi,

On 30/11/2021 07:05, Christian Hewitt wrote:
> This series adds support for several popular Amlogic S905X3 (SM1) Android
> Set-Top Box devices. Like most Android box devices, they ship in variants
> with multiple RAM, eMMC, WiFi and BT configurations. RAM and eMMC are not
> something we need to consider to get a working boot, but we do need to get
> the correct connectivity spec. Broadly speaking we see boxes with Higher
> and Lower spec connectivity; High spec is Gigabit Ethernet and Faster dual
> antennna WiFi, and Lower spec is Megabit Ethernet and a single antenna. In
> some low-end boxes BT is ommitted.
> 
> The main reason for the RFC tag is to solicit feedback on the choice of
> the -100 and -1000 suffixes which are used to distinguish between devices
> with 10/100 Mbit (Internal PHY) or 10/100/1000 Gbit (External PHY) NIC
> configurations; which is important to get correct else the box will have
> no connectivity. I'm not a big fan of the suffixes, but earlier versions
> where I used -int/-ext and -mbit/-gbit resulted in users having no idea
> what the difference was. I'd like to informally establish a convention for
> this naming before doing similar things with some S905X2 devices.

I have no opinion for -100/-1000, -int/-ext, -mbit/-gbit or <nothing>/-gigabit or whatever.

I'll wait for further comments from other reviewers here !

Neil

> 
> NB: At the current time the Realtek 8822CS and MT7668 WiFi/BT chips we
> have seen on 'AIR' devices are not supported in the kernel so these are
> deliberately ommitted. The H96-Max uses a conventional Broadcom module
> so has more complete support. I'm also still exploring / learning about
> alsa userspace configuration so for now the boxes have simple HDMI audio
> support; wiring up the Headphone socket will be done at a later date.
> 
> Christian Hewitt (9):
>   arm64: dts: meson: add common SM1 ac2xx dtsi
>   dt-bindings: arm: amlogic: add X96-AIR bindings
>   arm64: dts: meson: add initial device-trees for X96-AIR
>   dt-bindings: vendor-prefixes: add cyx prefix
>   dt-bindings: arm: amlogic: add A95XF3-AIR bindings
>   arm64: dts: meson: add initial device-trees for A95XF3-AIR
>   dt-bindings: vendor-prefixes: add haochuangyi prefix
>   dt-bindings: arm: amlogic: add H96-Max bindings
>   arm64: dts: meson: add initial device-tree for H96-Max
> 
>  .../devicetree/bindings/arm/amlogic.yaml      |   5 +
>  .../devicetree/bindings/vendor-prefixes.yaml  |   4 +
>  arch/arm64/boot/dts/amlogic/Makefile          |   5 +
>  .../dts/amlogic/meson-sm1-a95xf3-air-100.dts  | 108 +++++++
>  .../dts/amlogic/meson-sm1-a95xf3-air-1000.dts | 129 ++++++++
>  .../boot/dts/amlogic/meson-sm1-ac2xx.dtsi     | 300 ++++++++++++++++++
>  .../boot/dts/amlogic/meson-sm1-h96-max.dts    | 145 +++++++++
>  .../dts/amlogic/meson-sm1-x96-air-100.dts     | 112 +++++++
>  .../dts/amlogic/meson-sm1-x96-air-1000.dts    | 133 ++++++++
>  9 files changed, 941 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-100.dts
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-a95xf3-air-1000.dts
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-ac2xx.dtsi
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-h96-max.dts
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-100.dts
>  create mode 100644 arch/arm64/boot/dts/amlogic/meson-sm1-x96-air-1000.dts
> 


  parent reply	other threads:[~2021-11-30 10:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  6:05 [RFC PATCH 0/9] arm64: dts: meson: add support for aac2xx devices Christian Hewitt
2021-11-30  6:05 ` [RFC PATCH 1/9] arm64: dts: meson: add common SM1 ac2xx dtsi Christian Hewitt
2021-12-06 21:34   ` Martin Blumenstingl
2021-11-30  6:05 ` [RFC PATCH 2/9] dt-bindings: arm: amlogic: add X96-AIR bindings Christian Hewitt
2021-12-07 21:21   ` Rob Herring
2021-12-08  4:44     ` Christian Hewitt
2021-12-08  8:17       ` Neil Armstrong
2021-11-30  6:05 ` [RFC PATCH 3/9] arm64: dts: meson: add initial device-trees for X96-AIR Christian Hewitt
2021-12-06 21:34   ` Martin Blumenstingl
2021-12-07  8:13   ` Piotr Oniszczuk
2021-11-30  6:05 ` [RFC PATCH 4/9] dt-bindings: vendor-prefixes: add cyx prefix Christian Hewitt
2021-12-07 21:22   ` Rob Herring
2021-11-30  6:05 ` [RFC PATCH 5/9] dt-bindings: arm: amlogic: add A95XF3-AIR bindings Christian Hewitt
2021-11-30  6:05 ` [RFC PATCH 6/9] arm64: dts: meson: add initial device-trees for A95XF3-AIR Christian Hewitt
2022-01-03 15:21   ` Neil Armstrong
2022-01-03 15:26     ` Christian Hewitt
2021-11-30  6:05 ` [RFC PATCH 7/9] dt-bindings: vendor-prefixes: add haochuangyi prefix Christian Hewitt
2021-12-07 21:23   ` Rob Herring
2021-11-30  6:05 ` [RFC PATCH 8/9] dt-bindings: arm: amlogic: add H96-Max bindings Christian Hewitt
2021-12-07 21:23   ` Rob Herring
2021-11-30  6:05 ` [RFC PATCH 9/9] arm64: dts: meson: add initial device-tree for H96-Max Christian Hewitt
2021-11-30 10:40 ` Neil Armstrong [this message]
2021-12-06 18:06 ` [RFC PATCH 0/9] arm64: dts: meson: add support for aac2xx devices Kevin Hilman
2021-12-08  8:20   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51fb0be9-9186-3d79-38fa-b8a5151ccba9@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=christianshewitt@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=yahoo@perenite.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).